From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E882A0522 for ; Sun, 28 Jun 2020 15:05:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 370981C2A3; Sun, 28 Jun 2020 15:05:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8F5771C225; Sun, 28 Jun 2020 15:05:04 +0200 (CEST) IronPort-SDR: gzx/flvLm5cmPPR4l+3rD4x/AH5HsqZkpANTFJm3HBDucfqZYpHHhM+2K9FcxmF/vExryewEi6 3x1uW+jEoPEA== X-IronPort-AV: E=McAfee;i="6000,8403,9665"; a="230630567" X-IronPort-AV: E=Sophos;i="5.75,291,1589266800"; d="scan'208";a="230630567" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2020 06:05:03 -0700 IronPort-SDR: SN2CCJIrsfSu2JSLqJhl69CaVNudl0jX8E8zdVdmsLwNf5I2Wn3dBvzN3TjKM9iZQ1stow/zWk HIo6eBY3YZwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,291,1589266800"; d="scan'208";a="265993624" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga008.fm.intel.com with ESMTP; 28 Jun 2020 06:05:03 -0700 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 06:05:03 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX159.amr.corp.intel.com (10.22.240.24) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 06:05:02 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 06:05:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLq+u9xOqCUEpxHxawr/toR/qC8oCQT2uZCgUx52qcsbUg8xFfhl/0ncLzF2wNHJUaTMn1DsG2vlZ9hos32RcHhp0ZQMLAydVytvVaj8go09wGhueyYDNRP4+ROuEpt5PzDBCivv75JwyFltBGgrAUtjA2xsqIlDMY+by5sFPYU+qmjSJ6pTM6xKuE1CqJdlydaYxbE5IK2cp/FjihhgLChd71IXXQRIvyay7xmisAQkmTlw8CBtFG0dc1A4ezkP+ooHfr0+1z84nWv8BxLKnvOfSZ8K9sEx3X1gYVXIn2biQPFZN8U594HvnUAv2nUDfn9hYXKpvunEz5H4fMU6YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2WjyFce/rsJRuYKoTd4DEbJtohhufy0rgeNehHJtoA=; b=HsGYIMg7IBDZQUUqOQCi9Pw2fuoVYWyr8+uw9SWqGClZqTX92lyvH7fMRVDUnsOiWCy8pa0hoK3ZMA7aYIGHv3oHgzkD2VrkP4ZoD6c/YqdJ+dnX6QezVeBKmrkZys6PuQeii8RoICTOnH49TTucnXt9/nl199usKSfwA7yjyjTkFCWSnZ5XyIMXH0ErnJoUthVVeASb5q5fbUVP+m6EF1Fk9RLZMYVJEGWPMwef+IK+pGaiS86BBhzr3HMk6qXuv4NtK8+TaA3TQLT+vqUTCQ4QmbfoHkt/oIFNAdXv72DeBL4qA3MmmqUoZC5iw3UibO4N5fRZcZVGuJiSMypNvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2WjyFce/rsJRuYKoTd4DEbJtohhufy0rgeNehHJtoA=; b=XwO+daQtK0fCZdmWpLuDToE+zgNp67HDeDc/rMkUGXFKyrGFLeWxlU2+yo6HZ5WwQRyK1/fcAAAvbbwCAOe7uLZ5AIwsxKGuJrCNi480VmI1Xzd2xOdWBh9nb5iAgkRkiPgbh4mxc0rOvkq9bWWS0bY+EBhle7yQ3R0XsxZEKfs= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2725.namprd11.prod.outlook.com (2603:10b6:a02:c5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Sun, 28 Jun 2020 13:05:01 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 13:05:01 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH] ring: fix error vlaue of tail in the peek API for ST mode Thread-Index: AQHWTRTKtZO2NnCEPUiC4Toj82eC6Kjt/uoA Date: Sun, 28 Jun 2020 13:05:01 +0000 Message-ID: References: <20200628062348.23063-1-feifei.wang2@arm.com> In-Reply-To: <20200628062348.23063-1-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89004779-88ad-47f4-06bd-08d81b63de07 x-ms-traffictypediagnostic: BYAPR11MB2725: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1388; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tX6L0A5iDbsFPjIwROQbletRfyqpDMxVb9ykBV/zpwt2l520eKM1CI1vZErwDX4BenVCZ/LWLM//xZxAe3C5f2oHRt30tC16zlmmm7KW04Qs0EKPGPRP6niqmjo6/luvqV0jEyVWVfAzNAvZeBpQzK9Um3tIM+8eV6uVoyjnEAKzq4Tin3uH8cC7uDCspBa72O3ApHm7HHmlN6Feh9bo16ZJ0b61lrU6yDD8EGFrUQjocFl3dE++UxPZr6NiiYGFH1pOLbMCm9DdmmosOPF6bK8lciUQxtUIPOJCSINGLexA7mE0sI9e9lKV+4/A6pwgxPWx6PnMS79CZHvdXj5jdQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(55016002)(66946007)(83380400001)(86362001)(110136005)(33656002)(9686003)(66556008)(64756008)(54906003)(66476007)(66446008)(316002)(52536014)(5660300002)(76116006)(478600001)(8676002)(2906002)(4326008)(26005)(8936002)(71200400001)(186003)(7696005)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 5GEnNR8+ZNx4SJ8n2lm/Y1T9yWO0/khupToZozTlTnbNYe0bO3qSgjXbDIzx3lJ4GUJwnVeKQjIFHd3KL/gXLjtKaGv4X+xLDtHajhbEmJmCqoPaU2BDCwGWSdKrm/1C/g29HtsSsQMx0jFxZG53zLokIdd0aDYWdCBZSdh41vBlWnHGFkzFoq9sVP1sPw7+Sx/0XS0egFCSV7LfgiSU/2ifrJSzpzU/KaZSLjJQl2KloIvl+Giy5K82XI0rJA9NNBjCO4w2T9ZElcxrFnQz4xATlO6t7WRM9vKXNa1wQ0JA7F4flTzgfmQD5oFkKTxqwQrKzLGvwlUEs9hdscswhJ3Atmvtl2GrtfqnARBC5CGSb6xjN+yW2ACVXywDPPl6SoovHKeObU50bJcTQbsxAytDC+sU94YcQAyLFjWM5PRb9epYKQda5/bLgMrdveJ5BT9tUUEaxVstNGddO93eey+QkVMBK25iIuT7MTz3n+OvDLMyC9INZr+FLzbTv2OC x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89004779-88ad-47f4-06bd-08d81b63de07 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 13:05:01.1890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLD94nLd5RWRN6Blze39zFOj3LBC9cWqKeYqN1++e5i9ooLFd3c1XeDjMGXOff6GauRL67zq84rJNsZ0Mr5V8yAFihaXGdGj9X/afjZiYgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2725 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] ring: fix error vlaue of tail in the peek API for ST mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Feifei Wang > Sent: Sunday, June 28, 2020 7:24 AM > To: Honnappa Nagarahalli ; Ananyev, Konstan= tin > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang ; stable@= dpdk.org > Subject: [PATCH] ring: fix error vlaue of tail in the peek API for ST mod= e >=20 > The value of *tail should be the prod->tail not prod->head. After > modification, it can record 'tail' so head/tail can be updated > accordingly. >=20 > Fixes: 664ff4b1729b ("ring: introduce peek style API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/librte_ring/rte_ring_peek_c11_mem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ring/rte_ring_peek_c11_mem.h b/lib/librte_ring/rt= e_ring_peek_c11_mem.h > index 99321f124..283c7e70b 100644 > --- a/lib/librte_ring/rte_ring_peek_c11_mem.h > +++ b/lib/librte_ring/rte_ring_peek_c11_mem.h > @@ -40,7 +40,7 @@ __rte_ring_st_get_tail(struct rte_ring_headtail *ht, ui= nt32_t *tail, > RTE_ASSERT(n >=3D num); > num =3D (n >=3D num) ? num : 0; >=20 > - *tail =3D h; > + *tail =3D t; > return num; > } >=20 > -- Thanks for the fix. Acked-by: Konstantin Ananyev > 2.17.1