From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45BA0A0093 for ; Wed, 20 May 2020 06:13:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B87B1D170; Wed, 20 May 2020 06:13:50 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 139391D127; Wed, 20 May 2020 06:13:45 +0200 (CEST) IronPort-SDR: p+kSU0tz8dgYcaVAJH18GuddhK86exWvZftdiCozcd29eGgC6N09wtZkrTjmbCSE6ROYhWMPoU oVcq01nVgBGA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 21:13:44 -0700 IronPort-SDR: 19dqwO9IhldYwR+uRKlrLGZJY9TC5OixhE06x6Um7woK2yrv4BEpEc9bMBKCl8cJDI7y8wpdvb gERpGAp0LXww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,412,1583222400"; d="scan'208";a="282551329" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 19 May 2020 21:13:44 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 21:13:44 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX121.amr.corp.intel.com (10.22.225.226) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 21:13:44 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 19 May 2020 21:13:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJq5cabQGcX1ZMxXU0JxIAuSoYg1dLLbP+jRhQd77jC0FBVvkXMKC64hrHNdRBbglvdPr67TP7NRIpFNJhKSbA4TVawwSyrZgN743xa6/qYLBG75dpTJrJbLj0z0vdvPXsTBUWhS0pcgVAwMxQayRpwU2/hmlhfu6SLKj4nxzmWD0zNY21RJ/KvOp6krPE9HDJcMd0I7voudPb5znFlsoRZL50YkgosMn/I3MblosmOl910w6N3iDoAi+DOM5OhjI0w5mIOswxh7Gg4V9ZUXaO26+kZI6Ky9C4aD2gA6BSKViKkoRaAPiN0p+kPQdcA6LTS20pdQJ9fwGaF0ndgNXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ctzt/yIPiGCs40go6ohLtlrdocC3o2MUaREjymzCTU8=; b=LJAjqRnWWCwunA4KF+jYxgQUpbzDVyU80nFE9/2oL+XufWekX7447ee6KYuAz/MYwkwQlSuekaZCIYgEgECotnpExryRrH9EnPUVCpgnjJCFQrxLpuv+jdWrQTEsBG4uSRqiYPB2Fnc+nWx25eiS1dZgR1ApWl2v34RF6VsEWbCkEfnU1K5cGbcefjHu/8w8zxpIqa4VnQ94ZzWJHu+g7JMEzv4fZ0PezmWOG7w7g1KMnpXxN7/iXPRvc1FYL2Z0IvS8avKF3SfVNpbOCbvDYxZy6p/wh4leFaDQEkQ4dsRysNixr7iH+xKEx1vHLkuispfn5BvnfOxaoU45eWGDBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ctzt/yIPiGCs40go6ohLtlrdocC3o2MUaREjymzCTU8=; b=Pg42FxsqjXNli4f0Kjrvm+irGZvga6/8jYSuKBZKVYJRI0Xu0mwmFxgHjRqsWpBD+q2ysoVWLGUHQOgX3WE8M4bgP2X72mJO/0+UYNp+Cyws0vbhMBxqmywu0gL1BzdeGWfn8eOwBjlxkizUoPUZ66HUzBGwTIQ3IY8KMYqkkhI= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB2837.namprd11.prod.outlook.com (2603:10b6:a02:c6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Wed, 20 May 2020 04:13:42 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f%4]) with mapi id 15.20.3021.020; Wed, 20 May 2020 04:13:42 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/i40e: fix flow FDIR enable issue Thread-Index: AQHWLbDSamZnNIy2T0qCuc08s00UkaiwXW5A Date: Wed, 20 May 2020 04:13:42 +0000 Message-ID: References: <20200519071652.26537-1-wei.zhao1@intel.com> In-Reply-To: <20200519071652.26537-1-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWJjZGUzOTMtMjliNC00MmM2LWI3NDYtZWQ1NjhhZTlmNTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMWZhY2tQdXJtVER3RWZtQjZKZWN4OVlEVkl3blV0YTJ5Q2hkQmtwNnljbTRRRG1naXlqdFhhOVpuN3F4ampIKyJ9 dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbad21fa-c2c4-4958-598f-08d7fc742ea7 x-ms-traffictypediagnostic: BYAPR11MB2837: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rM/9tsLaFbg6N40+8GTqk5NMdZ1jKSz+hvneiHNwWDKCUjlWVa+7Q9G2RGRyf9K7gClFxpZPR/OPOAq+kFLVwnGwNW859FMDULqzrjCdapTKVaY6iXLRLUeLDcG/KbXLfqToNQAJoJ85MZkefKEn/WCQpj2+iXabrHSHCCFkUORb+C4H4Esu3NzqYR34AeobDHUbSGUvW5BxrR/7bFTXqe0c8BjLCwmxIF2897tUo5YiOhnHFed2N7jY83tYR9He3AELDthuv520PM2M+5k3pZBR0n00VGuH7FB8U+de6AfJWPZGis3aRZZzHy0HYQcRQ50+tYagmt/hNEfld2Z9m1mxjcNI8j0bi52J6INTN9yMglz+e/2R2rqkZ7+YIrgvLu3H4Y/EI87G+pXEjAvnQCzSrBDdOdoJ/7FRTdHtOw+29glsIoWN01jrOmSYVHYt x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(376002)(366004)(39860400002)(136003)(346002)(26005)(52536014)(7696005)(71200400001)(186003)(66946007)(8936002)(66556008)(76116006)(66476007)(8676002)(64756008)(66446008)(33656002)(2906002)(4326008)(450100002)(54906003)(110136005)(316002)(55016002)(86362001)(5660300002)(6506007)(478600001)(53546011)(107886003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3RRW5a7Jq2CEVYYbaKs33KebW8jS0/JnBKftNRfHpSwsAbzUWCv4PX3WAxQStgkWHE0noeB9BqjySDUxzH7jbmjPcIz2KsManWJJNP+8XNv/aCgeZSKkBFBBpDsBNNbzK7JdfOqy+qRrrWa128an9HhtprwSYSWS6qpp+xttjwv6wOZTfjuvuK3sv3g/15oBIi1MN+K89WUa3zkZzJVcIqsrDSdWLaKjbr9LXrpKwpy2plGCaT4Z/qHME/OhKDJf8a1GiMXGlXrEU3jEl6sOf9u0lt/lkoPeLjx2kr8AZ2A4L1yQpA9S6ZhmsAHCaZKBjqJ53szZoVylzvpOtEtlyu/FZp87A/ACriiCG21SyPhfadZ6MDEjesbnvGxhlv4dvlC6bQ0yytzy9TsSbhaX1zB9VRaV+62yDvNxJ7wVo8ni+2tA0tzWcocZ6solj5bdn9FcKOjxQtOiWmC2QWVob9aOR8A78+RninOOoFipp+A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fbad21fa-c2c4-4958-598f-08d7fc742ea7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 04:13:42.3600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R0gmfIjab1su97hW2RmsYBtVUAQLYx00JHHCvABIKyXS2ByIJTiRj2wKPcqSiOZJyu5XIO2WVIlKLVpWo4BrlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2837 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix flow FDIR enable issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, May 19, 2020 3:17 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Xing, Beilei ; Guo, Jia > ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix flow FDIR enable issue >=20 > When we flush flow FDIR, all queues are disabled for FDIR. > If FDIR rule is created again, then the flow list is empty, as it is the = first time to > create rule after flush fdir filter, so we need to enable FDRI for all qu= eues. And > also, disable FDIR for queues should be done in function > i40e_flow_flush_fdir_filter(). >=20 > Cc: stable@dpdk.org > Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter") > Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in Rx > queue") >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 25c77e7aa..94fc73092 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -3462,6 +3462,12 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev > *dev, > } > } >=20 > + /* If the flow list is empty, it is the first time to create > + * rule after flush fdir filter, so enable fdir. > + */ > + if (TAILQ_EMPTY(&pf->fdir.fdir_list)) > + i40e_fdir_rx_proc_enable(dev, 1); > + i40e_fdir_rx_proc_enable is called in i40e_fdir_configure, so could you che= ck if we can optimize this and if statement (pf->fdir.fdir_vsi =3D=3D NULL)= above? > return 0; > err: > i40e_fdir_teardown(pf); > @@ -5330,9 +5336,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct > rte_flow_error *error) > return -rte_errno; > } >=20 > - /* Disable FDIR processing as all FDIR rules are now flushed */ > - i40e_fdir_rx_proc_enable(dev, 0); > - > return ret; > } >=20 > @@ -5368,6 +5371,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > pf->fdir.inset_flag[pctype] =3D 0; > + > + /* Disable FDIR processing as all FDIR rules are now flushed */ > + i40e_fdir_rx_proc_enable(dev, 0); > } >=20 > return ret; > -- > 2.19.1