From: Gregory Etelson <getelson@nvidia.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>, Ori Kam <orika@nvidia.com>,
Yongseok Koh <yskoh@mellanox.com>
Subject: RE: [PATCH 19.11 4/6] net/mlx5: fix GRE protocol type translation
Date: Mon, 6 Dec 2021 10:10:26 +0000 [thread overview]
Message-ID: <BYAPR12MB26311C540E6A702FEBF54282A56D9@BYAPR12MB2631.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAATJJ0KZRswLK_9dQRvLF2DOH_97NcS3HyAoPFTT69cZvTFPhg@mail.gmail.com>
Hello Christian,
.. snip ..
> > Hi,
> > build tests have shown that this breaks on
> 19.11 like:
> >
> > [1479/2115] Compiling C object
> >
> drivers/libtmp_rte_pmd_mlx5.a.p/net_mlx5_ml
> x5_flow_dv.c.o
> > ../drivers/net/mlx5/mlx5_flow_dv.c: In
> function '__flow_dv_translate':
> > ../drivers/net/mlx5/mlx5_flow_dv.c:7912:4:
> warning: implicit
> > declaration of function 'MLX5_ASSERT'; did
> you mean 'MLX5_SET'?
> > [-Wimplicit-function-declaration]
> > 7912 | MLX5_ASSERT(false);
> > | ^~~~~~~~~~~
> > | MLX5_SET
> > ../drivers/net/mlx5/mlx5_flow_dv.c:7912:4:
> warning: nested extern
> > declaration of 'MLX5_ASSERT' [-Wnested-
> externs]
> > [1538/2115] Linking target
> drivers/librte_pmd_mlx5.so.20.0
> > FAILED: drivers/librte_pmd_mlx5.so.20.0
> >
> >
> > For now - I'll remove the patch from the WIP
> 19.11 branch, please
> > consider submitting a backport adapted to
> work on
> > https://github.com/cpaelzer/dpdk-stable-
> queue/tree/19.11
>
>
> And dropping that makes the subsequent
> "net/mlx5: fix GRE flow item
> matching" fail to apply well, so I had to drop that
> as well for now.
> Let me know if you consider re-submitting
> updated backports of those two.
>
>
I reproduced the fault and prepare a fix.
I'll post v2 later today.
Regards,
Gregory
next prev parent reply other threads:[~2021-12-06 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 16:03 Gregory Etelson
2021-12-06 9:54 ` Christian Ehrhardt
2021-12-06 9:57 ` Christian Ehrhardt
2021-12-06 10:10 ` Gregory Etelson [this message]
2021-12-06 10:38 ` [PATCH 19.11 v2 1/2] " Gregory Etelson
2021-12-06 10:39 ` [PATCH 19.11 v2 2/2] net/mlx5: fix GRE flow item matching Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB26311C540E6A702FEBF54282A56D9@BYAPR12MB2631.namprd12.prod.outlook.com \
--to=getelson@nvidia.com \
--cc=christian.ehrhardt@canonical.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).