From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93F07A034F for ; Mon, 6 Dec 2021 11:10:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BE0F40040; Mon, 6 Dec 2021 11:10:31 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2051.outbound.protection.outlook.com [40.107.96.51]) by mails.dpdk.org (Postfix) with ESMTP id F0D1A40040 for ; Mon, 6 Dec 2021 11:10:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arcBK+i2qlPP9D8Lx7mehR1YVik/ATJOqOme0HRf63eLmVVLN6qL9xHrJWsxqU5Xbuh7XXtHF6e7SS5g1rPIp06Ejl0acRWQO7ZCt8xUlam14Yb8yzIj87oi83OcEAWqi021gCzniixqHWErfDfLiBI6liW62CBijo29CC6btmHFE5WSOF6a2oenBlxglXn3VOXzUdZgdWfN1xgn07eeUMsJ9k8XLu/wEt2ZMDdnBk9MI5fDa6zGxW9k6ES+JCJjq8hAUREzvcT+HdOilXPVDSqhqdHP722KN6AhaXNU84C3+DHEjXYUcUeImUwistVd08JQp8uA4isA30gqlxC1ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Tb1zKB5EZiVkXN3vbNIws+VVXojSDd7Qjg0SVpal/Q=; b=haCHHGBQ1JRwsIIdf79KunCslgUWgUBvqOivUNEXKsJaH+92cLuGLyFcpEdY4KKaTiCRyHlqnnCK16ldBXkSZKh6NHCv4NiZI94zzv0aHRc8s1bNxe5sc5NY0z+xMunBLOLAYj1/m02DFfnAl6+iNQETWKVgIi0PnCDupggHPSYoGwzZGbfysXntPL0eMJTgYOXmjhrnrk084cRe6xj4NLGbhmWHUtHg6/CwShG/TlY+U779lJ87oYGUqM2PpJuGREAsXOCPATjwMuscG6Cd6LBaDkYbtq/TRjjB1WTmf4EK9VwXpE1UBS489bd3lgx+xHKpkfcMHHM7+tecTxxTpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Tb1zKB5EZiVkXN3vbNIws+VVXojSDd7Qjg0SVpal/Q=; b=qvvV24bb8Mwp/rM6HLVuDTpPePQV8l5hcrk5JmPgANN463+T0k9uS6fNgK/+KZm2Dkih81+rL9qFeNfVya1GU7p877YaQaWRlmwGwUq3cqbZHYWgDqsCEmCALHiANjvPimiRuShYYlXd3LIwnS/dWBnQx7uA8m6TO4L1YyY4S4H5mZRtbT2d4VEOJivQnSIkyi/0VI/jtSJXmxQb+MsQQSWNxgg6kHkzVsA8NB2NFQuVcFmc+KmM9GXzJEBmH/QhighJTffIqbkPMcE2i5z2sbyhk/4pyv5pcnhrkS0LV0ucH8diHUpzezuJvFyLkdhA0f7wKdS4HUmWHTuqWp6vcg== Received: from BYAPR12MB2631.namprd12.prod.outlook.com (2603:10b6:a03:6b::22) by BY5PR12MB3745.namprd12.prod.outlook.com (2603:10b6:a03:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Mon, 6 Dec 2021 10:10:26 +0000 Received: from BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050]) by BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050%5]) with mapi id 15.20.4734.028; Mon, 6 Dec 2021 10:10:26 +0000 From: Gregory Etelson To: Christian Ehrhardt CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , Ori Kam , Yongseok Koh Subject: RE: [PATCH 19.11 4/6] net/mlx5: fix GRE protocol type translation Thread-Topic: [PATCH 19.11 4/6] net/mlx5: fix GRE protocol type translation Thread-Index: AQHX55YyX7fu5IcgaU23aOk7qt2khawlPzYAgAABBgCAAALK8A== Date: Mon, 6 Dec 2021 10:10:26 +0000 Message-ID: References: <20211202160314.26638-1-getelson@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01ac5236-b898-40a0-ab78-08d9b8a09fe4 x-ms-traffictypediagnostic: BY5PR12MB3745:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZWxEjcz2AkUz8EQGNx4ECRjbRbCYr1+n206o0+q5PHI66WM29ed5LtpSZ5iIFztXz4tFg8jglxLoXo/YapODtDa45X57SVTftj/aJshB31r6BmOYbtr+dE6rUJVKAR6v+ofeHMz5Ww97/HF4e+RAfjy53OctK455D8Vtn8Q0jIrS5yqd06Zsf83+8hsqsbaZouQNiWyZFLCeD1XLs2+3w/JzR6GnGErzfNmJVqxeFdvOigXuJmdmqLLEHhQiGNmSo5UXE5rDlcrxiEp3INuXNgMfmH9iXMmFS9uSE1KxwWVQocl7r1HpTNhSiE9bky9D35kBgx6nEpgtc+51i4aBX4//9/HH8cgcwPmlOhGnjDs1D9Y9nkArajxj17Wg9sx86VWpm0rccy9ILQl4SUudP11M8yYWaOlpbuU2Gwpc16PwYtDlyvT003ifUZmKSOO5xOBoqcUFZiCbzKJRIVqQQf+eaGy5BikRVShbwEz737KmW6/79V9ysUqE9hs3FYbZ4oXzWbsN0R9k5zEndZ/WX9axUfK5b1tnN+GIY3t2RDY9QMAISTVnN+ObtK6TlokqVlv7Bi87rr7FCoKxgeAggDJXoOtsKhw9/tyZU/FBdqH2zSDyl4dYgP80CsourW9tNs889zgk3GJpZxMnGSMai+pupz6N+0G0ygjmir30HIdQtpiwwQKgGgB4kztp+61LhUiFpM1ngpDyax5g/QFkMrWwjWa0H7d/BcUyhHEcThnjkuQTxejE3BnuTLD1p0f0Xh99aVtPrP/qXi1SJGtyrH6aZXbeR2kKe9s5BivQsw4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2631.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(9686003)(2906002)(38070700005)(122000001)(966005)(508600001)(186003)(7696005)(83380400001)(38100700002)(86362001)(26005)(6506007)(6916009)(5660300002)(55016003)(66446008)(64756008)(66946007)(8936002)(54906003)(33656002)(316002)(71200400001)(52536014)(76116006)(107886003)(8676002)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OL9e29jMTYV+UNw/RoW/QpcuV10IMmSr4TKbnYTBPpNGX+t3IBaUM3R63SpW?= =?us-ascii?Q?ekgZxFC0SycupsBwXyyywtox3IN58KQj6Teyb20mCmIzkzRbMalt/XyHqQ8X?= =?us-ascii?Q?h2VZlEFr6vT0Xv1/zi9tGdc1Fz2KfoWB9tq39dpydEqrP0QU4n0i1eTb5Ogl?= =?us-ascii?Q?aZWwHpQvh1Jqg7TVnui52nZDGSPK8DP1/zn8LCORV+LfEbiLdDsWbR9+EoSY?= =?us-ascii?Q?h3zDbP3k6ZWTTItzNmGu6Jeg4dTCkXadDn417LHmVdav5xa3rn9s80q5FMDB?= =?us-ascii?Q?+oO7+aJVkgqBAW/E7aHOn1+0uktwmnyWzWEbu3aDvA3MggmvqHGTJw6G3yMr?= =?us-ascii?Q?G24O8su/MEGI/9wKcSpoHroFSU14kt+tUXg4VMucS/6njlAgPD8ounCOeZ4p?= =?us-ascii?Q?O3DYrnlO3ChcfAiyvrFdBBJ/72lNcu78KLrQEe+U/EKQKwTDqHZ6yn4qAZYv?= =?us-ascii?Q?IIh8Z2x6FEAgDlAaazH+2fIVdTwcxWCa7raswEUN4s/h0FXtHBgF0OB6o6ak?= =?us-ascii?Q?cbgRXBRoK7LbwQNTZ57TmuCg9ssZLG5B4O17TB7to4XrLpdggrQuA47zD4Fv?= =?us-ascii?Q?/84/JH47UOKQmlsD8R9pqoC90t2WmKGGb9DzWTjIFWAaDxCKoO48mQXDWyuf?= =?us-ascii?Q?RmqXpljmSX1xSosc4phRkd3KAS2cgPH0fxkxOplr527TkFgyi/XLUWfXUnDV?= =?us-ascii?Q?j74IzDFvOGwrSG3lsmrwSx75rNh4hmfy/79YNlDpVSBLJIB1idcM7STwgYjG?= =?us-ascii?Q?ZimLtsbpqHTuN/sjGF+x0+v1uyd5Nl9rs8uwCxav57f04zV6+WYnApZc8roN?= =?us-ascii?Q?Suvn7t0WVD2YHdAmcOwTaIEnPhUWtmz5S47SMb1NkU86QD+r9DEFpylNI7Kp?= =?us-ascii?Q?IW4NCqRcflma2ZcD8FnVO8uyLOibsSivHTwCtfzZP8CKBSwi4QP5wtr3ygHL?= =?us-ascii?Q?ddwAHygU+espfm7DRtbfeVP6dAkxYuT/uC2HZWt9Aaq4PG5fOZgK7eyNqh1d?= =?us-ascii?Q?mf7Dd3hgA15NnvIxVGEAes9lt3wECzld0CHUarBYIDbUwjZJMehSWXQ42wPg?= =?us-ascii?Q?OdsT4In98NKTr8bi/VfovcWpM3orq3PLRYuukpB5wywMVUxM8dnEb5k0DVb0?= =?us-ascii?Q?e/Xi8HGz3nuzlscOVREcqSINJm2OJmj9Paty4w62LHyimZvJ16vv8EjFCs5v?= =?us-ascii?Q?4xgZvw3aHjLIiy1PBXC+FjuoH+CxNR+So7t3td6xB9sm/vcszv7zt5x/8/H/?= =?us-ascii?Q?FIr0x+X5U8ey8ES8K0hz1jVULB57cVVNIL3K1XglyuD6zbmGD21pmcuVbKLF?= =?us-ascii?Q?xo0IWCDyxP+XW7oarPzAdNPc27AJWrmsYO0O+1rwTQRqAX2/lh5dU4Ue2CbW?= =?us-ascii?Q?PeWvr/wnQTgmB7IjY0goSprlAqvkDiF5GRPDdSKbPorzJu6H4MxQXT6KtI3k?= =?us-ascii?Q?W8Q2SkmUVjDl6FEVkWswcCBsbA4WlEWwV4pFVzcUmQK5KMJ/qj5g2tljyAUL?= =?us-ascii?Q?QRUCj91wDsZBxx1/i1zm8wYdIurvw/Coc5uI6dm7EGBr2m6Tuf/Re85zie/g?= =?us-ascii?Q?f5uR8asdjRIutHQLgefM1Awbov1qTwrtzcQc7B2Q+05xKOok2orsE4mpGqoS?= =?us-ascii?Q?IE5uE1qC9fjtaSklkgXh7SQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2631.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01ac5236-b898-40a0-ab78-08d9b8a09fe4 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2021 10:10:26.4958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mZBVAQkHzCVQTzabsT5RqzeYXkXfegnHeSJBs2byPBo4YyPt3QyPn5FmU7D5Turp9sqJbStyXFR3I1lcYXHEug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3745 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Christian, .. snip .. > > Hi, > > build tests have shown that this breaks on > 19.11 like: > > > > [1479/2115] Compiling C object > > > drivers/libtmp_rte_pmd_mlx5.a.p/net_mlx5_ml > x5_flow_dv.c.o > > ../drivers/net/mlx5/mlx5_flow_dv.c: In > function '__flow_dv_translate': > > ../drivers/net/mlx5/mlx5_flow_dv.c:7912:4: > warning: implicit > > declaration of function 'MLX5_ASSERT'; did > you mean 'MLX5_SET'? > > [-Wimplicit-function-declaration] > > 7912 | MLX5_ASSERT(false); > > | ^~~~~~~~~~~ > > | MLX5_SET > > ../drivers/net/mlx5/mlx5_flow_dv.c:7912:4: > warning: nested extern > > declaration of 'MLX5_ASSERT' [-Wnested- > externs] > > [1538/2115] Linking target > drivers/librte_pmd_mlx5.so.20.0 > > FAILED: drivers/librte_pmd_mlx5.so.20.0 > > > > > > For now - I'll remove the patch from the WIP > 19.11 branch, please > > consider submitting a backport adapted to > work on > > https://github.com/cpaelzer/dpdk-stable- > queue/tree/19.11 >=20 >=20 > And dropping that makes the subsequent > "net/mlx5: fix GRE flow item > matching" fail to apply well, so I had to drop that > as well for now. > Let me know if you consider re-submitting > updated backports of those two. >=20 >=20 I reproduced the fault and prepare a fix. I'll post v2 later today. Regards, Gregory