From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64601A0C41 for ; Tue, 9 Nov 2021 12:49:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FE4B41104; Tue, 9 Nov 2021 12:49:41 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by mails.dpdk.org (Postfix) with ESMTP id 068D54068B; Tue, 9 Nov 2021 12:49:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lsWt9abU/d4X6Ky+PVxKQ3C6MG8BXTpd7zEHqUyrsVkqzGr3GzvqHYSWgIml0kPsM8+7qfSDrdNZq00cA4l1z/gjITphWkAUxS1nekArMpAAlLGcgFGElis3Xh4sv8P3njaQytwiOO0NHynHIEfw1b561TMkpNlGKyBNwcQqFVdbK98kTYK0mgJOEEXGsZI73W1V0gnc5e1eaQrhcvKiErOfyY9MTP1Z5yjMDHHyEm4bwjgWp+oErJpAPIRu0Spqtf2wN7ClGW+pGaAqa6RmGEyXQU9R1rubj22VtFnpUGwwehXrPPyTI12euLJvQUop477FU32Xj6Nwfb3KZRfePg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ksDaMWoWt6s+9OG/X2xqhvCUwgwGKwbk16LvBJdq/cw=; b=meWBKwEdE9LQkyjQqf4X5yBrBzOno10IIwmS+4xpAZrwPf1168/XTPMzbf9qle/sm9CeNmY4+2Sjz0Ky9D7+DGyE4051j5J/EjZdRwLGzdXRYTh2NZcTczEbRBC6brjTDKdNbrq5Ghg3wG4AC8ZxDYCTSFI77EB7uDLiexMzd3mvcLysAxWremb8n9X7Z94MYiWpCv/bX1LqKP8H6QNVgzBPY0LgjG1kqF5i99R6n84HSq270vEmybr4BruZJ5vYL8biYUmkOJCjss58rSUfjNsHx+1bN/QgB1HQNDF+8g74GzF5pmN93wvJ784QHM+lT+ePqC94Ty0yEcYHoz8rfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ksDaMWoWt6s+9OG/X2xqhvCUwgwGKwbk16LvBJdq/cw=; b=BwwksDFJ5/Rr3ake4ZQxn1pS8ZtnpicyGEw51NHtF20zehpPHf0ZH7NyFfQYRuzKpn5G/3rIVk9QdunZtsfj+ksYJS+5adPWMVBD4Z8IsstaQGEcj62ZBwzQ6K17PiD6XyaZgY6rynjQWUYNvShPsePXeb4V4oSmKpPsmmK3M+ZIqPZ6afVLTBH8H9yV3KH57Z8qH/MvKb+cxtzMjD69LFwRF5juSC0JWWeX/mID4gSuRS5pkbj4DPyy+X0195QaeEp1wyD68x0SuxWlWxr3sGSQ1dBo2tTMM3jVs9DwsZFdZLevZf3AGG+jodNK+2l9vnTIL6gPDzGTrrDpYahR/Q== Received: from BYAPR12MB2631.namprd12.prod.outlook.com (2603:10b6:a03:6b::22) by BYAPR12MB2741.namprd12.prod.outlook.com (2603:10b6:a03:62::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Tue, 9 Nov 2021 11:49:37 +0000 Received: from BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050]) by BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050%5]) with mapi id 15.20.4690.015; Tue, 9 Nov 2021 11:49:37 +0000 From: Gregory Etelson To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , "stable@dpdk.org" , Anatoly Burakov , "david.marchand@redhat.com" Thread-Topic: [PATCH v2] examples/multi_proces: fix Rx packets distribution Thread-Index: AQHX1VB1ORKPqe4s1EW7VDT7WqHjDav7EUAAgAAA/kA= Date: Tue, 9 Nov 2021 11:49:36 +0000 Message-ID: References: <20211026095037.17557-1-getelson@nvidia.com> <20211109095847.7642-1-getelson@nvidia.com> <4872412.G4mxdARt5T@thomas> In-Reply-To: <4872412.G4mxdARt5T@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25341151-96a7-4fef-0b28-08d9a377017a x-ms-traffictypediagnostic: BYAPR12MB2741: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mIv78h2lIYqct0+iyc/yazIOGM/y4KnxIhhpFODY8lqxuMjTC0rtu9A1fpS0uqv0XrqyzLP819/6ULN9t8q9RWXlHCSvclhmmg+H6TuruMbV4MMvkQspHtg0dip/O5qbUZabNv3vJGi1v/GYTzEQAJcRGKQfF3q+MaOKrq1WpyUK7UYd22ZGmzFYfakQ8o00RzQBJniqHBLYaEHYdya6E40ifC85QUAv7P5zGfnz8BGtlCTe2V3foetB+0FtodiANSPQ7QrYLqDucBYeFWlZWvaj+PY4gwKfGGlpwW//ZVPrLGUPCDjshTtUNdSs7f5eb1O4IfvOZbsPibnesa0IB5RuZ1k8G+HidaiqkhPfgb8sei7e49Sn5LrJo1wxtLBGXmRAIOYegGcNxp70v4Cqf057lWBp6vndKLVU/Y7ajdszT9oXU+jQQA8eUSES3vNeoRWtfvusktSrZzxBt2wAwf/ZNwT2fO5wYtm4NK2urswILOspQdtpBtJ+hiy9/58/s1c+JH3yoV5HeUzlkYeKT3iUjxjNKYpBn25JSDVevETmawglL9q1LAdnguDQFP32xSFRSgTfWYfJIimQjfX4Z0AsMT1k1EDkTL3YSwlhvG8VcuQp5HfipTxatdDDms3JA4xJ7CzzOsNGhLukPMMPzejqdQ1AL+742kzvEIlU1ALCG3mhA29u2kfWcBPUwhBveeU1Q/TwF6ePs2BTIfAdnw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2631.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(6506007)(122000001)(38100700002)(316002)(186003)(9686003)(52536014)(38070700005)(8676002)(8936002)(508600001)(4744005)(7696005)(26005)(55016002)(86362001)(64756008)(66556008)(66476007)(66446008)(66946007)(6916009)(5660300002)(76116006)(71200400001)(33656002)(2906002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?imVECwnIFcgHqho03opsDzEPvUxv8lgDrh25FeJUGlmy/UWCwzXi9vu15x7d?= =?us-ascii?Q?kN61O8XaJMdlDiHEe1C6eKKUTLXszdgN1t/f2r70z6HAVqCs6XA0ew82uakV?= =?us-ascii?Q?xrs6EIVGejkYqhKKEjLfNViZvl7OC91V2zaU06AaA4y/aXXdwy11zh6E0sqs?= =?us-ascii?Q?YAFdLb2gvwNnXP0DJf0WgyR+KwJaWS/Z3+QbPKJrolF1s+CycOkd3Qhrwbya?= =?us-ascii?Q?BLFrVrs3iIl+6Wnq5Sokub3VUTtkk+teUg4CGUVhWxEhy/mFtf2cQ7gvQn4D?= =?us-ascii?Q?No0VW/09reFPOUcAQkEAZF4ZO8FCTQ2JmVmOy6S5T5SUel9dmNBbdthhCfzI?= =?us-ascii?Q?4wuERq83aCOYk0BmkjVCnwsLFhtN7Dy0HGXs23jFWdxU1TFPs+2hOPZJ9fAn?= =?us-ascii?Q?utWczY6vvaI480XVKo3CJqXjxjkjE/Jrsv4MI88Bl5tPl0ZHlCyJILBz3Rf5?= =?us-ascii?Q?lSZ5UXbEvxG39U/5yC/q0+fwxyeLvBqd/EXPakEXgwPEyVEM/LsYpxyWgjf4?= =?us-ascii?Q?zyUr5UaxZ6iPHyx5VsUGxPcqzNdAHqZcOmxyU02HGVFtONJ2ejVhD99DcXGb?= =?us-ascii?Q?UoL5jRfbXRES+rZAtT1Kr/DJcBRwcuu1GTU6uzbn1tFKwMyEmTs7/aP67xlk?= =?us-ascii?Q?FKe6U4/KtBRmV+IbgH0Y2zM6Uoha7JgTpfFPy48vQOUDlkNvjvuyJxAHi/ww?= =?us-ascii?Q?Kp3fekc/ALwtnZHj5gVwtmNs1lvJiu2HV2r9GBPENhBA5L9YSAX3YoLPgDPx?= =?us-ascii?Q?wPJYdVyit8ZXx0wLzrvXHr8VIqBPIMTZ5acMuOhUztI4F5brkqvL8KydXKiM?= =?us-ascii?Q?Taxj1JN+53WFjy59O4Pzu6zvzXWuURH/lFMxJcSwj/V+rD+C24yR75aPXdvo?= =?us-ascii?Q?sFBvjkG3c7LGPAWtn7A6qcw1U+uwQ17Yjz7ZtBtHSmCPfhFUOc4zUgZUK/W+?= =?us-ascii?Q?FDPBVmyIcPkNYZ2/lcnJkNR2RhsogOI4NZ6DS4f/o0rfwcpPcvlS9RNTRAi9?= =?us-ascii?Q?PtUVKapUo/QmEgW5QU5te7KP4ZY2eDIUIEXepxXvbY6VhXHOuQ6kU5AGq9ko?= =?us-ascii?Q?ObYxYKPud3Pam7fncDIcuGf5k7kFPDTLwXqN6DsM5aGk0EcaR+a3AvIEl9cj?= =?us-ascii?Q?um/ffOxT+r4EkVi9jl7EPgLpxk7cm+CFmz6hSlqZuCdn0cVwNcyH1Yw6Gq3u?= =?us-ascii?Q?nUrTmXmzR7hg3BZ2WJOWGcPv+sdE/VpVuwJ2CDAzrhGfFde2rzNHW67wkDhW?= =?us-ascii?Q?4qYjXj+iiP46jRgzaYIn3lzGXTN56y8p/sKHdiQf/By/Riublz09Fg7wVeqs?= =?us-ascii?Q?3pi8dt7ksungNVtER4ekCiRSonzReYmBeKJJ2H2wRQV0XWGbwwAKo4NolMA0?= =?us-ascii?Q?TTBIMwGedeWb7FVwIEjPUMsjX3dZ5nyUmZyp19bts4okvHyfWE9ABVmSefjs?= =?us-ascii?Q?Q740a4nYD3QUS+NsmiQEx6FvGVtRFXHKx86DYvpyQYWlrnM3RvZ2r9AvZkjP?= =?us-ascii?Q?d9bsVXl0tprVIMdB5VqovCKDdQqDoECW75fJLad2zszWYd4cy9HnX8XlylSa?= =?us-ascii?Q?+bx8Hqm27NCgglkMO2n171F1Sk4Tqf89GgkVJZ6BRv6BjeRhKt+v2W6Wp8AL?= =?us-ascii?Q?umqrXeLLUi4GW5CashA6RV8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2631.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25341151-96a7-4fef-0b28-08d9a377017a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 11:49:37.0097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FU4soeK4Tt4rVNI3RZidsBj6iqdEU0V5cfxoVxlgR/rjOs0PAmujKhwNgaGN53thtR5gWN8lagQsh3VfhgBLjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2741 Subject: Re: [dpdk-stable] [PATCH v2] examples/multi_proces: fix Rx packets distribution X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hello Thomas, > 09/11/2021 10:58, Gregory Etelson: > > - uint8_t client =3D 0; > > + /* > > + * C99: All objects with static storage > duration > > + * shall be initialized (set to their initial > values) before > > + * program startup. > > + */ >=20 > Why adding this comment? >=20 > > + static uint8_t client; >=20 >=20 C99 optimization that was used here is not obvious. The patch relies on client=3D0 initialization. I added the comment to clarify why the client was not initialized.