From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB4EFA0C52 for ; Wed, 24 Nov 2021 09:48:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4DB040A4B; Wed, 24 Nov 2021 09:48:12 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2055.outbound.protection.outlook.com [40.107.101.55]) by mails.dpdk.org (Postfix) with ESMTP id 9276C40A4B for ; Wed, 24 Nov 2021 09:48:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KjiR6b5Lfz0MEPQhudKYrL9S7MyPZgtuuxJUVVrMf5OrzgO1MgCtpYwX6G8IzDPLveNN+5PF1mIrcUYKtZTHxPv0BGF5dIgcv4s2cur9/vErXlxsu+qK2VuGYmQh1qpbxjb0XQJ8wLJJNE6E4BSIFI+xOfi+l9SXtHWeW4oaNSqWbPpZfBiNpfJE9dyLloZfSrFOPCGEXdyMXDsq8usVmkXUIquxYNzhmlnCbe3Xo847xm0KV01KP4WkwaEZQL1hwpGSg7cvvsOfYyxeL0XzY+WPOy0kQ3001KuhfcBwyQNjzYYbvyLW4cBRsDAvr+e7Xtgx98XxG4uVr07I48V9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9HyA/gT6tUVAwKCfLBtDxTT6//cP+YgrnVeXMPMYM7I=; b=ERyog+nKM00JTA+NenTA8xI1caesyfu6uHcduZeDwXPrBlY9uD1kE5/VWfMWZpVKBhlyN1CPZ12ram1ZGMmA7lI6mXiIbDPcqUBAae3t/WhIcVL8A0b8jwu/kEFjIPER/VKGVRQTyMx8S6XInlNfAuYr96UlFokhJIr0lVIvA7tAEw8RQXF8w+4hR8WTvmjG6Te9WR8R/xlabHtbXG/oBgnB4W1flyFj7fiULUgOWAkupF51a31yOnGwgxcwJiV4q5IuAe5Do6AqGMiUlcDiA0xaO68zhobsdnZFJ9jxeYT7Qf3SuIx+Q7GWw2EGyPa4hCG84JKNat/CJ7LStPAmCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9HyA/gT6tUVAwKCfLBtDxTT6//cP+YgrnVeXMPMYM7I=; b=DZ8xn8RWR5gDhgxRdzpn2Q7pl5pSUzkII+6TZ6vURrE/XTnSLO0HL3mKwaG6rQ+o6VyVJupthX6LoybG9ZRtHCNimU7ce3ayQ9WiUG6tfxTSsDz9voQDYX+bg0jG3mNcqvH1pjnKZNP22MgFTjE2uvJ5V2BC0kuhDQFQtJ+cDGbCywbzXIiIzS/VY3rkrjl/F/0xiecde2Ra9HzZcDYF7k6pK1m1oznRx0gu2NhHE3Dl7urRJee+EG3Oj+ts0MMadfuhCZ0v4esgtXuFk8dVtpgcwtEeTQNWdILTByhq9bQrx+3fe3NeHl9msEY7aM5xRWhZTKtiOsYsxoMJ7yIZ9g== Received: from BYAPR12MB2631.namprd12.prod.outlook.com (2603:10b6:a03:6b::22) by BYAPR12MB3045.namprd12.prod.outlook.com (2603:10b6:a03:ac::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Wed, 24 Nov 2021 08:48:09 +0000 Received: from BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050]) by BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050%5]) with mapi id 15.20.4713.025; Wed, 24 Nov 2021 08:48:09 +0000 From: Gregory Etelson To: Alexander Kozyrev CC: "stable@dpdk.org" , Raslan Darawsheh , Slava Ovsiienko , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix GRE item matching Thread-Topic: [PATCH] net/mlx5: fix GRE item matching Thread-Index: AQHX4OxfiNZDtCmFZE2GhkzpBsWAEqwSVCxggAAJ19A= Date: Wed, 24 Nov 2021 08:48:09 +0000 Message-ID: References: <20211124043234.3287245-1-akozyrev@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f266b753-9f45-44cb-3835-08d9af27245c x-ms-traffictypediagnostic: BYAPR12MB3045: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IUtmvxGZM2dO4JVXn6b7/RHkdQKmZsjLBHSWI36p0hMpsWUCv2Nz7C1Y+3mXiGtMMnCrpxegYXZxcsioia0QnOTWNIb6IjC8F4DYW9R/NS4Ibcg5S4QkG3ejC6kelRE7qsnivl3WJ9GUraQriPmXzX63nPwcabFtP11nTVGhWaZe4Z6oCcj4rzhTnOpGex/gVgrhYmnuwmIhB6tc76f1VnExH74X7vO5E1EYk4zA/xqrztKixUHp1GH/hEjWqwjkG+tBIuGaSJdeIsHak12Z8dWJLbQarcwAnuqVX6LXf6hGwIrYSptUYGzaSh6s/HOeG2OsJ0uCd1vgihH/DEbP4KxamFoLcrXDBTUDIzWY3+BG4CnOBSHGqmZYdvvb49mIYOOuA4Jj93CfJ81GiBkrbi3m9Zvz8os545Us262mXdoepcc2EW0A+Qy7GS3vFvVmES4PwrYKY/t1WJ1X4HmW15MY2nltmNNpIbYxId7fdNs0t4iZ2c/xh0WdDu5Ih2aGJ3TgH0TopTY96QvUmMy5BAarRAXdUBToS4h0GIJsuxkNx9t1aJadVXJNdfIOcl0BGnEX+MGP/MkRCuQjTQEjYspaTQLMpxfZQCjeY04WvtXp3wA5Z7n6bMmAnHag4s6cKqR4mnniwY/8yqsOwJF6+n43ZKL1Kc7y3WdZ7ufM9iIHnIKcaMdvwnxLpTCEe1EReg6SqaHhj392J1gCa+wNaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2631.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(66476007)(66946007)(64756008)(66446008)(66556008)(76116006)(107886003)(2940100002)(52536014)(38100700002)(6862004)(5660300002)(86362001)(2906002)(55016003)(4326008)(9686003)(71200400001)(54906003)(38070700005)(7696005)(6636002)(8936002)(53546011)(316002)(508600001)(26005)(33656002)(6506007)(186003)(8676002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SqlhBTfyN4lRtTMLU/l7sgMgquLRLqXAmeZndqdDx75Bdsuvd3QGa7hjuQgx?= =?us-ascii?Q?3kroabNnUvH9kthkx9qIGq196a8C6YDfeGQon5/JO54jAT8KB18Tw5DSjzGn?= =?us-ascii?Q?LVHeo+9UDjnmIjo5eBzrqdmRP4xme9ZTGh6r7QCWHIs4LTfL/oHoSwVk93rg?= =?us-ascii?Q?J0gOEu4ocpH9ANe2+Nv26aXJcFGoXGevjOsHFDcCfQaDkrO53w/pwIB9bakF?= =?us-ascii?Q?HDmcFDIjaI4JqTMv3LoKfbgg8TvEhXZ/gsAFSy1D6N2Vcy0XuWuebTpW9huE?= =?us-ascii?Q?+z8xAGKElqEraYfAm3AykVtRk3569XUqTXrwuhupPyFT/sZP3ZaiJk8/djNM?= =?us-ascii?Q?LQU0hZUqrU5W9NOGp8aVULQLBnXJ6S+OHBcm5jk1WrWaK4INcBfPSOaXZEVE?= =?us-ascii?Q?X3n6MHAcyiVYwxUtTVzwMvbVD19bDwXpZFbkkgEa4Kjf7HgnYNgyzCaiw0m5?= =?us-ascii?Q?f/EYqcj85HgB2wDIwziUQxF6ZYZeZo+m4JCjebTCPmiz56/Bg75ANEV7Z9L4?= =?us-ascii?Q?Jgg1et2Jb+SFF/Kp5NBIFT9pCIThuf//8OPt73xUY73fCc/AwIkh3cW7uGw7?= =?us-ascii?Q?kwWZoxSa32U7lhk5lBc3TrHSfnB/Ntlx5hIYJxHg4Mt1MWNoQnsQvhm690IW?= =?us-ascii?Q?ddQyC889sysTjituYU0JMWW42z+TGjyYcmnFwXmFRZPkm6M6mLWgPUdktzmG?= =?us-ascii?Q?fsCkwQtxeYa7DTUu0V8ZHAgjbFrgDCZsk9rcPj7bDPjQUYnAyrqvDTltFZq3?= =?us-ascii?Q?rjJPeM0kMeXIXSaFmsac4adUJuk+au0rZQDwP44HUkOXGy3rPfasfHkCPL9i?= =?us-ascii?Q?4yigEYQZEzkAsrkPmpEd2sS8OBZzrqzYjdtE0RCpTZwyPbCzdga4hbufFX6G?= =?us-ascii?Q?XeanMexKIi6+ztnVliIoE7KLB4PUl+70l4OmRvq8Op7Vxkf0SKl14GXN94ZW?= =?us-ascii?Q?p36qYO/k1nK2aqXjjo1A5zUkvZD2YOlHOxOs0sTwYtKKxIqN57XPVNc4CGrY?= =?us-ascii?Q?ZNmqxz4yfgtg8PMG9i2jTKqMxT9vYCfaKPV5UPnuOfrEYqWuC/9PefXreeRH?= =?us-ascii?Q?7fVecei21Vy7DxwX64GMVQ0QOCl222qV9PT3Ex0IVYqHlsLhAqVPprqSwOl/?= =?us-ascii?Q?nGLmGr8k50857qttRZj9e1gRHT096yz5cpu4DrQa92kvL32evvSyXNlswT5F?= =?us-ascii?Q?yaZFyBBUOMnvkZrksbtOe6L7pgKZrb+mdpsXRfsEnK7dNfta8cjNZeinN67T?= =?us-ascii?Q?q3zIAxebKCf+B8kBDgBIWsr9+PLt6lZEjmy24eGf8ceYtotWRF9UzAk0Ljgi?= =?us-ascii?Q?+O6z1eEQLOMnM012QgBQyaN4SG6XmOiT4cxN+sifYJ0n57yxdXZvNwejcAb5?= =?us-ascii?Q?Xj87NlYmx+7O1kuemUEoNEYCem19MURZpo6oYyeSvMqlJTDRi2/wQ7tdLxFn?= =?us-ascii?Q?VsAkZDAZAa0kawK1J59NiQHXBj8xQpXEHt2ZtWc08YV9vDjAL0XlptE9eKqV?= =?us-ascii?Q?FYssO6/k/7UpzpzvAyrVfU5i6B1JQiIIMBPpyYjoI0vQAjtqYY20CO8PhIIm?= =?us-ascii?Q?6Geu1vt/9p+yMXm92bE4ZVAMo7OhUjHIMFDLPoXLqHiAR8Y7SR65JHoLY2tF?= =?us-ascii?Q?d38fTXa7NkrKeWGlbQqUYsE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2631.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f266b753-9f45-44cb-3835-08d9af27245c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 08:48:09.6445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OcRMrwAIv6t8bi3qCfOc+TbIiz+g9NpXA8SazFWbazhQKEeX3vJkR+7Iv5eZyUQtmP5KJTp6rUYsrpgsEIuuvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3045 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Alex, Your patch is correct. Please ignore my previous email. Regards, Gregory > -----Original Message----- > From: Gregory Etelson > Sent: Wednesday, November 24, 2021 10:16 > To: Alexander Kozyrev > Cc: stable@dpdk.org; Raslan Darawsheh > ; Slava Ovsiienko > ; Matan Azrad > > Subject: RE: [PATCH] net/mlx5: fix GRE item > matching >=20 > Hello Alexander, >=20 > > GRE protocol type is implicitly set in the > > matching translation in case > > an application doesn't specify any type > explicitly > > in a flow rule. > > It is extracted from the inner header type, but > > this type may be absent. > > In this case, GRE item matching is broken. > Check > > if we have the inner > > header type before setting it to allow matching > > on all GRE packets. > > > > Fixes: be26e81bfc1c ("net/mlx5: fix GRE > protocol > > type translation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alexander Kozyrev > > > > --- > > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c > > index 9d4bd0560c..7bb092ea9f 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -8823,8 +8823,9 @@ > > flow_dv_translate_item_gre(void *matcher, > void > > *key, > > protocol_v =3D rte_be_to_cpu_16(gre_v- > > >protocol); > > if (!protocol_m) { > > /* Force next protocol to prevent > > matchers duplication */ > > - protocol_m =3D 0xFFFF; > > protocol_v =3D > > mlx5_translate_tunnel_etypes(pattern_flags); > > + if (protocol_v) > > + protocol_m =3D 0xFFFF; > > } > > MLX5_SET(fte_match_set_misc, misc_m, > > gre_protocol, protocol_m); > > MLX5_SET(fte_match_set_misc, misc_v, > > gre_protocol, > > -- > > 2.18.2 >=20 > The main idea of the be26e81bfc1c ("net/mlx5: > fix GRE protocol type translation") patch > was to *always* force GRE protocol mask. > Otherwise we get back to the original issue that > patch has solved. >=20 > Regards, > Gregory