From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08A91A0C52 for ; Wed, 24 Nov 2021 09:16:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF03240A4B; Wed, 24 Nov 2021 09:16:09 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2047.outbound.protection.outlook.com [40.107.96.47]) by mails.dpdk.org (Postfix) with ESMTP id BBA9B40A4B for ; Wed, 24 Nov 2021 09:16:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHYO198WAgPtU/S23Ix677jLOZSJIhN78smyJ4T61WAFmMA+OrZ7Vcb5Ao9EdlOPlwRUKE1mGoA8crRWd8OfJIq3fGqEMIHt+dP+/vlOZXYfg5LYRyxC3Xy/YVKpej5LFAeC7pgOwLOQgBzv/NZadZkcCLrkbMSiczHH7Kqr3tsWB1X3ZzCYwJVi0JFh5xNOSBueApUiig0rfmDCWduxCTO5mVCjYTQhoX4pU6kdoUj+bpQ10OCjTFV7vG8sz7M2XaDTrAuKC3nEyjDFl5aeyFvzjg0v8PKjdLa2v0OcQzPodJtcVOk8OzWPdbSnb4QknDtKmMmjklOAt/Bb5SEFRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9y/US0qBN6Tg2KSy4Bmyd5EkI3VjHmvtsorTTQMKAI=; b=duJfCHxnPbM7oNDYN5qae55E57YU6zecHmymE81ogGHRfJ6jqauHMk9cJLaN0ORPzdUDrZOdQ48vf88E3wEAzYsoj0dRB3EmGpt/O1ycUi489ho1Jv6Ja3t3c1GeQeOi3c8ona+sA0ij09tSExHeUgXxgA9UadXehMGTVpTm/9NZX2UMN8cb//Lpol9VuIZe712T88zhrnm9ObHbuVX/UAkK1QaoLZ8sU7l0JNmrV6dqGb+GoUydlZgGPwkk96v0okj++PSU+b747GLXRrPpaTPJR+jOlWkxky+WoMCuQN3pPRfZsC9kp7c37YYY1UEekauoqUPz7soZTBVZ97SyTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9y/US0qBN6Tg2KSy4Bmyd5EkI3VjHmvtsorTTQMKAI=; b=UGwIWydm+9ELLUYJmAOOQtZuot2+2WGPOO/banY0eHe7JnCUEdO+vWAIdHx81Urg8THBKlHeGH6lyrRU/pKAcibRXFOqxvg5fEXPCOR0PLdr5TLX0IxM1iHYMQMj6M4iAZorZCai2e1dvmWuCTvL/adqPC4Jrovby1UJc+tA6DkId10CCMzTMLPJrtDf1PHSQlRxXLf/F84ActLdP0/qESStDY0P5NEweXhCmV0JFP3sTmW3AYqBZ3J06lRXJASkeVJ3aHlmEAoOMLKgjwwwYE2dRAPHEb3HtSdJYEBrcEklyEnxeqZavuaKKB3IHYOIYjALqogdroTnOlTMRVZ2LQ== Received: from BYAPR12MB2631.namprd12.prod.outlook.com (2603:10b6:a03:6b::22) by BYAPR12MB4728.namprd12.prod.outlook.com (2603:10b6:a03:a3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Wed, 24 Nov 2021 08:16:07 +0000 Received: from BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050]) by BYAPR12MB2631.namprd12.prod.outlook.com ([fe80::8508:89a5:d1f7:9050%5]) with mapi id 15.20.4713.025; Wed, 24 Nov 2021 08:16:07 +0000 From: Gregory Etelson To: Alexander Kozyrev CC: "stable@dpdk.org" , Raslan Darawsheh , Slava Ovsiienko , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix GRE item matching Thread-Topic: [PATCH] net/mlx5: fix GRE item matching Thread-Index: AQHX4OxfiNZDtCmFZE2GhkzpBsWAEqwSVCxg Date: Wed, 24 Nov 2021 08:16:06 +0000 Message-ID: References: <20211124043234.3287245-1-akozyrev@nvidia.com> In-Reply-To: <20211124043234.3287245-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec6deb58-ed12-4d31-8e41-08d9af22aa49 x-ms-traffictypediagnostic: BYAPR12MB4728: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cgPKZQPlr8m1+3yedcyBQNOd1Cd1ASArkX2eWAfBzGGK7aGGFH50inBxprQFkZ1YiRMPaRNgNLvLuhvh7uitMlr9N4UWFqFFT57k8h2kziCH8lxv1ylc7VOkbOMZ7r5QTFmp3O3iHvs1fEG/+irPHrIjE0FF8Y/mp+yFSx0DoTWJTh3CrnptLONaKtHtvuD+9FAPaDC+b+7xSc0Y3gKkPRwmbgoXTObPwngY+Q0JGmsBjwa++zW1R4P3UhGCrlxXcKHhEh3emm5Cu4nYolG878iqzW0RdEb9F1aw66gf9rjqiBYS3bK5l0AjohI6qqnV2kyH4Nf/LDlr6+yyQzWQzzRDzJaef6Krs4mgHTrBQm9BwRE+rlTeYnFPWd9hYCdEM6MNrkVreWbFiqE6l+njQ7fxST3N5pR4OWYg8hcXlkJnObPq7sdz892nldE+8O0gERyetSqJIEEJkuaEUHAu0B3OVR1hYi3XtKQcpUor6sOh1ZZjp9UuHhIZaJgspbXkcvh0uz/acuU5m4wYfoVZovv9/9cehmFEYOFVWcIIimkoCkKUHC+xoz3M38K5m76P2j65K7ghJdpkaaZvxK4sfJuKfMZtusgsd112a72vuDOhGFfwAGZ+3UdB+GsPtlwx9hJ3YEgtsegK0dOac7/eBEXIAaO9pi5XmL39G1XFdvPHpnuLbd275CogXPScziFz2oyz51tso0N3K4GuaGthuw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2631.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(83380400001)(2906002)(6636002)(71200400001)(7696005)(8936002)(6862004)(122000001)(55016003)(5660300002)(8676002)(508600001)(66476007)(38070700005)(26005)(316002)(38100700002)(9686003)(66946007)(86362001)(33656002)(76116006)(52536014)(4326008)(107886003)(186003)(66446008)(64756008)(54906003)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q2aViAH8RKxvvrALGVEesgWAzz1kSzzhTPSUXg6fI3tNEtcrN/AaKK1PEFZ3?= =?us-ascii?Q?d8ESXT9hGP/dMBuJlS/y6UTX9IZWkNbtzMDGrDrAdQWlg7Uqi1WRTlhbCQF2?= =?us-ascii?Q?KbfWXw9FP0grShYCPSe0nIA6DXpDQPM5yPW9vQ+9LcPohyQyLI5eLWHsITvY?= =?us-ascii?Q?IoAZJvDMU/NVTTqn2S2OPpxDOOAxRGr9aZt9zlCDhLfN2nEPQ5eNHDRgoejQ?= =?us-ascii?Q?WBcPn00vSww9KpZHbe5cjIvekvm3JsPFPvlIowqLaoAejF4khQFqhsyHnc/o?= =?us-ascii?Q?wpXp80Y98sNCOcXtxW5urJuoE5T+nTKeSyCXL0eVJkyLGhzQRvIlS9BqD48J?= =?us-ascii?Q?/QbkOEI5LXmIUcb1c25kHkPP9mcowjlk0A1iEYmMNx2wbuDubJGx65Y2UylB?= =?us-ascii?Q?B4nIYiCxk913WJ1xEXOuB9JFwUzF15Hl+7W83fFJQr59ciSnoPp2djoi0P45?= =?us-ascii?Q?9gSGXjDZhyoOe72jQqkmskT6hylp3VYoqmVZj88/DonW+LbIQ7dbeG07+ok2?= =?us-ascii?Q?P0Z4PDg2D9GODwuRKcptATeWaP2mII1o3h3Qd8vFaX4czYWI/2nQLiyrm0KE?= =?us-ascii?Q?8/ivii+97a5vuvoRFzcGaS58Cfs0bPSSyzTpGH/NMaR4utBg0wGmq9kfO8UJ?= =?us-ascii?Q?Y68Fy8i40BX3XVr0LX3cZRIjCCh8pfwQ16kO018Kq3NcH70lX8Uw38tua6+m?= =?us-ascii?Q?Q80c30DYTZm+2t4zybNII+Twf1/6dgCiuEcO7Tu/uoamuXbVeJ6Wuqvi8R8V?= =?us-ascii?Q?vLD7TvlNvnkaH22YPqQ7LLxFG0D7aD/DqNctEq7fRbQaasQH/1edttk3uoNm?= =?us-ascii?Q?6IUkrASHE4A3gOcfLCm+KdAJv3c5gOzmKKhdDbQ0pMgKTlG8haNYFavSbmXo?= =?us-ascii?Q?iUwwTCI2lq9G5exNKXKOoepRUOwx8mbcZsheoS1zD3hWxZ+iS8H1OSd6Biew?= =?us-ascii?Q?+6FiUkY8peXVlaaLxnMpHvAb5rHo5q4CAnWrL2HOQXuAM2q6IgYFKEGxRHWk?= =?us-ascii?Q?KAUDsxUsgFhDb0jO+55lgkkXQunm6Kqip+ktUiRVztNsl2TcZn9aAJfeoA3s?= =?us-ascii?Q?EkUeBGyDTzNk2XTWu/mCoLAOutOpPWJQ1LIbobxbBJx3Jz/4tix88buhLDAX?= =?us-ascii?Q?E6U0CUS6qlvqUIAhhKolASEQRGEBxM/7jlZ7TbwNqb+MpTdK0c1el2TTL2MS?= =?us-ascii?Q?p3Zdy2CZ2jsBQW8bYrbQ54tEzUp96qx2sGVvW+ctv08+zfoRuMLQ1oqlNDNJ?= =?us-ascii?Q?z2ipg5UUDiL7qWLHwuqVxIDGO7XFC5jE/QVCnypiUWxiVWEIRM4v9AnDW58J?= =?us-ascii?Q?9q8PO7hAmxorTtrDt+kSSRjtzNkb2tJW5ufhUOscMfqJQDcarqEY2AObQYGu?= =?us-ascii?Q?Ap9OGefsPRJmyjajI/9aD+rcEbdDKBfaf3sFtCMQU6AhzTqRKOilze4zr6ws?= =?us-ascii?Q?OjVXh7FSRnTgqr+JaIF++l34Teq1y8jar5G2NadOhicZcXaJPzTzDg7WIiyh?= =?us-ascii?Q?F7NPMiwA+i7yQ2/CPfnyBKJepKGrOPXBff/bDimPjgftY7B2GRzWPkIGqEJx?= =?us-ascii?Q?o8UBLDMgUtHFFkmCCAN5ugRjn0BNJc0lLwI/XSeXFkF6Em4HSfusGlhXD4NI?= =?us-ascii?Q?i8s4VqaeDrkr54IpdEXtGJk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2631.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec6deb58-ed12-4d31-8e41-08d9af22aa49 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 08:16:06.8802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EpNLeHCzPLFdq5fNf3FAOpRDyOIKfV2NZ8nmAx8jlXTv82PdN74eynCqGbfLkVwrK8JlXgiZRKpj4MCavyCmTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4728 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Alexander, > GRE protocol type is implicitly set in the > matching translation in case > an application doesn't specify any type explicitly > in a flow rule. > It is extracted from the inner header type, but > this type may be absent. > In this case, GRE item matching is broken. Check > if we have the inner > header type before setting it to allow matching > on all GRE packets. >=20 > Fixes: be26e81bfc1c ("net/mlx5: fix GRE protocol > type translation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev > > --- > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 9d4bd0560c..7bb092ea9f 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -8823,8 +8823,9 @@ > flow_dv_translate_item_gre(void *matcher, void > *key, > protocol_v =3D rte_be_to_cpu_16(gre_v- > >protocol); > if (!protocol_m) { > /* Force next protocol to prevent > matchers duplication */ > - protocol_m =3D 0xFFFF; > protocol_v =3D > mlx5_translate_tunnel_etypes(pattern_flags); > + if (protocol_v) > + protocol_m =3D 0xFFFF; > } > MLX5_SET(fte_match_set_misc, misc_m, > gre_protocol, protocol_m); > MLX5_SET(fte_match_set_misc, misc_v, > gre_protocol, > -- > 2.18.2 The main idea of the be26e81bfc1c ("net/mlx5: fix GRE protocol type transl= ation") patch was to *always* force GRE protocol mask. Otherwise we get back to the origi= nal issue that patch has solved. Regards, Gregory=20