* [PATCH] net/mlx5: fix irrelevant send skew devarg warning
@ 2023-01-03 11:11 Viacheslav Ovsiienko
2023-01-08 12:59 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2023-01-03 11:11 UTC (permalink / raw)
To: dev; +Cc: matan, rasland, orika, stable
Since ConnectX-7 hardware supports the send scheduling
on explicitly specified timestamp, if this feature support
is detected by PMD the tx_skew devarg becomes applicable
and appropriate warning should not be emitted.
Fixes: 49e8797619e40 ("net/mlx5: support wait on time in Tx")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index e55be8720e..3ae35587b6 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1401,7 +1401,8 @@ mlx5_shared_dev_ctx_args_config(struct mlx5_dev_ctx_shared *sh,
rte_errno = ENODEV;
return -rte_errno;
}
- if (!config->tx_pp && config->tx_skew) {
+ if (!config->tx_pp && config->tx_skew &&
+ !sh->cdev->config.hca_attr.wait_on_time) {
DRV_LOG(WARNING,
"\"tx_skew\" doesn't affect without \"tx_pp\".");
}
--
2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] net/mlx5: fix irrelevant send skew devarg warning
2023-01-03 11:11 [PATCH] net/mlx5: fix irrelevant send skew devarg warning Viacheslav Ovsiienko
@ 2023-01-08 12:59 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2023-01-08 12:59 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Matan Azrad, Ori Kam, stable
Hi,
> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Tuesday, January 3, 2023 1:11 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix irrelevant send skew devarg warning
>
> Since ConnectX-7 hardware supports the send scheduling
> on explicitly specified timestamp, if this feature support
> is detected by PMD the tx_skew devarg becomes applicable
> and appropriate warning should not be emitted.
>
> Fixes: 49e8797619e40 ("net/mlx5: support wait on time in Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-08 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03 11:11 [PATCH] net/mlx5: fix irrelevant send skew devarg warning Viacheslav Ovsiienko
2023-01-08 12:59 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).