[PATCH v2] net/mlx5: fix shared RSS destroy failure

[PATCH v2] net/mlx5: fix shared RSS destroy failure

[Rongwei Liu]

When both shared and non-shared RSS actions are present in single
flow rule shared RSS index is unset by mistake.

For example:
1. flow indirect_action 0 create action_id 3 ingress action RSS ...
2. set sample_actions 0 mark id 43690 / queue index 0 / end
3. flow create 0 ingress group 107 pattern eth / sample ratio 2
   index 0  / indirect 3 / end

PMD translates the indirect action to a shared RSS description at first.
In the split prefix flow, RSS->shared_RSS is unset when translating sample
queue action, the subfix flow will treat the RSS as non-shared.

Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions combination")
Cc: stable@dpdk.org
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 0b9df5f6f1..daaa104da9 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -11206,6 +11206,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev,
 		     uint32_t *hrxq_idx)
 {
 	struct mlx5_flow_handle *dh = dev_flow->handle;
+	uint32_t shared_rss = rss_desc->shared_rss;
 	struct mlx5_hrxq *hrxq;
 
 	MLX5_ASSERT(rss_desc->queue_num);
@@ -11217,6 +11218,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev,
 		rss_desc->queue_num = 1;
 	hrxq = mlx5_hrxq_get(dev, rss_desc);
 	*hrxq_idx = hrxq ? hrxq->idx : 0;
+	rss_desc->shared_rss = shared_rss;
 	return hrxq;
 }
 
-- 
2.27.0

RE: [PATCH v2] net/mlx5: fix shared RSS destroy failure

[Raslan Darawsheh]

Hi,


> -----Original Message-----
> From: Rongwei Liu <rongweil@nvidia.com>
> Sent: Wednesday, March 2, 2022 1:20 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Suanming Mou
> <suanmingm@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix shared RSS destroy failure
> 
> When both shared and non-shared RSS actions are present in single
> flow rule shared RSS index is unset by mistake.
> 
> For example:
> 1. flow indirect_action 0 create action_id 3 ingress action RSS ...
> 2. set sample_actions 0 mark id 43690 / queue index 0 / end
> 3. flow create 0 ingress group 107 pattern eth / sample ratio 2
>    index 0  / indirect 3 / end
> 
> PMD translates the indirect action to a shared RSS description at first.
> In the split prefix flow, RSS->shared_RSS is unset when translating sample
> queue action, the subfix flow will treat the RSS as non-shared.
> 
> Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions
> combination")
> Cc: stable@dpdk.org
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh