From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93227A00BE for ; Mon, 7 Mar 2022 11:26:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81A0E4116E; Mon, 7 Mar 2022 11:26:38 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2068.outbound.protection.outlook.com [40.107.95.68]) by mails.dpdk.org (Postfix) with ESMTP id 1ED994014E; Mon, 7 Mar 2022 11:26:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZ8xeod5+SX28PNu97nRxdr8DvX5D1uATcTCogDif6MPN4T1Dv4i5rzi6pf5fvBfQ0sn+jyAdQRoEI363vpV3gwSX2ohJ0RP5OJaW5sX5bKJfMa1AWoMVEO3X3UlLqmsgi6S1BbmKgMO5f/5fxeYq8j5cmpUfxPSkh+i7IJQesrD91YpCDf7ytz9oPVbIvM/jCVcO5PyEWqbyNu3a5ctrMg+quF525uurDbe87sDGIkZmYsaMNkmwZriYKkBkEeXXS+QdLNt/rJhF09Wvc4GCvvdrGaKbf4ymnd+pq+/ivWZmx7DpLT5B8DDsG+nFp1j5NgW37SsD3pWov82SK76DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3FptOFckN9scF80JrO8JkBZoja0fPqdxEGVqchTLN8g=; b=kx/5C/le8LFJNBlnw01htjPxm/9+Ajbe/XBW2AmUHcAC6MsEVF9EQ2T+8JVS5QKAC+5DcfNBOd5MueqwMdO3L/IuL0or9DzD+I+yZz0mw2nShshMz2EmGTSFT5JKmD+8aPWijXGGWFE1oTLLb/nRNglpmn85+sSZ0rhKZvJ6/c1jyRxOQIAVBfiM80to7vTnY2r00FE95H1pnGHXxY33xENJOyRQ3wGep+D00kd9wZN0xHFr+5xKOf7Lvu1MTY23LAj6H/RkxCGv59m4AZ+yjkyLwr1o5KCHFrbyvIAMn/LH0fb1NX1uCWpnVjz9Efa8zrRyxuEcfBHmdi0YOmYbpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FptOFckN9scF80JrO8JkBZoja0fPqdxEGVqchTLN8g=; b=ccDK+wJSSnw2gRCsR7Jtgh+Vbjabby/SyR9K5jC0W6oTP8LCpTMM8xC2hYQAza51GIh0/gcl1nJcH9IfQfLVvcPQ0ZFjNGM47a7cLAuBLRGbLiikSPF6cKeCJ5+GD3TDNO3PlCIoCaq4zOTGGSeXDo1QtE+TKN+xe3DelqqZBxHQeu6tnoZvdrg3FlbaWHiiB0XhXOMb9Ty/3NZRxLWfINML018C87vtL4zbLxN5evF+bUuHBV4ng313DNlq01xLQARygZxKy3xZMj/4EaeyqhjTApHlhG6oV7eEFA2FNg2R1mCyLarMVVb9Dk3z9tJ6Khi5DddziEEY77QPgqj2QA== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by MN2PR12MB3070.namprd12.prod.outlook.com (2603:10b6:208:c1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.17; Mon, 7 Mar 2022 10:26:33 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 10:26:33 +0000 From: Raslan Darawsheh To: Rongwei Liu , Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Suanming Mou CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/mlx5: fix shared RSS destroy failure Thread-Topic: [PATCH v2] net/mlx5: fix shared RSS destroy failure Thread-Index: AQHYLieOFZ2vyFdiVUutMDajnhByNqyzvwNQ Date: Mon, 7 Mar 2022 10:26:33 +0000 Message-ID: References: <20220302111938.839522-1-rongweil@nvidia.com> In-Reply-To: <20220302111938.839522-1-rongweil@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 988b8516-ba53-4048-29f2-08da0024f3e0 x-ms-traffictypediagnostic: MN2PR12MB3070:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 034t6U/6u9JX8K7jS+lAO746L0zriIxi1bqnr1vYWVLwerSgf87svXxazZes0VdP8omxboEA+sobJDp8BmA+jh7FJnwQ2x59SdH8eJ2lE4caz47uXDA23sSQQeOng3UClnqiptmutdJ3dBPEU7FJMZnHjRLygS9Bp/M+qYDaSAN70FjzEdx15YY52WQDudlML8Powb19taJDcou2mcP1/pkg1nWdCSaSFyPlb6AZ1nEJMhCeAzm7NJbszVrVfbDnpim2BK0+M6nzlyvP0nX32sLbGW+g2ysi2UTOw2IHyuZNfQRmdyte7BYSyknZQ+/OJo/WYOuKhvIfaQ7a9ioqWbYdUdWkRHxsung8x5/GWfI7Z963Ub0Crc2YM8YGkMdVoP/iueTiOUydLjTTYUolODRdFXRSc33AkM5BsBTom0Ie66MKTBT7ZD9FT/nl/01xzY1ue5+o2SZgFF7b8fyev7RRuQcqPvPpS4FMU7x2Wr/H+6zcNMlde41TgaoEm+NqZal1DvjfFO7/XViiFqBRFBBy/hABAbaFJKq0rLRI+eOBwuyYecdeysqp89qs2/k9Vlu8oziy13Ybi527Pq4VpSwPWbs3LpwV9lLxInrl7CIzk2x81E+Xqii1ZUU75qIUtnNlg22XGYoUcwgPe5rX736bpbF0RqAGVL+b7nAey+NqLowcHy1owG71mYM9FNwJiUt83GYA6u46QM/oQRbhSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(38070700005)(71200400001)(55016003)(2906002)(66946007)(5660300002)(122000001)(8676002)(508600001)(64756008)(66476007)(76116006)(66446008)(66556008)(4326008)(8936002)(6506007)(7696005)(6636002)(9686003)(53546011)(83380400001)(33656002)(54906003)(186003)(110136005)(26005)(52536014)(316002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p6Xcv6IGW+zQaMbV5JYPE2E20jgkc9+/odeAEbweV8x1l55ftibfRv0NggzW?= =?us-ascii?Q?rsf+ViuaWE6W5NNYDAugyHCUtwVl+IaiBDSdJHE8ca8J3GkOUSCTBblpQ/to?= =?us-ascii?Q?7N7y17k00wIOfZhcKNgigbLqwsvFS+uz7SxRpWLyafuhAlTNkAzKoVPnWSGx?= =?us-ascii?Q?vP379aWjhJVl7BmSV92ApAYGgjvl80jdMbCBbqWh0/K1T+n0OPAJJLyJIUYI?= =?us-ascii?Q?sIkZ06I044P4spBoxx/tcFL5mTCtJEMegTFIFr99/ruDAqmN8JVWgVctk7t0?= =?us-ascii?Q?Ms6UDTyDvvH3OEHX4ISa65yijRNscKcZHIBcXMys2cHOht++wNgwjgXwzUjl?= =?us-ascii?Q?we8pTlUzS6NggVKyqLLGuhZpzXLV0eeA23tGMh6UKb0G8GYG7Wzd9g8Re8QH?= =?us-ascii?Q?7gtZYJ3jXTmBZRPND/bTH+eFBe517MwWBctAVxYj+oYXrVuZa3GcBbYDKtoI?= =?us-ascii?Q?amLv6da+ZDts53OjGnn8hufNNx0ytlARobNCi6VH+zoEh+HeUGJRjX4w1s8y?= =?us-ascii?Q?JTl1UQH9TA3S70KxyTlTrTCmSQ+ShVkPjzw9hxVHjufYSThRR7iOIxx+3HgN?= =?us-ascii?Q?GIacESbirdwBwMrNq/KrRcNyKlFDQAO/DDqHXIoWvjPZ6TSGLp0iyYfAv9mj?= =?us-ascii?Q?TYUzvW3J9HHZuqOEULgbS3C1cmuTCgAy9wRTM8eS94lrDcJutKfg+padF5GH?= =?us-ascii?Q?BZfWYUc/9wKoqxbgBAuA6npP4eUI7oUKeDYnOkN0TEhMCFJqX6DJzfJfioL+?= =?us-ascii?Q?9o/OpzQcyorFO4dT21Ugysrndf3k+2Ci+Ijxl7V1qyV+4LnpCsoS4Yw+EHX3?= =?us-ascii?Q?4DG/apPT5zldL4qXXlkWsq7HmyTQbdqWpAvpiSM8K0dyvvlQs3KzU/zch1KT?= =?us-ascii?Q?BFAKQECQf78N+2j6Iis3enZHlFRPu/+nT7vnCLYpVtgrTXPVmThHiEeBPCMp?= =?us-ascii?Q?Sy2bZfvuD32Rc0yMf5gVOWKfWMwcT2KxXpDVAGYE6FERtmfSgq9yjLANGIRi?= =?us-ascii?Q?am/XS9SPbjleDld3y5AC+7g4l+xMTY+XOA/ai3jSNpPfXK9L94DPiGzkN2vf?= =?us-ascii?Q?aB+iL7Apj0EbWwJ3d4E/bYOM8XjX5fwU/A+O4WmV+rE9wGnXzPEgMmZu+BiE?= =?us-ascii?Q?6iW7sJPv5n4gvwKCYBhuedEe45YMSD8Tv0FfK0R7V9e1S6jkXOMiW1wAFzLd?= =?us-ascii?Q?UoZSt2SjO1D7EjFe3NKMwJJN016IC6uU8r8T/KbjlG8ekWoG+aOsuTxAj2vB?= =?us-ascii?Q?W1i2R673zWPLaihDZ4iUk2+wmfeRcwXY+MTHQMY0dnAxFmfgmIzTEfK322KF?= =?us-ascii?Q?GaLUFxY+d0/K5y4LzYcvDmRFUm1u4eJ4NIyEDNa+bt6Y2RmuXHv/KOCvi+C6?= =?us-ascii?Q?BlhpJguO9ovWGeRTYrJBIrR+wi87mehsZZ5392KfuZLMHU3wQHKjZMA50Fy/?= =?us-ascii?Q?qDPb42R2/2A34biYeAmqlmezYERLdSZzifX07ucaKlBCUbRlm8uPsVI4ueUQ?= =?us-ascii?Q?no65dWce83FVcurUpMRr33GcSYnNSj/8GrKSZPhUqDkg/UgUasQRqzwBoD/3?= =?us-ascii?Q?V0VxEQ19G5/SAnuL1WR1AZGb8NQVWCxNcJUHmFZDeXvTELlyrqPBb4MCUVQT?= =?us-ascii?Q?YSjIfVerrUenyF9TpuXQJ1s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 988b8516-ba53-4048-29f2-08da0024f3e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2022 10:26:33.5161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 77SRX9XcdeK8F1DWj8oxbt13LRncOavcZSe7+PME5CPkRbaqtIT7AvB7cSOYjGYlIxiitj//KpBiFaI/BCA4pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3070 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Rongwei Liu > Sent: Wednesday, March 2, 2022 1:20 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Suanming Mou > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix shared RSS destroy failure >=20 > When both shared and non-shared RSS actions are present in single > flow rule shared RSS index is unset by mistake. >=20 > For example: > 1. flow indirect_action 0 create action_id 3 ingress action RSS ... > 2. set sample_actions 0 mark id 43690 / queue index 0 / end > 3. flow create 0 ingress group 107 pattern eth / sample ratio 2 > index 0 / indirect 3 / end >=20 > PMD translates the indirect action to a shared RSS description at first. > In the split prefix flow, RSS->shared_RSS is unset when translating sampl= e > queue action, the subfix flow will treat the RSS as non-shared. >=20 > Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions > combination") > Cc: stable@dpdk.org > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh