From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF627A0506 for ; Tue, 12 Apr 2022 10:09:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5C82410E1; Tue, 12 Apr 2022 10:09:15 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2067.outbound.protection.outlook.com [40.107.212.67]) by mails.dpdk.org (Postfix) with ESMTP id C336E410E1; Tue, 12 Apr 2022 10:09:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9u8ZS/V32NcraEIVHDINtEIG897RI8qcQG7fX5CfYuTwDSxcEelPuialMLKoR4225qmQhm43r6FbIXHlNZf8ABDatfbNjRRJ+VJt7poo1tSCT413O+fqGsLRo7AXky3K27KHAJfztr1TFXsKM/uPTnZp70iyyXxawd0BV+CorOaS25+ZtL6Ulk3kJOSBRZn2Xmv33FIMJWn4WF1W7N5uMXIUvqaFKnb2a684OI171TN3Hahme0HHuRNG/TkU7gnP2DNtFbCoybWbv9S4IaOi8EXWavFttHn9WWmpPryO1lOlAPx0TUKrQt7Msfc4BFZy7DbqwzbTjvJroHUMEk8Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x2JGgE69oBvL+5D1CjiR0tNyQ2ifPSi2MIQkypK/6eU=; b=E6SYxt/KVQ5NNpkbRAFvUR/ZICTLCL3w6ESpf8RP1nYcGPqMQjnIXla2cSok3o1YYY3/rtNMycwqowXhOVu3F4yjlDWBLZLMjNix6Rm1r4JMOQhop0nwm4dNut+j2gmM2I1IZh1laAZORI1fqjo9Llkhp+5B5JowpypaCpPPyKFkuR3KO+IJVbJNNIMJxEei//cTb4HRXrQNLPB8Yvj93JnZZYXdrHHcWAPlc2YQje0FkDHmhbl/w1UJiWoB7qooL2fPA8QVyV2usr2yO8hqji3nKNVAuaIhFnzuVNcF7871mYCBajosCLrliiddkgvcKNOas5t4jzxPOSzuKgaazQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x2JGgE69oBvL+5D1CjiR0tNyQ2ifPSi2MIQkypK/6eU=; b=eNG1q5AsDOWXeqNpG3CDY86Io2RR8VjZmUndwSyXsw9GKdGNFMObKKiqVGB6ELlbzXaeAA7uKsGLw+sMHSbff/2VglZI9Ojor6hFSdTQH1gKWoKg3eHCdKDxnCflbLcsd0KOD35qPnoX0XPluRV7xnsAonNKu9uxn+tN5lNagcqjQfF3+24vklULM3uzSeT3WWZLt4Zh/IGL75V18TDtmNdoHDL+i20k8Hqw5ozjTSq9HQy0naBd/QU28Qq7mEmUU2nTDTMI6F68OdiLi5uq32vMXUovd2cuoYFWcC5KGcqUHltJnfG+gqFbZaHKXBb5MBcDU/QRIu1PeP7Go1MeXQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by CY4PR1201MB0248.namprd12.prod.outlook.com (2603:10b6:910:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Tue, 12 Apr 2022 08:09:12 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::19f:27df:64c5:3d7c]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::19f:27df:64c5:3d7c%5]) with mapi id 15.20.5144.030; Tue, 12 Apr 2022 08:09:12 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: "stable@dpdk.org" , Slava Ovsiienko , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix TxQ failure when inlining is impossible Thread-Topic: [PATCH] net/mlx5: fix TxQ failure when inlining is impossible Thread-Index: AQHYRQ0Y5k/7prfGCkqi/i1p+nA9zKzr/wAQ Date: Tue, 12 Apr 2022 08:09:12 +0000 Message-ID: References: <20220331143841.3345059-1-dkozlyuk@nvidia.com> In-Reply-To: <20220331143841.3345059-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80210252-5872-42f7-022f-08da1c5bbada x-ms-traffictypediagnostic: CY4PR1201MB0248:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CunFwbW5CvQZspjL6ow6DEGtUGvXuPEz4JKJzPpEZj9eUnbmNMxGM3YXRC2m9xIaEnGSa+4pwD/oq2PK+j23gx9WJLTBqmfw2LfMXYfEjo6VdOgPiq6XBrthcjbxPk38Jze8f2kg5JoTsncZiUOioBo0QNvMcUJzWYexllMx5BMwad6z3l3kvmRQzzofiiuIvvINeIXni5AYUsTZSKGMR/aJbJk4ffBFhd4OLrukD7knBJ9Lz9S0Caszdr7yegfuzLBaxHbwPLBr10X6CSxg3hjZ7E2J6bouHkZCO2GKnU4NVOfkOBKY5reorJviPMrv/LXTLPm/+WKGeZlq6hVeEAn7FMwiM3p8vqvRj7Ao0tmSNJIqaQlCC83wFHbA4HMTZnrDnQbQhZt1KOG8cYutIwg0ukh0i5q/6bErrvduLowLxkBWh48D6hpJTWjwdx4GXiktI4j0RkJhavQPLjSzIquSRZT7Y3241RZSZLmJIB/Y+DmDLLFEFcY+9se5Y950NcTTqMPiFQIRKMUQdm4cA6Zcr0/f66WBmGC9pyPrcqUQRqC+sB+jW7NZ1TBzYYUf7ooMceYEhwU0Q3yyrJf5mdsyX9g0X2QNasuGDthfNdtyrTKpude58qUJA2ifXwSnn9k31rH7OVEj7EHV+Nde7z3sQI9R27pKm6sD+FJ6GbB8tlN8hvEgIJWQTAKGQmP89vHmxTmD1vBvtNEEKo4gjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(52536014)(54906003)(110136005)(33656002)(2906002)(122000001)(9686003)(5660300002)(316002)(38070700005)(53546011)(66476007)(26005)(7696005)(6506007)(86362001)(38100700002)(107886003)(186003)(71200400001)(55016003)(508600001)(66446008)(66556008)(64756008)(66946007)(76116006)(4326008)(8676002)(83380400001)(4744005)(450100002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+SVvuRvjXFAKVgemskLI70SnJKaqFkcAmM1Rg2dPy0BAUga14kiFI50LB0pJ?= =?us-ascii?Q?4lvuAtF+fH27ZySCvdnSnlPWE+l0OsQHLM5P1/MMvFbES9j56bYPJvxIO4FY?= =?us-ascii?Q?lbLxK4i3Y8jGnbwOXLKUv48uerDCsPTIXDEBJldBfr/1XTzveJc5NgH0TxNk?= =?us-ascii?Q?1gQFik+c4bEkz5t5fLZfdSbsCoSWVtttfV7qnN0KBDMzDGx8Nhf3U76a9KoA?= =?us-ascii?Q?IJ+BbBbGJfFTYg7VKKipm2TBTZ3xyHCu+F25BRHwb464HezRas+8jCn2apQf?= =?us-ascii?Q?xbBKcoiJHAT2Z7Md3SEzr6kdND3QJ/FFcCaODQQpQXaV9ZP/6q8wHnoKpnLv?= =?us-ascii?Q?qFu1Bo1RSVrmw8EgtkVrfKHULgQ1enlQgUSdnhE+6RF+FvTUMnccEsq5Ucex?= =?us-ascii?Q?av0CANPzsBvHHGFlGPmFHCyUIEWxEnYTA7J8KYL8Ozm8gFdtt56J5jN3dt4c?= =?us-ascii?Q?ilKDBFYWb81J7g3J5RIONQ5h0+2L4jv1naOaZNmwMKW/TZzEecwJaxxo7vOb?= =?us-ascii?Q?3riGlfav65m7DqP9mSL9MP9RA+iSGIgGZSMOoLmygEKZNUaQv2cOBerysdgv?= =?us-ascii?Q?RsfvZLMrluODOWSv6FHBiE3aJW4EvU8X7KT53XcvC43P784EVHAnLI3ln7Ln?= =?us-ascii?Q?FQ9EvDBjBC2GljQLWGLk6byDoGJxEsYb0lIEJWvi5DdeBGVBChmWs+wjXzc1?= =?us-ascii?Q?CjzRBtPelWOLuc7aXC04JglGN5SWsml7o0clo1/3SO4eL/zPRWhK38XIoBrV?= =?us-ascii?Q?cXFx54tAq+BLXtFaDgohp4WEe7d9ocEUXfg6xjmLVArFxMRJriPUictA4wUd?= =?us-ascii?Q?A0JDLxMz34JriQZPJE9Djc7dU2YtLJm5LT6KwKTdCRz7UvG1ijGObzuf6RQM?= =?us-ascii?Q?ow2ZNwjxzpldrUrR4R39oGJ7QtgIXJ8x13IcSoZbTiZMDFlPicvvjj5JMrOd?= =?us-ascii?Q?pBc1xEputPiDcOgQz2nZ00VER8DtAViB2B/L4mK+O26bTd7GWl7bmJRSJbJZ?= =?us-ascii?Q?0aMBNr+Hh4H9SUR/h1BSYAkB13OGjYFbvH7THIheb4OA4hZdcZmVqgDzlJQD?= =?us-ascii?Q?hdvRV/Gvil2oxsxR5/bGwgD3vCwO+dsV/vXevJ1LTPpLug/dQAr9SinmoXpo?= =?us-ascii?Q?LXFY6pObz+pizLelDlzLvUmSdBgD2OKtcdsOgbPG8Aijr/qDjTF6RL0uoQkq?= =?us-ascii?Q?YFoFbDliAFYftxGaz6lkxEnXW8Iih5EfA2UVOhwaYNPTvxV/G0Ihbs/3Anba?= =?us-ascii?Q?W0MARpDrubYcUFV8kfEbsVK7M8REkRrPa6mAV93kXk33mV8Gr64pCVqvM5nf?= =?us-ascii?Q?pGFFlh0zc9RSlPkZK0F9q2TO20ihlK8AeMHjSTqdz1KZsT/UVGKafU5gbF3l?= =?us-ascii?Q?KpH2vvnjYFSSCYfWyW8z8LYSDzlEUGWDE6REg6RpKUTfs8cG94JnSfFSAffN?= =?us-ascii?Q?vOGm2nWFQtXnzWutuXWe7mhd1Cn8gAJJyBnhAQyOQetpT323m4Udb/wlIrVk?= =?us-ascii?Q?yBjS4OEER27/gxKxVvc5aRU10k5qCfCv32o2lbC+ZXwzB2M/1Bh1grQ3CZyZ?= =?us-ascii?Q?5uut5jZJD9Pd5PGX3Ax+JPdIwG/ZNuUHVVe3kZLotveNH/9FzV6DNN61cqJb?= =?us-ascii?Q?SAH1UPNJh56RndGfb0Q9vaFSShYEclvnABhtqC9N5lfE3CNvXe18HLWUm0N9?= =?us-ascii?Q?FCGMvL8v2+A0R+NU5tNfgEyWMhXW9QKbNJa5fTo6bUlxNN0OL+mAJSk9TCMs?= =?us-ascii?Q?6ZeVKiGF2A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80210252-5872-42f7-022f-08da1c5bbada X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 08:09:12.7391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VwHxDu7Kpacn2YnWZPgBdAD8cnMGvU35kCRlW1jKrWrG50iXFJvAPF/EDotiZzK+dt1+qgs87dTcj9Z+M6pvBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0248 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Thursday, March 31, 2022 5:39 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Slava Ovsiienko ; Matan > Azrad > Subject: [PATCH] net/mlx5: fix TxQ failure when inlining is impossible >=20 > When txq_inline_max is too large and an mbuf is multi-segment it may be > impossible to inline data and build a valid WQE, because WQE length would > be larger then HW can represent. > It is impossible to detect misconfiguration at startup, because the condi= tion > depends on the mbuf composition. > The check on the data path to prevent the error treated the length limit = as > expressed in 64B units, while the calculated length and limit are in 16B = units. > Fix the condition to avoid subsequent TxQ failure and recovery. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh