From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF06BA0510 for ; Wed, 27 Apr 2022 09:37:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5AF241141; Wed, 27 Apr 2022 09:37:16 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2078.outbound.protection.outlook.com [40.107.236.78]) by mails.dpdk.org (Postfix) with ESMTP id BFB5340691; Wed, 27 Apr 2022 09:37:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bw4r+HiO7q9CKK42XVOiLAWe6IOGknXs3bJlZTD5pM86H6RheOVE+suUj8CtHwwft4DYFfULw0qoA4nqbS9kUnZRc/5cSAYHneHcBSS97V3lOvY8rZrj24qbUykuq864fKvz8PkHo5sSLg6DQSG5GCd77nZplWvcJ+wDzo+RrJv51tMsMuDzSuZCTcANEivAisWgkZiOJ3+5nLYG5LLTgCGCqaQBWGXFof/kyWQWXK/HYLPKPlg6Du6OtlK1D6NYyq23Zzc6jd2V0T/MjcLo482q/jTR9w+nWdYOarljiBPdWTltTcsT+7ph0Gjouevte1bp5zx2pJLTZGrmQTgvoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1z0GAnYmIp9aj43RmsJZIUhorBdFn1k2Jo2rNnjs0E=; b=djVzm0xuKDXISzxQ4L6vMvGOb4+ng+V83tIf7rhpaBH3EEQYfwEmXSd7NTkqufiOZegl/3XPHL3bP1dLS4HVTQr91gvMfgAHHsUEOa6n0H3N7QpVrimog2RUa2p5TOCZvRBA8arV4n/OOA8x/mkRAPHSWIItk3eGBNjI8G4WYqNgFVNB+33pEhGkXKh4449HUethdGBhMuk/ABo9bCH0dAFaAbGWX5zqawQlLBPBeNkhVFtJEUnl2Yn6faCLCvRBtu5FUcaUa7d0mmmj0azXqSR8zADKW2jCjjdBqy+7EmtMAq+rDrLwp8S/67jhD/LAfz7c3KITIdD3JP35RIMVBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x1z0GAnYmIp9aj43RmsJZIUhorBdFn1k2Jo2rNnjs0E=; b=SCnzes7g2HnBV9hyj7zyo/4FX89M5vG4eMmbnkkGB1DQkUJERUWzVZonlrA+5spBX99VqQEWZ8ahRS+WjtB9QtICcIkDadXqvcLKTIMWBJkSN/L0OQE2odNsd35TAPZIKxTSjy89T9QC0JoVPMhgONQmHvylLCbnbcrmdfLukEM6JwfX3E2cDy9eHOAum/C1rsgD3a8NYTbOdj2f1mCTMGTfcuLfSXszot02ypJHgosd3+L9RE59lfmF8+JANKZgahlrMlCYhxzdpphqUSXAfnWRw+4z0vpoMni2I174dibdrYYLvHHecd4+/OgahJ3VVYhxMWBFUcvgMaeZOwscyg== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by DM5PR12MB2501.namprd12.prod.outlook.com (2603:10b6:4:b4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Wed, 27 Apr 2022 07:37:13 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679%4]) with mapi id 15.20.5186.015; Wed, 27 Apr 2022 07:37:12 +0000 From: Raslan Darawsheh To: Dariusz Sosnowski , Matan Azrad , Slava Ovsiienko , Jack Min CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix RSS hash types adjustment Thread-Topic: [PATCH] net/mlx5: fix RSS hash types adjustment Thread-Index: AQHYVb+gz7C+eOl6jUuen4YJ+TbfIa0DZ6CA Date: Wed, 27 Apr 2022 07:37:11 +0000 Message-ID: References: <20220421203656.3252574-1-dsosnowski@nvidia.com> In-Reply-To: <20220421203656.3252574-1-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 452c7e5d-2e46-4945-1fb8-08da2820bdfe x-ms-traffictypediagnostic: DM5PR12MB2501:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iWhA19HcDfz/mg+ezL/3ll2qAquiB5WVLeGpEciMe5QM1oJ8h2ruqpUw6+lbvou+QKNqot1bWbMoYjtMG02h00j2Hn7kmMPco61VZpTXek39olC1VytGTdn20pO8dV/OaJiYxyuA4Jij1CeeO107H1xGF0dX3K91p13KfET3Re6IVS3D1oYhhIAuyT+pMpd0zDTnoaNViF0EKv875LwnCSv7eTmBWakz9yyngOss+THHuTWrHVP1/IsGCb6SGf1gVoyvpYdOhn9EqtUcjpfjprfDvjtAQvoZV5F6bY23U/8FfiH1gaQNK3Dqstnc8QoTp6MoFu5u2uaNIMrGgDQZXt0eFg3zU/TWKuPCGB8848ObuKwc/8WKMWDBnG+r3HKQTdoX4ltIjT49IUigMwrv4o4HRaGExBO14dJRsMgUqEu2JM8a4BRqxml8J3zF7C+eGEAom+HyV5xpHYFxcEP9CI/xMDpaOt18Qp4o0eF0FUAd5Gcd80qDRLKcro4riHcWp10XMFNW8igrfTQVVQbwDloTy1eW9fw8Vg44PfAscRHFshu3kLPMv9TtQpAXvwJztu+sVAPHMXsTwUTdD0gadRw7PfsFk68jlT5l+WqAGj7sG17cuv7XhR7e5HgaGuFD9baTQpD6jxCW3fvs5eIWty7SfXxBNC2+PYJOoPU6IwwAi7CJ8h32zQnsXBQP3/fE2a8xNEAK4TKME/kTDuumPA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(7696005)(66446008)(76116006)(66476007)(4744005)(450100002)(66556008)(6506007)(66946007)(55016003)(5660300002)(52536014)(8936002)(86362001)(64756008)(4326008)(316002)(8676002)(53546011)(33656002)(122000001)(38100700002)(71200400001)(186003)(38070700005)(9686003)(83380400001)(26005)(508600001)(2906002)(6636002)(110136005)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pf6x5Dcgq+XG02LtFZHYwQhH34bAOBqw3Lv5Ow5bHSIjiR56+pA6hh//bFNs?= =?us-ascii?Q?lI1efDQ3zDBcBxTBWizFiI4MuVpb76EF9a5ky5C8JtOcD3WU0yLpHrnkFTaL?= =?us-ascii?Q?udicCPttjjnSMIHqTbkgOhJZ3TxSWzi04uH1QmaIv3fDgFct4wBj5Le5CBP6?= =?us-ascii?Q?XBuCls6C/5ZAKqwkR5deyV4DMQ7PloQm40MRn7RUTKAq7SVLM6tU6m13V9x2?= =?us-ascii?Q?2/DBVj5bAncYk6MkfcCvv0SQWdJxE4TppE3R/bGOouUmCVcwLJV49XloUYCE?= =?us-ascii?Q?f5opcuT7HLlBCRLOT+NEa3ZSwkuaF9/94fg4Ht7cVjTn1QN2mTUF3qbzLZfS?= =?us-ascii?Q?ZnN9t6TIQ1ALi6YAbg2XoqP4/qfFzpacXx3c1Ll4IcAQcWZh6HloWedXpVsH?= =?us-ascii?Q?H/PlnZbzq33PFdU2DQc0wMjOJFI8PL3KgR+wJGZgAaLJrLZiZPy2eitDx4eo?= =?us-ascii?Q?wywyQb8JKFo+iTOgG4+2Q8sQF0u9pviM5onYlKoLv97mJMlElZLXRRNMNrlQ?= =?us-ascii?Q?O1YLl02fyCVMtM7TS1ytcwooZmmxSpNJVCdRHFMLhnuSg14rNHYwisXXby3l?= =?us-ascii?Q?1rbe7MzJxWF65bO9CroEg0j6TkjKgMNCm6XzQ62y+RjAMc4b+wmQXCwCWhfq?= =?us-ascii?Q?z3PHF+yDUqvX9Bkn0A4h0ps0+1yZ5TCiZ9REaSSq3hVYbpxSdUJjNiEZvgFf?= =?us-ascii?Q?w+OR5QBG4IH4rIWHq+uev2ICfDvfhs0HcX0/61Vcaf36+EreADIoB6/rOCWq?= =?us-ascii?Q?7kBiPfmdwAC4zPUOPZSFNGMphE3K7FhZPxKmUijABsa9aCXeVWgI6QdYwtFp?= =?us-ascii?Q?3tXqNeynVDDwZ6BBTHka2d1SAx40wjO0Mt84XmVOvZPAD/csRoOqtWfIZZ4a?= =?us-ascii?Q?N5JK+eYyDH0hCyeHIzoSGcFyXYiWYCs6tjcY0CK8vm8G+iOIAd4f5UqCKWeX?= =?us-ascii?Q?BUlFtV3z4POfteJzW1WqOI7BAbnxoID/63C2KOT5v8v1SNFiuhaGf2TihwnJ?= =?us-ascii?Q?ic8zbmsQUWoihj8dpMIPKren+ZfNm8psFSP3sHzAAJbG5DCs3paK/tpfYD0/?= =?us-ascii?Q?NcUpjSaHrKU4MCNUryN81Yt/ZX2WbtGxY6d+02vmBK6fm3MFWFIxtvVK41o3?= =?us-ascii?Q?XXKwZ/ClwkinE31sC07vqaqTJS2jYV+TjwqOiaLK5w50zahxKA05XBb9h9Be?= =?us-ascii?Q?DEhKAajdD/VuyViK33PGdWANNS/YE250zRRM8j24aryqfloRPjGIt8zxzZ2A?= =?us-ascii?Q?4zGEb+Qmd+FCZarh9zBWqqxbRG9TPd9mqp7W0ClA/4vzNa9mguBGALjXAFjv?= =?us-ascii?Q?ApDlZXiYlfAoxri7lZS023Cb/1I5MCRxGD4Z+NazqcwgETsssiTG1iz62QOS?= =?us-ascii?Q?DCmSH94Pmdx2kKugDG22Nnv3VpkHxUWShyhwxkTQUV4Vxrs6GxjyrJLxAOGq?= =?us-ascii?Q?yuDjosZYRiUcd7hQ6w+MbX89ftmuHzdtbScPDspVx2oxnWA+lSnqYjC/C+v3?= =?us-ascii?Q?sdTKclCx+60/eaJR+FGv/8p4DkEhNvezb6y7BWSSd4kZZUCVGvuarYnkSjhh?= =?us-ascii?Q?lwBSheQNEK8UI1bH5LhwvWXPudkNPwbjlPIqp95p3144IZMWR6aJdkVVaQq2?= =?us-ascii?Q?dLSoaSHoDvRan3S7QIT45vvw1Vm61gB2vCKvR89cwrldDFu5KrX+mXdhlOLA?= =?us-ascii?Q?qrDbCC4rXCjkL611iGbJxIIkIgV3Z9TTayatt5HCoRgp7ifAQQzw3+Nz47Ni?= =?us-ascii?Q?MjMuhI0U1A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 452c7e5d-2e46-4945-1fb8-08da2820bdfe X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 07:37:11.7490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iqRGcmdaQQFYdgXAuSn1KQqwaHfaFoQPlU9DyIIGhropchIT2Tvg2Bysodq/k9bMypoLgpRQBkIDVO5uz+baQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2501 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Dariusz Sosnowski > Sent: Thursday, April 21, 2022 11:37 PM > To: Matan Azrad ; Slava Ovsiienko > ; Jack Min > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix RSS hash types adjustment >=20 > When an indirect action was created with an RSS action configured to > hash on both source and destination L3 addresses (or L4 ports), it caused > shared hrxq to be configured to hash only on destination address > (or port). >=20 > This patch fixes this behavior by refining RSS types specified in > configuration before calculating hash types used for hrxq. Refining RSS > types removes *_SRC_ONLY and *_DST_ONLY flags if they are both set. >=20 > Fixes: 212d17b6a650 ("net/mlx5: fix missing shared RSS hash types") > Cc: jackmin@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dariusz Sosnowski > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh