RE: [PATCH] net/mlx5: fix push VLAN action validation

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Wednesday, March 9, 2022 11:39 AM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bill Zhou <dongzhou@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix push VLAN action validation
> 
> Flow domain and direction was validated when OF_PUSH_VLAN action
> appears in flow actions. Flow was rejected whenever this action:
> 
> - was used in NIC domain, in ingress direction;
> - was used in FDB domain, in ingress direction, on ConnectX-5.
> 
> This validation logic rejected a valid case when the OF_PUSH_VLAN
> action was used when directing traffic to the hairpin queue,
> configured in TX implicit mode.
> 
> This patch moves code responsible for OF_PUSH_VLAN validation of
> domain and direction from flow_dv_validate_push_vlan() to
> flow_dv_validate(). Domain and direction are now validated when either
> non-hairpin queue is used or hairpin queue is configured in Tx explicit
> mode.
> 
> Fixes: 96f85ec489db ("net/mlx5: check VLAN push/pop support")
> Cc: dongzhou@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh