From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DCFEA00BE for ; Thu, 10 Mar 2022 10:20:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92D7C41145; Thu, 10 Mar 2022 10:20:17 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2065.outbound.protection.outlook.com [40.107.101.65]) by mails.dpdk.org (Postfix) with ESMTP id 2185D4113E; Thu, 10 Mar 2022 10:20:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gV6LDn6ukTWDCVS7SvAak4sMc7PlV4VVckZECSsC+k02hzDNsjHmzet/41rUnkejS7jRMoi8uTbwSf6p8Jwb1vUUjur0/93LHdnh1yFronvLTiHio2z4S1xTEA1WrTdEyvLTGx0sIUMcXyKb4Tfzrw37J1evcVXgwJlr3FMeiUesSZtA0DbVKGFipmhYMMv4GLAqnz8D/ASPzL3A+l9ChdqmhR5IQXnT3OW/CsKO5PQFcKfE0+YmwZM4ka9d0ifvPHtUTA7wjX8Pd74quhCe3gZQ5weQVxJy7MANssrizrzwBHhn4LQ7y6Bq4x3cq9DppYlTrwMqeHQnxOSun3nTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEmqlmGVvaPuJXcCJzxdX88SUy+4MCaTj5vRCDKXHSI=; b=LybOFDAxtElGzxc32M3kn00ln56syXDyJAr17Zl3eCrOC0KL+k+sKY1nvbKbV4AdAXDA/XiZsEdEoMmS5moAK55N2mBfj5hVIL3O00BK2Sgs6DVsZAEV8/oxLjrz5mBbHyv5HyVcSCSJbc0J67vr0wfHojk6Yeidq2ICxDt7gTwGYC8sPGh4HJ6ebTifXXuIRF4bCLzhSpWeAP86/fSGDT2AARuFD5lsDHjN5llgIauCQesHYn9I5jz78bXqY6Ij1dUPbH2Y2s/7VZFsdSlW8snElc6llbZre16I489OtWZJATUD89HJQ2UIUvfeA6RErLZ+n25mqgotqKpFy2Kamw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEmqlmGVvaPuJXcCJzxdX88SUy+4MCaTj5vRCDKXHSI=; b=baxziNVqZqLoks/mF+BRB9kYYtWQ1kaR0+xpzZPXoDY4vd9BmFmPYPOPMGY8srjS2CorOx/zEbnCFAJEPO5k1ycT5jnaShu0oWIZ3NfuUuqCDJCpfXV+ibMYU1sdRlNIzo0yQ9DsEOk/HoxIypHR1UfbjtOvbpDLfXsJjtCJD5pdTPdvqXiyKdAn6FUwOMqTnBW4F9KPyEaDwwNauyB5BFJPVZAfogRRAtaNzi0FYjdW3Ma+KpLNJspAYw9QJRsGuZMVPoCcoPpXRpaU3ZCTl5RaT27bmQgWVQKo4Q97UmvzfHcACOVcsg3GSzI4QDGbG27BFm08nrc2FATNQHtDKw== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BN8PR12MB3620.namprd12.prod.outlook.com (2603:10b6:408:49::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.21; Thu, 10 Mar 2022 09:20:11 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5038.027; Thu, 10 Mar 2022 09:20:11 +0000 From: Raslan Darawsheh To: Dariusz Sosnowski , Matan Azrad , Slava Ovsiienko , Bill Zhou CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix push VLAN action validation Thread-Topic: [PATCH] net/mlx5: fix push VLAN action validation Thread-Index: AQHYM5m9tqGED9kGRESS7ZR01Eeiway4WMeQ Date: Thu, 10 Mar 2022 09:20:11 +0000 Message-ID: References: <20220309093920.979934-1-dsosnowski@nvidia.com> In-Reply-To: <20220309093920.979934-1-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66360e7f-3712-460b-1330-08da02772db7 x-ms-traffictypediagnostic: BN8PR12MB3620:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LchdpfJdhmh7aYxGSdg888iUoU26EUqvV7pNeTKWpkb4GJtTvr/iAp/AVMbdnNoKJ6ukxj47J7OZT983O6bxhCP9YoGZ/etCoN6EK3cIZTAHxUcL8ZNwe7gR4LVZaCJAZZrYRhSZE6KiyL6Aps/EX1w4XVX/8ER1fEIHE6sq60jVt4Bon9oBTOG4Bcz32j17KL/5MNL/t2lcm5wqsCf5nuC8ZO4rauQ6ZGhPgX2ckvTKMi82XAAMlMmPXwcKg5MKAxX0Y7oCVQ0S3ITHcgvGpGV550r60SVN3LYLtqHrua1EhTbe/AauLvhj/tyoTy0kN6qbLrM7K39T7w7vodg/Ggk2m3KDIweL3/+oQtwcuESiicf/O1rLRazT41ULAn3aXPA67QEWbTdtPk6aWHf9Hd6UNk757E0FtiLwraEBwkY3g3eh2c8TXptJCQJKYAWeLQ2awMnSOhRfluWodn7rN5Ypc4W/7wRlKRo55w3T9CwQw5wm0rgOVaCWhLsgtci+AkP5Leppo9yZByp5/ogtzWZbpFsy2CQn6bgiQx41Le2tEjH+z2dh5fdYYlk4z1o5Lh1o6VJ8Ic1pcI/BimbFnkN8n14kz4lhYZOWcsqdvBGWthckSTIfJuwNhYfhI44L3HzkoQ9cRkIPjkYOCbCIMGMQcz4wOFgvJ2Osxiasr108hWoquP4HADs4oZ48i03QCjxW3UuWt/Cq//BDLfHPKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(122000001)(110136005)(4326008)(55016003)(508600001)(64756008)(76116006)(66476007)(66446008)(66946007)(66556008)(83380400001)(2906002)(8676002)(26005)(186003)(5660300002)(8936002)(9686003)(52536014)(7696005)(6506007)(33656002)(53546011)(86362001)(71200400001)(450100002)(38100700002)(38070700005)(316002)(6636002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dnimMqgSjzIkAUj5QZkg+w1Z/CaBYX4ctpv8bg8Dt03LFIXuX02VzrmNTx7b?= =?us-ascii?Q?MpkQg8mzXseeiyzfTR4pGyMqRDEjzMl1I/s5iTDHjly9N1n6ojNGMRnNkQT/?= =?us-ascii?Q?GOGapM+uFHpJHvnQ2FgJ37vm6K1V/1SyET946Hl1LG/gRW4tHHCKtvI/z1d/?= =?us-ascii?Q?LrEVNVPRRZzp43jA5qTgppBAdWYSOW/d+WVam5055T00d3MfSSnmrZ9CFVG6?= =?us-ascii?Q?nuCzMO7nYfSY8FBf9fMXbAR9p98S3NCXyveyaUNtPq9Rfn7Ng7ssanjNhI7O?= =?us-ascii?Q?q/w20qc2Uv2BDUE2bHY9gJN9TebGZno+cg5FHI0RqfSUoyaq5TtavsyryhiD?= =?us-ascii?Q?LLoWsvNiEL2cqFcdWKebr4iPhby70BDXI9PxEQ4KP1EZQFFmCgJTx+Xo93sk?= =?us-ascii?Q?+fRlORohFp4cM+qPf7bRVoxABpGi1RwXm0kwZ+yo56DrgZcqjdcjlos0sQ/R?= =?us-ascii?Q?EtpwjZLFQ8ioLc9JT7hTxT4gzvPCF4bx6zK3GX017iA4Nd6W5ip8wa0i8HlI?= =?us-ascii?Q?7dCNZ3cv6FGAfw5ZVO99qr0y49ovdZcunTcQVNW8vAY8YNg8Apnrb6DGUKVN?= =?us-ascii?Q?F84ygQ7CewgxjONsLsgzw7UT4TxsGpl/2icTHO42cXJycMgdMX/ynZFWrFgT?= =?us-ascii?Q?359RCRNJtnxaqfg8IcDrDUkGX/k0QIH1BxB5sskLloTQW3BUA8sKCQUnAxZp?= =?us-ascii?Q?BjGTNCct2PPTzkP+n9RngyT1+ulfYNzuc3bjWo6XVAFXkwmr0LFhk9VSOi6U?= =?us-ascii?Q?0wDQm/tjzZpNqJMt7Uxx6gnF/7OF4Rl3qx9QcZem4Ga3WjuZf93uN/MNC6dh?= =?us-ascii?Q?Q519Js/sZBLwFbTOmwa2or8DofZsy03oOWOs01iReHRUTF+enLfyitRxjyan?= =?us-ascii?Q?DnPbSJCReY/QzwGIyQeLIK431UZ5nWKfFeE/tSsFAe6Ts5gtmZsSsaCgqI5p?= =?us-ascii?Q?VV1o2Ors6Mp3vHi07ExIEYkL/kunfrnOYgs6cz7zs3deoChVVYF6AGP2zAK6?= =?us-ascii?Q?e+6QFgJ4cu0KoqQybYXsnn7tMBHrDzIDR+vMxNPgqi5BDUnSHWSxh6NNA6LB?= =?us-ascii?Q?7tIUfT43rMf15gyYRATjrYMNMRzvsyGHub6/yu/rvwxwpozgJIG0KrKkEFk2?= =?us-ascii?Q?cJSnveOHBb2mAK1IA0asdlsjJFZRHv71t2VgAhk+oh2BOIecAC/54n/iybhp?= =?us-ascii?Q?AlxzE7EJNkcNPzlLjmGTuf9UGTsKS78+qexcIwYq8UetuOB9qiv/8xeraAk2?= =?us-ascii?Q?5C5gaabB1/gKXXDNAu9Uq7OBebRzbtaMKe54MYY/bgemv+ZyhpXCJDhfydzu?= =?us-ascii?Q?YyEM2KniOITbXjFRQ3PCRkS82J9K+5iMEUUfPog76ZF36hmMwcPFZwKEtXfu?= =?us-ascii?Q?nd89j/JlBlzLijysBKbutka35KR1XdCCB9DAZ2PzBz6hms7B6m37tL4mZjGr?= =?us-ascii?Q?r9PL/mCDrID5nlJSrSlA6uFUw11aFtyK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66360e7f-3712-460b-1330-08da02772db7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 09:20:11.6433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cWqk1bgGCJob0evHjMIOikmQm8V0kfwK5ifk9KwM6pCxbC58MKvlGyL3hMixQiix23K37Fl7xaLOKJpfJZ6sfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3620 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Dariusz Sosnowski > Sent: Wednesday, March 9, 2022 11:39 AM > To: Matan Azrad ; Slava Ovsiienko > ; Bill Zhou > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix push VLAN action validation >=20 > Flow domain and direction was validated when OF_PUSH_VLAN action > appears in flow actions. Flow was rejected whenever this action: >=20 > - was used in NIC domain, in ingress direction; > - was used in FDB domain, in ingress direction, on ConnectX-5. >=20 > This validation logic rejected a valid case when the OF_PUSH_VLAN > action was used when directing traffic to the hairpin queue, > configured in TX implicit mode. >=20 > This patch moves code responsible for OF_PUSH_VLAN validation of > domain and direction from flow_dv_validate_push_vlan() to > flow_dv_validate(). Domain and direction are now validated when either > non-hairpin queue is used or hairpin queue is configured in Tx explicit > mode. >=20 > Fixes: 96f85ec489db ("net/mlx5: check VLAN push/pop support") > Cc: dongzhou@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dariusz Sosnowski > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh