RE: [PATCH] common/mlx5: fix shared mempool subscription

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, November 3, 2022 12:44 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Slava Ovsiienko <viacheslavo@nvidia.com>; Anatoly
> Burakov <anatoly.burakov@intel.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>
> Subject: [PATCH] common/mlx5: fix shared mempool subscription
> 
> MLX5 PMD counted each mempool subscribe invocation. The PMD expected
> that the mempool subscription will be deleted after the mempool counter
> dropped to 0. However, current PMD design unsubscribes mempool
> callbacks only once.
> As the result, the PMD destroyed mlx5_common_device but kept shared RX
> subscription callback. EAL tried to activate that callback and crashed.
> 
> The patch removes mempool subscriptions counter.
> The PMD registers mempool subscription once only. An attempt to register
> existing subscription returns EEXIST.
> Also, the PMD expects to remove subscription when mempool unsubscribe
> was activated.
> 
> Fixes: 8ad97e4b3215 ("common/mlx5: fix multi-process mempool
> registration")
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh