From: Raslan Darawsheh <rasland@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Shun Hao <shunh@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>
Cc: dpdk-dev <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID
Date: Thu, 24 Feb 2022 09:20:40 +0000 [thread overview]
Message-ID: <BYAPR12MB307863B07B3FD32B5D9686CACF3D9@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <c40c3fd5-0596-1ea3-591c-ef5fe0405f70@intel.com>
Hi,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, February 23, 2022 9:00 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; Shun Hao
> <shunh@nvidia.com>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Xueming(Steven)
> Li <xuemingl@nvidia.com>
> Cc: dpdk-dev <dev@dpdk.org>; stable@dpdk.org
> Subject: Re: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID
>
> On 2/23/2022 2:39 PM, Raslan Darawsheh wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Shun Hao <shunh@nvidia.com>
> >> Sent: Tuesday, February 22, 2022 5:07 PM
> >> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> >> <viacheslavo@nvidia.com>; orika@nvidia.com ; thomas@monjalon.net ;
> >> Xueming(Steven) Li <xuemingl@nvidia.com>
> >> Cc: dev@dpdk.org ; Raslan Darawsheh <rasland@nvidia.com>;
> >> stable@dpdk.org
> >> Subject: [PATCH v1] drivers: fix incorrect E-Switch manager vport ID
> >>
> >> One of the E-Switch vports plays the special role - it is assigned as
> >> "E-Switch manager" and has some special exclusive rights and duties -
> >> it maintains all the representors, manages FDB domain flows, etc. By
> >> default, the E-Switch vport index was supposed to be zero on
> >> standalone NICs (regular ConnectX) and 0xFFFE SmartNIC (BlueField),
> >> but that was not always correct - this index can be assigned with any value
> by kernel/hypervisor.
> >>
> >> Currently the E-Switch manager vport id is supposed to be default - 0
> >> for standalone NICs, and 0xFFFE for the SmartNICs, and is deduced
> >> from the device PCI id.
> >>
> >> To handle this and do not suggest any default values, can use DevX
> >> API to query E-Switch manager vport ID directly from the firmware
> >> during initialization, and use that value by default. If the new
> >> method is not provided (legacy firmware), fallback to use the PCI id
> approach.
> >>
> >> Fixes: a564038699f9 ("net/mlx5: support E-Switch manager egress
> >> traffic
> >> match")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Shun Hao <shunh@nvidia.com>
> >> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >
> > Patch applied to next-net-mlx,
> >
>
> Hi Raslan,
>
> Can you make a patch to add 'E-Switch' keyword to './devtools/words-
> case.txt', in the syntax how it suppose to be? (There are various variants of it
> in the commit history.)
Sure, will send a patch for it, and I think the correct syntax should be E-Switch as written in this patch.
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2022-02-24 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:07 Shun Hao
2022-02-23 14:34 ` Raslan Darawsheh
2022-02-23 14:39 ` Raslan Darawsheh
2022-02-23 18:59 ` Ferruh Yigit
2022-02-24 9:20 ` Raslan Darawsheh [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-22 8:40 Shun Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB307863B07B3FD32B5D9686CACF3D9@BYAPR12MB3078.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=shunh@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).