[PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation

patches for DPDK stable branches
 help / color / mirror / Atom feed

* [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
       [not found] <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com>
@ 2022-03-09 19:49 ` Thinh Tran
  2022-03-10  9:23   ` Slava Ovsiienko
  2022-03-10 15:38   ` Raslan Darawsheh
  0 siblings, 2 replies; 4+ messages in thread
From: Thinh Tran @ 2022-03-09 19:49 UTC (permalink / raw)
  To: dev; +Cc: drc, viacheslavo, rasland, dkozlyuk, Thinh Tran, stable

The default CPU socket ID was used while creating the Rx queue and this caused
creation failure in case if hardware was not resided on the default socket.

The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before
calling the mlx5_rxq_create_devx_rq_resources() which eventually calls
mlx5_devx_rq_create() with correct CPU socket ID.

v2: change patch description, no code change

Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
Cc: stable@dpdk.org


Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>

---
 drivers/net/mlx5/mlx5_devx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index af106bda50..5ab092a259 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -947,6 +947,8 @@ mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev *dev)
 		rte_errno = ENOMEM;
 		goto error;
 	}
+	/* set the CPU socket ID where the rxq_ctrl was allocated */
+	rxq_ctrl->socket = socket_id;
 	rxq_obj->rxq_ctrl = rxq_ctrl;
 	rxq_ctrl->is_hairpin = false;
 	rxq_ctrl->sh = priv->sh;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
  2022-03-09 19:49 ` [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation Thinh Tran
@ 2022-03-10  9:23   ` Slava Ovsiienko
  2022-03-10  9:30     ` Raslan Darawsheh
  2022-03-10 15:38   ` Raslan Darawsheh
  1 sibling, 1 reply; 4+ messages in thread
From: Slava Ovsiienko @ 2022-03-10  9:23 UTC (permalink / raw)
  To: Thinh Tran, dev; +Cc: drc, Raslan Darawsheh, Dmitry Kozlyuk, stable

Hi, Thinh

the line: "v2: change patch description, no code change"
should not be in commit message body, it should be after "---"
Besides this:
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

With best regards,
Slava

> -----Original Message-----
> From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Sent: Wednesday, March 9, 2022 21:49
> To: dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Thinh Tran <thinhtr@linux.vnet.ibm.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> The default CPU socket ID was used while creating the Rx queue and this
> caused creation failure in case if hardware was not resided on the default
> socket.
> 
> The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling
> the mlx5_rxq_create_devx_rq_resources() which eventually calls
> mlx5_devx_rq_create() with correct CPU socket ID.
> 
> v2: change patch description, no code change
> 
> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
> Cc: stable@dpdk.org
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> 
> ---
>  drivers/net/mlx5/mlx5_devx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
> index af106bda50..5ab092a259 100644
> --- a/drivers/net/mlx5/mlx5_devx.c
> +++ b/drivers/net/mlx5/mlx5_devx.c
> @@ -947,6 +947,8 @@ mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev
> *dev)
>  		rte_errno = ENOMEM;
>  		goto error;
>  	}
> +	/* set the CPU socket ID where the rxq_ctrl was allocated */
> +	rxq_ctrl->socket = socket_id;
>  	rxq_obj->rxq_ctrl = rxq_ctrl;
>  	rxq_ctrl->is_hairpin = false;
>  	rxq_ctrl->sh = priv->sh;
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
  2022-03-10  9:23   ` Slava Ovsiienko
@ 2022-03-10  9:30     ` Raslan Darawsheh
  0 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2022-03-10  9:30 UTC (permalink / raw)
  To: Slava Ovsiienko, Thinh Tran, dev; +Cc: drc, Dmitry Kozlyuk, stable

Hi,

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Thursday, March 10, 2022 11:23 AM
> To: Thinh Tran <thinhtr@linux.vnet.ibm.com>; dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Raslan Darawsheh <rasland@nvidia.com>;
> Dmitry Kozlyuk <dkozlyuk@nvidia.com>; stable@dpdk.org
> Subject: RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> Hi, Thinh
> 
> the line: "v2: change patch description, no code change"
> should not be in commit message body, it should be after "---"

I'll handle this before integration, 
It's also missing the Ack from Matan from the previous version, I'll add it as well. 

> Besides this:
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 
> With best regards,
> Slava
> 
Kindest regards
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
  2022-03-09 19:49 ` [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation Thinh Tran
  2022-03-10  9:23   ` Slava Ovsiienko
@ 2022-03-10 15:38   ` Raslan Darawsheh
  1 sibling, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2022-03-10 15:38 UTC (permalink / raw)
  To: Thinh Tran, dev; +Cc: drc, Slava Ovsiienko, Dmitry Kozlyuk, stable

Hi,

> -----Original Message-----
> From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Sent: Wednesday, March 9, 2022 9:49 PM
> To: dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Slava Ovsiienko <viacheslavo@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Thinh Tran <thinhtr@linux.vnet.ibm.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation
> 
> The default CPU socket ID was used while creating the Rx queue and this
> caused creation failure in case if hardware was not resided on the default
> socket.
> 
> The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling
> the mlx5_rxq_create_devx_rq_resources() which eventually calls
> mlx5_devx_rq_create() with correct CPU socket ID.
> 
> v2: change patch description, no code change
Removed this part,
> 
> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
> Cc: stable@dpdk.org
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
Added missing Ack from V1 from Matan,

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-10 15:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com>
2022-03-09 19:49 ` [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation Thinh Tran
2022-03-10  9:23   ` Slava Ovsiienko
2022-03-10  9:30     ` Raslan Darawsheh
2022-03-10 15:38   ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).