From: Raslan Darawsheh <rasland@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Ori Kam <orika@nvidia.com>, Matan Azrad <matan@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 1/1] net/mlx5: fix device removal event handling
Date: Mon, 19 Jun 2023 12:14:49 +0000 [thread overview]
Message-ID: <BYAPR12MB307887A6A554BEB598D7217CCF5FA@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230530151328.29738-1-viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Tuesday, May 30, 2023 6:13 PM
> To: dev@dpdk.org
> Cc: Ori Kam <orika@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; stable@dpdk.org
> Subject: [PATCH 1/1] net/mlx5: fix device removal event handling
>
> On the device removal kernel notifies user space application with queueing the
> IBV_DEVICE_FATAL_EVENT and triggering appropriate file descriptor. Mellanox
> kernel driver stack emits this event twice from different layers (mlx5 and
> uverbs). The IB port index is not applicable in the event structure and should
> be ignored for IBV_DEVICE_FATAL_EVENT events.
>
> Also, on the older kernels (at least from OFED 4.9) there might be race
> conditions causing the event queue close before application fetches the
> IBV_DEVICE_FATAL_EVENT message with ibv_get_async_event() API.
>
> To provide the reliable device removal event detection the patch:
>
> - ignores the IB port index for the IBV_DEVICE_FATAL_EVENT
> - introduces the flag to notify PMD about removal only once
> - acks event with ibv_ack_async_event after actual handling
> - checks for EIO error, making sure queue is not closed yet
>
> Fixes: 40d9f906f4e2 ("net/mlx5: fix device removal handler for multiport")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2023-06-19 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:13 Viacheslav Ovsiienko
2023-06-19 12:14 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB307887A6A554BEB598D7217CCF5FA@BYAPR12MB3078.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).