From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E2C0A04A4 for ; Wed, 2 Mar 2022 11:20:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85F4840141; Wed, 2 Mar 2022 11:20:11 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2044.outbound.protection.outlook.com [40.107.102.44]) by mails.dpdk.org (Postfix) with ESMTP id 77A2340141; Wed, 2 Mar 2022 11:20:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XbQdMAj1BRmFeFSbCjiSpMrhQgNQslkCPIFKZVc5Zj2/So9o5YEoDBxsND4k4UdzPUSZRfL2KHvXpSRuVuPVDFy7+KuuluwF+3LLOITlcYeL1BBhCYj1xvQAoIvGW6UbV8vyJYrNNa5wfrpW3vaZRdIpb/GpwWun84+VbR2hNs6SKSsy/E4DE+cUv7SQIe9kLFNQ6o40j1lgnIKRnKn276DpiIBxZYUWQY7T7muob+do67lFkYzyvVVpL8PKBAMf8fh+lw3pTA1sCUFS71QJDZEkY/Ry7o/v+FJVpb07jkMWKCxRdR0s8QKMFs/4rFrIRPUkJ0qTRFQe956TfWKqIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=39zS9yn3nbBAgy8u+PbIPTsCtGK+tfElMx/tVN+/03M=; b=E18eKUXy76uAPK6BBLNNHT/n+IZ+dzi2Pumn0JkrzZwA5Cpohx6sZxDqeSA/HZ6BjTFBVab80eESlCLSkX+P7vETH2oSl76+bAMewzN0tbza9VlXfSsJaMgN9Rtc6eHUZbPatIxTfG4OPMbUCPYF1I5NqaUZWTQ7/9uvBzOey15MXPacwv9gMtL4Z+B9CwYU9QzI2V7CS7xBNhv957u49XE2db34IK3vccPWlO2bWIQoY47a48J7GQg8YvNTFPdaOSRV4Jf8dsi4J1Qq1V8rqS9Uvuf650koHQHx002WHBsxLVOQd0YjxO0xZmTLSwlOO/vrNzeHtKu4/GGfWPCvDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=39zS9yn3nbBAgy8u+PbIPTsCtGK+tfElMx/tVN+/03M=; b=OAix0V5T9DDMaw9u0h8Z221apYflsMb30pY16XGotnZPGOsN52kChfkZ+zV1PCPODTGYo8t7VhGtBRypaMDdRVdzklZUw7ckb1L3SDtIHaAEXTVZtZOt5n52ZO5LgOOw70VE+8YBKk8IxAbEA0lvCR37pTcgNdwYfCDJ+dL3ZuRye9AdKIE8zoSkfv4rleKEaSHQSBOCv724urzwYsgovRMDoFLlnAS5Opksmna0Aa5V1LuV1RSZItHPjiNBj4yFtl1pK1Rhby9xQQve8B3WVylBNGsuHTLQnL5Ps/3aLI1B2ave2zeJEJ7nPwzBAQAVNEVNOdwB6QFuuZ/avJOMVA== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by SN6PR12MB4624.namprd12.prod.outlook.com (2603:10b6:805:e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.13; Wed, 2 Mar 2022 10:20:08 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 10:20:08 +0000 From: Raslan Darawsheh To: Adham Masarwah , "dev@dpdk.org" CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Matan Azrad , Slava Ovsiienko , Tal Shnaiderman , Tamer Hleihel , "erfrimod@microsoft.com" , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix destroying empty matchers list Thread-Topic: [PATCH] net/mlx5: fix destroying empty matchers list Thread-Index: AQHYKJ+qzKGX8l3sVEexhX7PJE+X66yr7Nvw Date: Wed, 2 Mar 2022 10:20:07 +0000 Message-ID: References: <20220223093205.4240-1-adham@nvidia.com> <20220223093205.4240-2-adham@nvidia.com> In-Reply-To: <20220223093205.4240-2-adham@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3158224c-9e5f-4bad-7c92-08d9fc363a00 x-ms-traffictypediagnostic: SN6PR12MB4624:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lLGH7aCAz88XBh8SjqAvoOQsZwFoPiecYy/0McPg2nQ1NWWKcPR1ajZWmOs4bxzB3atsPMR8SDafEQOgdYtKhN1UqYNTmH5EFsVCy/hkL+7TIyGLPNqLQkV5k5fz5pWbSz0GyV+xn59WtpzeIw+VKQBjxVUz5Sh9Us5fRHjVZSN9qLuQ0AgcMHmZoNvVh/06D79nVJwKxxggyuqFKelOmrMlDYrGhmrvu0hpHWaRTpEzbA36mG7XGP3H3qQTrSUIFUSxZf+YkCtYgiGeZ4QAw0C4RF1pAJ/xgWfmPp3dVdQqQBGhQ3ieSzeE3lssY4zDEhr522ZAfR/CPjUrY0g4AJOtqI4nC3MdxRAgXyKOWd7aRbjWHb0Eo/1qfWOUQELabRNrT186MyX+UpABOIIAyK/2y6oBFoItB9eZq+yh3aSmJAbCgub4xw6FRVlXHkh7GrX7CScgrNQhXEmsUqWW6qF4HvJ6Ir9s8JBVFcHiou/LQ1l9oxnEmUlBCv4uYCf5o2DjWVSrBdhIIBtY8EYQex7FBKWsCLrMXQ82myyUsrcs7ZINGWh2WHP+yaFHzrshZBPFvHJmvbyhExm7fIbADfuCkI8M8PV/74qhsY3P6JOZr8QJn/dDXcvUKS930NJmLXhcmVVleR5uCkglqpRG2hjjNcIRfh8333Jhq0zAH0BREFYzyd1d6eNFSb7HYSa3QlVDyFEoyTDqdSTYOZQBqA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(83380400001)(122000001)(86362001)(38100700002)(38070700005)(55016003)(6506007)(7696005)(53546011)(33656002)(9686003)(71200400001)(110136005)(45080400002)(316002)(508600001)(76116006)(4744005)(2906002)(54906003)(26005)(186003)(66446008)(64756008)(8676002)(4326008)(66946007)(66556008)(66476007)(5660300002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zeDQEGYVcxUYm+TT5niJUTQiQfpvo1LuENcDoPpotpdp/CuD8cu7/8xhBHpx?= =?us-ascii?Q?JMhynSEfEQP5hXN466EJ5GM/rvZfkYaKJ2w5/tV5WOuAOY1RSGpwanYNVjs1?= =?us-ascii?Q?aZbwsqrOfGHVMRs3Euv7icO3aJabsK0pTIky2h1UQ7esfR4dJX24PCEY3GeZ?= =?us-ascii?Q?AWiXpIrowrstMZhCwEh6NoOaJh3cP8YJwgqvxmTXjvurhWZb4xYTRNPahH9+?= =?us-ascii?Q?OyYhXPvsM5WigkMV3zGCF5EusJDFD2gDT7p3zi33WNoGrpJPbEPHSUiz7FJa?= =?us-ascii?Q?DBe6ryWmwgFt/jF4VklgrXsZtXt9W01JIZRKycUWQsUX2HHd+0CJSAaCcDUC?= =?us-ascii?Q?1NCoExu2S3bAxXu0ueVCEk0p8nF2mIlHebMKbgfhiung2l6EflXT1pk/yXSy?= =?us-ascii?Q?2UqH5XF28IRYMB7Ac8VsDIyUcO4j/I0djHf6Lcu5gAEhblVcIeeepPoRp+hi?= =?us-ascii?Q?ez3fwCJLfG98SNNx+L3Zo9jzFaMQDw0vhpXemK10ZgLy5akipC4kKvZRF3Xd?= =?us-ascii?Q?XHxGycZn017N42J322M9PaWO3NaSRUydIVoe+mX46nrkypcvumUMDHdeXayU?= =?us-ascii?Q?aeLAFR2oWmah8jiKCH3HcU/s/JqnFUXq9tM3cG1DsBcD4WRcWr2dtt3fMGCu?= =?us-ascii?Q?LWmX1muVDmLnKr8fDhTjqSEbWWoYKP8ocmPLdsokJn8cE9/izMzhMUmcQdZl?= =?us-ascii?Q?EpIzMlGNnWys5oMbZppzufszf/Ntg2auwDtEyrXTCTg+q44KPlUhzJhEC6/Y?= =?us-ascii?Q?YMA8SXu50UijlPSAK3/mb6yB4PMyDrdtZ+/vvskJHB/hpSn55SiD7dPWfvnX?= =?us-ascii?Q?rLKuctsms47GJY9FDrDYiQtFMShdmoiKQ+qwrRftXWWPqkdQkURlthGJFRgG?= =?us-ascii?Q?BHWQ+zNmblAG3WZxgeV2MI+POgRXqRTlWKmqxO0Qub9fOog4vdgdNZpir0t3?= =?us-ascii?Q?2MedD1A4KSubM+Ac96MsE8yacEK7FLa6elZCPHc4rsVPKCMDfFtE8NYeVRFg?= =?us-ascii?Q?X0Ek0jrQ9as9W415G3EXs3C4YtVsrisCHu4v/G0iAxRRz7fZQGMhfDJsj9e0?= =?us-ascii?Q?9qHdjElHbCDR8/7+LoPrfu4kNrMngPaxAjeLTmYW2XqdBhoxFc1MXptr6a9Y?= =?us-ascii?Q?QnE3a3cdvuOnrYd/QWGBkAhDqV06KqlaX2GMTIrgBozgU9yMO6TXNfD6cM99?= =?us-ascii?Q?u9IIAyhkMeTNVCpe0cnCRNwynlDTEo1lyX52V1d/3WJsUJO6wLZIha02oA7a?= =?us-ascii?Q?qr0n//eSonns/whHJ7bj8z3y8yZxCgqzwQUdr+JJpiQD+O2HEhMnK5igW01P?= =?us-ascii?Q?I/N/bJ/uN23Au3LMtCDC9cg7sM0L+RSInXNNkOGcAcAbeH0AU9UEdUznWPw3?= =?us-ascii?Q?zTkAtfCVLaEF1WHqxvVw33Zv0dhdEaNTSupGH3HDuOxAsyHVzOtiRJKfcKP3?= =?us-ascii?Q?hrplSeMW31khpA1aV9He3cjfYIUV6fYwwQKbQCYzm2n0S+t6bd3Xrf1Hihy1?= =?us-ascii?Q?NkuFAfQxMemcks5LE5TUu0H8aT39/UaOczQMO47kpWqodE3YgrMjj3PprTBN?= =?us-ascii?Q?fENS8ciSBqGqGPXH/NZaOV/DugO/4kcAN3FPh0UnEIIQ8rUFHU1u/Ry14xQD?= =?us-ascii?Q?fDmyKvXmAW3n63O4qlW9si4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3158224c-9e5f-4bad-7c92-08d9fc363a00 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 10:20:08.0242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +x9BPsByU1tU5y+ZgN+r43bI7wB3403sJRu+PZHvTTjvSFMAA2BMJTyK3A3e/BtMtDJY90OCPiwlTpSzOTCFtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4624 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Adham Masarwah > Sent: Wednesday, February 23, 2022 11:32 AM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > ; Tal Shnaiderman ; Tamer > Hleihel ; erfrimod@microsoft.com; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix destroying empty matchers list >=20 > The table remove callback function is trying to destroy the > matchers list associated with table entries without checking > if the list is valid, which causes nullptr dereference. > Fixed by validating the matchers list before destroying it. >=20 > Issue can be reproduced with testpmd on Windows, when you run: > port close all >=20 > Fixes: 1872635570be ("net/mlx5: make matcher list thread safe") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adham Masarwah > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh