From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 184CBA0093 for ; Wed, 11 May 2022 12:11:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 085B34282C; Wed, 11 May 2022 12:11:25 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2078.outbound.protection.outlook.com [40.107.223.78]) by mails.dpdk.org (Postfix) with ESMTP id 11FBD40DDD; Wed, 11 May 2022 12:11:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y+P0c5bmgRfis9Vpj56PpIvBjAiyvRTx9QT7iRk2yTWrT16o3KnfUXC9twaMb28riYNZGr9opt6ZpIK2lHut0hdSVc+y2E2Qbnot1P7KHH0hRqrT0seLGyPyYyRA9Ouu78AeOCLTSYOlE00VFRsubkAXYt1KADB5MzQWVpwnH4jiR1WnGGLRJ4p6rufDKM7GCSouU5xKWUc7T9KkaYteDiCfEd5sS/87LynkB0O9pHoDrvVl9YY5Q2iTXZTquOWgZAr7JjZtBiWL9hiotkzTa9vvmYAiZqdfyMD+VMptoFCWm501/TPJNmT9b2/grI1XAKat3FLZCUJvwA67Pi3zDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VnQW2ymx7vpGsnvvh2IPIyVHqXk3Fa1LlDlXakN+Pys=; b=N4jr+hLcwls4fKZ45InR3kRQr/o6piPcUCJDC70N2Qi0ea8JxIJJrUOFM2uH+Nw7rMSIGylUKfFpa30HW2kKE1eP6Am/zZNqog8/mzbZHUNDZhOfiwMoyVQFWzmiFKMM7c3SzCi9/rjYXxY1PeArlpL2Tq1GVGzv8BOE112+uUH/44BAO1RFtLtDzRuO471+0adU7LlE2xdj6TZLMCCsrd8rHplDO/RDJoFqFOkqgzfq83zU60DkwKYvazAk/Kite/lbXj0UiidC3lQffVqOZPYbSspiLG2e33VN0RRZDJn9US+M1XqjD2GZfxNHwo92Tmv6tPnyspGc6ghuO0WMhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VnQW2ymx7vpGsnvvh2IPIyVHqXk3Fa1LlDlXakN+Pys=; b=tuEZh4pGWKGrcaC01VlB6k045EiK4x2hCx40zkQ/6aRnE30LcKEvm/p2d5BoIAgiRDMgfzXO8OVAwJRR2CMrgUbdfBw0nxTkF+A7HrHvajL3+h2Zd8Q92rgJhnqsgN2qC6WntoTmyc5oxcNlPJ5xgA86Ae+rnPbqopAH6jfn/pNVOSsGLS9X0jBMOr+TOoz+oJ5GpmX8Zgwtmcu8fNsz9qHT1BCJk965afxQs3Gf28s13KyElJ8cxFR7MUGNgh6aFggN6Li8EH50SktsH+AoOr+FEM5YQ2YihHCJUdwRgLOBo5X/tr+9nsodUEDbSS13m+sjlpjFmeIc0r4KLzfGAQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by CH0PR12MB5074.namprd12.prod.outlook.com (2603:10b6:610:e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 10:11:20 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679%4]) with mapi id 15.20.5186.030; Wed, 11 May 2022 10:11:20 +0000 From: Raslan Darawsheh To: Shun Hao , Slava Ovsiienko , Matan Azrad , Ori Kam , Bing Zhao CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/mlx5: fix quit assert when no meter green action Thread-Topic: [PATCH v1] net/mlx5: fix quit assert when no meter green action Thread-Index: AQHYT9UN79AeAVG4n0aFhaoothvxD60ZnxLA Date: Wed, 11 May 2022 10:11:20 +0000 Message-ID: References: <20220414075521.11239-1-shunh@nvidia.com> In-Reply-To: <20220414075521.11239-1-shunh@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95eb9bbc-ef71-4bb6-dddc-08da33369889 x-ms-traffictypediagnostic: CH0PR12MB5074:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aoE9yo1MQOlDzeyI6ANnzm4RfVGq/lOgSuiOQDeghx03ikX6brMLqQDVk+592wv7z3qsvXlKvs3YJHyHNakxpRdcq8SmMKUZQO0AIXWTD4Go5MwA6wn7EZlBX5x+dI4xOVWsvv5PFaNxrekrm2par+CtUhnHq4VTKfhzYRN2982ddfeYoOG5YEVE6I2492XiANg1cx75OPsrgri9ISgOQJFyKkX0CfFqiH3GfMU7bPBzFnSkN5DgBDH0qpiIkWGxWIK/EBB9iexRZqoV/osOPmlApTpT7pPA+D//zA0rtVEBu+zqTy5jo6pFwcVvQcTTzwwOSZouJKFZm5f7IKw5X2DGuZ34h80JckXVLUjDOI9pTYRfhIDG3FmOr76zciWORYjjaD/RahHn/W3fGrtiAuUKk0Umu7dkR7v1BykxBmngKb5HANKDT3U6DkYC3cJTSLoCcWlCHF+9ICLq7lmH0SaSmDOETMItVHnsqsRQxmECURcOoBT6qYLvAMX/f3pbcuU4TE7ptGvLBkIUHmC5r+S7gx5D/nUcqEwRyh+H8VxAtukflbzlRpkHG8rL5RjCs5GNI2/KDml5aAwCnMFnQCw1zUbr9vrJ/5mQlr+z7NNZlTASPHDVnSgVMQfRX83TOf1DfSpUEtiNHHNAfxOFu4b063yl805RWNVcwtCx5riCgjmtcagPFCHOV6uCNHJYyl1N+DWMBHA5I3Esa7tS2A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(508600001)(38070700005)(55016003)(38100700002)(83380400001)(8936002)(6636002)(110136005)(54906003)(122000001)(316002)(186003)(9686003)(71200400001)(8676002)(66446008)(6506007)(7696005)(4326008)(64756008)(2906002)(76116006)(66556008)(53546011)(26005)(66476007)(66946007)(4744005)(450100002)(33656002)(5660300002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Uw0luWX71N8WzrGv+frEMaszG9rRyTyyxjAm0NB5d5cuo/6iCUmns6jNOJa9?= =?us-ascii?Q?zz98jWh29dzodY1GSNfh3kU7pnhlBHGSk5+xKeycIJdw4zcXbV48RklFKn90?= =?us-ascii?Q?ZbHWI//konbsFzsNbdFYjvYOmkvKxrfyoG2jBKsQeN1TrKF9Ep3kexqIV8Ut?= =?us-ascii?Q?O6jR0du5lcOfLNITVBlxH8uzhxrjnlT6PHF6tzCj+Y3YS/dOMWSMaazgZIWw?= =?us-ascii?Q?AHSlz/yHxctxu9C0xS93+uRyp57kRE68h3Dnwbg6+D1AWCZWCgWzzmQd1Abz?= =?us-ascii?Q?CtXoLZVP+uRiTgzCW2gwqR7gygofzRpGL95ioRaBcNXgmfPIWcdPA9QHXKjb?= =?us-ascii?Q?cwol3He/FLoklv5I569sP6VY9my2b1dMZdtwgIyCYxXrL8O/oSlBABE8Yg43?= =?us-ascii?Q?+HmU5xuISfcIozZO2DpFQ2osFVXAHJkQ0facH5K770DqmcOXrrbShXf0V9by?= =?us-ascii?Q?ma1lWIXzbK6nkTWX1CZBNwgPpZmwwpI1gIY86kaX+4LZjEqeuqezI1Tzu3eB?= =?us-ascii?Q?Sx6Z7M6cQIelfsoAhfg3FUrzZbpTfHd7KRnS6DVR+/+XAnUHqx09aq/CLLkL?= =?us-ascii?Q?84n3fnEdCPwuocLwSpYdCp7BW/pdEHAkr1NrU7ZNHUbOpSpUPmoFGCb0ymTW?= =?us-ascii?Q?Uijm+9aMUyvPVMDmff5iIINKwVf6shXSCa7L5arR9HT9uBsTiK7WPLPsM0qx?= =?us-ascii?Q?fXmMoyks7J2fA7SxD1pBzP3StMeJbgM9M9W5KhjYeN9K+WSrere15xaGG62E?= =?us-ascii?Q?f9jUBLq1Ps1gTmGB3bavs1xYTlfqEV9NKVlJNSlwaHCR9qlMPD8f5pvVIWA1?= =?us-ascii?Q?GnmtwNGFy9xTS1yg/BOAl5RMqueLuNpIeNpCN/OsOy3hEUZAg6pNrD7TjNuH?= =?us-ascii?Q?xp7wXfgfCblJa6vfhhSVulhtmFkYdSDfy0dU2GgX+8LNss7VWBI6G7x0sKoQ?= =?us-ascii?Q?8ODQMpj1QNNPBizJ/TcbHd0yuTIgtky1GGYd7+oSlAt13W8DWUQf6hMeO3zq?= =?us-ascii?Q?/Yt+WAO36ezkpg/uV9qqX9ehDBh/j6h/ab2f8RBflgD0LjgWJGOPnzHR5JxC?= =?us-ascii?Q?+nT0TGMU0dGTkshueKMdeCHgQAZbbtVlh3wHKrqfSuHbe0so2Z+xcGH0tDIa?= =?us-ascii?Q?5xzlHmjC0KE+grwTzsjY9bqftviI04N/op3fSASheUwrj2VtaCYJKUR9SakN?= =?us-ascii?Q?M1bDE8V+Hmb4co5MC4HYbhnYy4BNqpbbuKGJSZugjQp1TphC3sgtqq/ACALe?= =?us-ascii?Q?wqnlxscgUfaTkwDmc5PHz/xQeL8SNO9DkL0f1fOpWMgA0dmFX9AN9x0KyvVE?= =?us-ascii?Q?4y9x0mLVDMqeIOMW+SwvQAKndpMqcqiLFZGN1lcMmeV/msuhsmZeB5ibhPG6?= =?us-ascii?Q?ZmGikyfTBbpW7DmcmDZw5D7HYwMo+af9zpauWUg7e4tiVXKy85FblShIS3y7?= =?us-ascii?Q?mfFle1Z54ePmEScM0GY8HjOdl228t+84unnYr9j/iX8RQt9ug0IGLwHdFARI?= =?us-ascii?Q?CGuNQAR+/e0KFW/gkXhFNEEko3msaAm63a7ko4/z0SwBQ6kH60crRSvSlDaD?= =?us-ascii?Q?8XCWj2CHEHMDWkkfePL9/1KsfIPdaOl86Ujr2ezMmUtQxHTuuz4Cub0Hx0lE?= =?us-ascii?Q?oVvTvKDjvrKeu4iIF9+y3yalfHxpnvcSU6lFqYYHC2XI/3U21uf1IM5Pyful?= =?us-ascii?Q?yopkvwivIEGquwQzjHlYVVwyLgYKBYANWXWN8fp+ME56PsGBleF6gXH3sGhX?= =?us-ascii?Q?Ovn8O2tMHA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95eb9bbc-ef71-4bb6-dddc-08da33369889 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 10:11:20.6456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LXPcwHMVNZGc4ILbpZKZL2N2PjvgVTYC96r8X2U7dlNU3hL5JKK3n84MvOYriIZm5lEVGppZGmmbfMccc7o2Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5074 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Shun Hao > Sent: Thursday, April 14, 2022 10:55 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Bing Zhao > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v1] net/mlx5: fix quit assert when no meter green action >=20 > When a meter with RSS action being used, there might be several > sub-flows using different sub-policies in the flow splitting stage. > If there's no green action, there's an error that will always use the > same sub-policy for all sub-flows, some resources will be > overwritten and cannot be released, leading assert during port close. >=20 > This patch fixes this issue by checking both green and yellow queue > index during getting a blank sub-policy, to avoid the incorrect > resource overwrite. >=20 > Fixes: b38a12272b3a ("net/mlx5: split meter color policy handling") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shun Hao > Acked-by: Matan Azard Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh