From: Raslan Darawsheh <rasland@nvidia.com>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
Yongseok Koh <yskoh@mellanox.com>, Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Saleh Alsouqi <salehals@nvidia.com>,
Wisam Monther <wisamm@nvidia.com>
Subject: RE: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev mode
Date: Mon, 7 Mar 2022 10:27:55 +0000 [thread overview]
Message-ID: <BYAPR12MB3078F6CC5125B7727592A5CACF089@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220302153051.45530-1-jiaweiw@nvidia.com>
Hi,
> -----Original Message-----
> From: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>
> Sent: Wednesday, March 2, 2022 5:31 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Yongseok Koh
> <yskoh@mellanox.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev
> mode
>
> When E-Switch mode was enabled, the NIC egress flows was implicitly
> appended with source vport to match on. If the metadata register C0
> was used to maintain the source vport, it was initialized to zero
> on packet steering engine entry, the flow could be hit only
> if source vport was zero, the register C0 of the packet was not correct
> to match in the TX side, this caused egress flow misses.
>
> This patch:
> - removes the implicit source vport match for NIC egress flow.
> - rejects the NIC egress flows on the representor ports at validation.
> - allows the internal NIC egress flows containing the TX_QUEUE items in
> order to not impact hairpins.
>
> Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
> v4: rebase
> v3: update the tx_item checking
> v2: fix one typo
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2022-03-07 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 8:40 [dpdk-stable] [PATCH] " Jiawei Wang
2021-11-05 8:59 ` [dpdk-stable] [PATCH v2] " Jiawei Wang
2021-11-11 12:59 ` Raslan Darawsheh
2021-11-11 13:17 ` Jiawei(Jonny) Wang
2021-11-11 13:19 ` Raslan Darawsheh
2021-11-12 12:42 ` [PATCH v3] " Jiawei Wang
2022-03-02 9:00 ` Ori Kam
2022-03-02 15:30 ` [PATCH v4] " Jiawei Wang
2022-03-07 10:27 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3078F6CC5125B7727592A5CACF089@BYAPR12MB3078.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=salehals@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=wisamm@nvidia.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).