From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1EC6A00BE for ; Mon, 7 Mar 2022 11:28:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A333041172; Mon, 7 Mar 2022 11:28:01 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by mails.dpdk.org (Postfix) with ESMTP id DC5854014E for ; Mon, 7 Mar 2022 11:27:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WKyfeYkNrdLAQa8Zd4bQ38q1xHApMIw88EF6PtPr+iyUIQBPetkwHI6/TFiLtxcVQ0wmZod5oSqUlTlJdK4jGx4HhhcUlxbu4qWmcbzJaVedLIEKvRIhZY7hCT2XVMUrzw4WOnCGON1mtMJ9dgpCWb/W2LEcozhQqyGkaijl4aAu8wIhjd1WTLpUmgdSSQ0l1W+iY6NH8Fr/WkQi5n0Jsd6axuTGh2MESNcITKKy2CeOw3d1MOFaH8ddy+htZHH7atQEdRRtq6Qgn2zo+z6f7GgkXLS4s8bTHL3cbr0P+VAN+I1BCankLeZy4nIML74dq4K1RaxbFoMQuOyShNCgrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rnPB6IeZlE9WS/e7ocSJoQaekShfrqr336HyhN0o5bc=; b=LdjCOj2hd1ihuxqrZoav1jXDMKExdEGH7jhc/ipcz4DvkYU8jIva/VhV6M8fODs3qZYApsxd+xPLo5UoQnSTr4+JvjvZpyTEdf8uge3tCmr0zTqPlNh9oxe3NK3Mw80rijX+Motg/WJizStLPIFVaiNawAUtyMXWUKFpI8L4uJWcEHWs/gZsZ5rUDBMmArjxfmOeOATurtFYwCve87ry7X3dBgZ9NkYOPwjb/cbbGzk9CdxPPRM5FEBXcbDqttEtCQYx9YFpndhBWJVWmCLoqoke5GwnSRwjcT9qV32FnzY5wICLJTPi0It0TpTc+dudFgpgGM2Hr+3hTc6qfP8Dog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rnPB6IeZlE9WS/e7ocSJoQaekShfrqr336HyhN0o5bc=; b=JEVQZmMOFN4pQQWLt9/SfNt0TbBagL0vbpY/QW2taKv0JExKHkpLxrnOAejno38qsCQ5GBHw1Lpl8UVvdeJnbIJ9Nxx1YxwEaih9v0PKxOMEHYc5kDeIBuZm0/gKfIV9SdJXo8WrxxIg3i7ByIP2AVUtHQEShb9sPUsfBgEQDIOayrEmSKTuQR0l+wiuRTYzjc7ThpCn7XQQtyosbLqjqtHSH1XeAQlI4nhU4aUEB9SCjxo/8JthwpRbxw+pDCxSFFjispbAOUHHkPoRl7L9YkiBd89se8nCxsG5b1xwgUA7XEEzYLNgQC6kAlodFzoHVkI1WThEDQ/HKjZefPLKog== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by MN2PR12MB3070.namprd12.prod.outlook.com (2603:10b6:208:c1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.17; Mon, 7 Mar 2022 10:27:56 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 10:27:55 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Ori Kam , Yongseok Koh , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" , Saleh Alsouqi , Wisam Monther Subject: RE: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev mode Thread-Topic: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev mode Thread-Index: AQHYLkqPQrjlP0ZyD0qynoXCBpY0Xayzv0lw Date: Mon, 7 Mar 2022 10:27:55 +0000 Message-ID: References: <20211105084051.20159-1-jiaweiw@nvidia.com> <20220302153051.45530-1-jiaweiw@nvidia.com> In-Reply-To: <20220302153051.45530-1-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79bbe9fe-845f-45d8-b3c4-08da002524e5 x-ms-traffictypediagnostic: MN2PR12MB3070:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mv3MbSbLx8vHt7voIhTPVHHXKV6YT9YUrKrc1m7941ipuz/fide6e5UH4DQDr57mze3tfdYyIqicwh8+9K61KIeDgaiz8/xx6Bw1fmD+naFr29Oz+QcLQKNfzylElmN/RkLd2V/2sHVj4IaWHvNxw+UqRRyGXWW/cgzOBZQercoY09ZJwl0pqmhx7SdX8ENtJqmT9YXLfnzn4TN9vdVrV5gPeBTh3VVhttx+LwLMv1VMzNGmhRN1VqBtWpHPCReUIdaHzmE8n9BHmfWraTSeqnnpmdpBXKHKAaiK4JBEO7527mT8D1tE8XqwS2T78YSfI8Ym5FYcjWE6JkkzILmZGie8Ul3W8h4ylCbjQ6SunSoFnR+sVjMm11AVJPjEuBf/Wweu0YIbU/iljLILBKU/JuxBYX2tPC3wXoUzcZEMt4BNvswVsL2VORLhBuE/SNTVWZX7t0+haTdbvTjBzpB4Atls2kK5LQ0MeF3UIHwIKSd5m3T38bSKjDfli1ZHpzXn9mOg+doW6K/T4uqOjAW/bv+HliivV7XCsRzupCPPylb86xO9WVBFSrsLsa+dmgrMx1F9Joz2hGJaDI0TGN93aI0hxV4A8cCcsQou4I4hwTxnKIs2IVjJA8Cxr/hDMKscXHxcbsGw9kRPJLOYWqQXx3XolvGyBeTKwRNBRAvYwQk3Op2a7LOdYB2EBM6WfPRcod4qTRgrchKzDt2/gqunRw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(38070700005)(71200400001)(55016003)(2906002)(66946007)(5660300002)(122000001)(8676002)(508600001)(64756008)(66476007)(450100002)(76116006)(66446008)(66556008)(4326008)(8936002)(6506007)(7696005)(6636002)(9686003)(53546011)(83380400001)(33656002)(107886003)(54906003)(186003)(110136005)(26005)(52536014)(316002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R/DuY+JoR3pXhQFw/7YHxa2oKVsXv8JmEATkGqkp0y06mo5PKYSYfAvw2rdD?= =?us-ascii?Q?b0qWfN4XDtCStp32Lj3VHBlRyLF14VYuFIQfQTcEpO81UKUjwqmi4eRmCBwI?= =?us-ascii?Q?7f21S1t/1lnARddTDOT38wk27jhVDKlHKG7RghiUescI8zgw4YgaTnCD2VBh?= =?us-ascii?Q?5uMqRuy0xSydQLofU1x4WsWa6w0OJBnyk5iwLy4C5krlzJLCkFxQzaYogoT/?= =?us-ascii?Q?zfe1bZtbomFyfgYuhOan74lahj7QldX8LbTMc0PV1gfexL3OaPahJGP7CXYy?= =?us-ascii?Q?LEejT8YQJqp8YXY1dWn9UpkvQpF9ffgPec6rXfozMvaQQKhJDLRYmZUmIQmG?= =?us-ascii?Q?U5RWwdiCV3LQSjViNFOIoaDzps9uHdTMmxcXt/1fWpgfOD3jO4Zr0oihgwI/?= =?us-ascii?Q?T+4VW13/mx8cxbliZFaJPzBabMAYq3yfXuFidAUZYeqmqXwsZ5b/3cz9ZZRq?= =?us-ascii?Q?iYEbnWODw7zJuARrR+vVeuZnOtIIV0Qcer1Nk373G96U1Zt1MEqEbZM9wr16?= =?us-ascii?Q?cm0kUqfkfdVrojKCY2ZkpvZ4SORGdNOu92VuALbJIAVaVOR1cAkoZFvdjA6z?= =?us-ascii?Q?uGdGcuQGwtob59ABZguFnOxWX12M1FBguolnZ79ysc3Jrd6d2ZN+b/l4OA4Y?= =?us-ascii?Q?UJeWy3wzudDOU8J0qn0FYWxtHzQ5uFGUjByVMPHwwNQvTbgT4JuKfRxTZtvn?= =?us-ascii?Q?0/T9WoBVYEaTAtu+1wpAYQEWBzYljcbx4nmahzvz+Uy2D01dnHTWPA7THhXz?= =?us-ascii?Q?Kw1RnYP6CbwFaxgcCX5P4cuRQhgPYtFYe+mb1PryRH3opl5ZPw7IofXNJ/+C?= =?us-ascii?Q?j+gGKTjgKLKV8jbYFrSzlaE8UzzRL5KsbjnaW+mgdKV5kAqJVgsamQd4AKgc?= =?us-ascii?Q?J9mJx9WPPxjBh/DCYFUNH49gfHUjJ1OKo/1pDtVeBDqe5e0uMhHmVkmerWDI?= =?us-ascii?Q?e56erdI1wsPRJm6m3OuN5hSgH1Tzca3j/ucSoXr7uktYeWGhoajuM8OYXkQT?= =?us-ascii?Q?NQ7NR0xg9sF7HIMOwI7tybuF9zURNMxvexRuHkkqnTl7V5WQD+zhNmBxG0JV?= =?us-ascii?Q?6vDHyQ7vfKyYiWGG7ZuyT184Vv8CNeSpzwn0gPA7qRZjgItvkE0Kf0fgqIDZ?= =?us-ascii?Q?qkG0lXGm0SJbAMkN2VWfgTIRH2gn2423QA7FlOmoyvxIZlJzFq92cYKZWBVD?= =?us-ascii?Q?p3k+6+PfoGNdQQzIBhr97Pe1PKPTUc+l8HxkiHOPQekyEZfsdpP2JM/b2Bf9?= =?us-ascii?Q?W4GxHcK2RDJ6M1wPJQYghwbmBfUTe1XR/Ep1tWKFNT9wKuKsf+/bWdh7Nxuw?= =?us-ascii?Q?nKGC8DxqggCQeqjcHw+3wgnCOTxsVHXVcz/IsfyD2BooYsnhMN/BsxA5S/bU?= =?us-ascii?Q?GQ64bwHkdSc3Gj4rziBcMoM3GWhAWtqYLxD8vBIP5q41u48TYnU7rXLbzVFC?= =?us-ascii?Q?kHh9QrkdvW7dSGxZ7tUtZg+oABDEk4iuAO7E7/GANLSsTxmddpEnczM0WHeV?= =?us-ascii?Q?L5fHCKlJYQyAt711SUlV09gv5NhGjfDS4mK1woRfIibYDtcnhoPC2+biDFNq?= =?us-ascii?Q?jVM2sJlTHyP2UE7BrhhS9fvfuY7mNpkE/LcjUyGFFjRAW/gwn5pGqR2aMuGj?= =?us-ascii?Q?lm++4JJF7O3IYuNvb5No8r0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79bbe9fe-845f-45d8-b3c4-08da002524e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2022 10:27:55.7451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: us9/t/R5Uk0uWB+PsLt8LMQ9xAwV7ixh1OlN7XOC9PUtSe1YNAYKG0MtFr1c3XlvK6b2UAfIu4+ThjZgQqrd1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3070 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, > -----Original Message----- > From: Jiawei(Jonny) Wang > Sent: Wednesday, March 2, 2022 5:31 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Yongseok Koh > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchd= ev > mode >=20 > When E-Switch mode was enabled, the NIC egress flows was implicitly > appended with source vport to match on. If the metadata register C0 > was used to maintain the source vport, it was initialized to zero > on packet steering engine entry, the flow could be hit only > if source vport was zero, the register C0 of the packet was not correct > to match in the TX side, this caused egress flow misses. >=20 > This patch: > - removes the implicit source vport match for NIC egress flow. > - rejects the NIC egress flows on the representor ports at validation. > - allows the internal NIC egress flows containing the TX_QUEUE items in > order to not impact hairpins. >=20 > Fixes: ce777b147bf8 ("net/mlx5: fix E-Switch flow without port item") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > Acked-by: Ori Kam > --- > v4: rebase > v3: update the tx_item checking > v2: fix one typo Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh