Re: [dpdk-stable] [PATCH] validation-contacts: add validation-contacts file

Re: [dpdk-stable] [PATCH] validation-contacts: add validation-contacts file

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, September 12, 2019 9:28 PM
> To: stable@dpdk.org; bluca@debian.org; thomas@monjalon.net
> Cc: Kevin Traynor <ktraynor@redhat.com>; Akhil Goyal <akhil.goyal@nxp.com>;
> Ali Alnubani <alialnu@mellanox.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian
> Stokes <ian.stokes@intel.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-
> Hyoung Lee <juhlee@microsoft.com>; Pei Zhang <pezhang@redhat.com>;
> yuan.peng@intel.com; Raslan Darawsheh <rasland@mellanox.com>;
> benjamin.walker@intel.com; qian.q.xu@intel.com
> Subject: [EXT] [PATCH] validation-contacts: add validation-contacts file
> 
> Add file with list of people who are involved in validation
> of LTS/stable releases. This is used by 4-final-review to add
> these people to the mail announcing new Release Candidates.
> 
> It can also be used as a list of contacts to highlight any other
> relevant items, like test reports etc.
> 
> Cc: Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Ali Alnubani <alialnu@mellanox.com>
> Cc: David Christensen <drc@linux.vnet.ibm.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: Ian Stokes <ian.stokes@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: John McNamara <john.mcnamara@intel.com>
> Cc: Ju-Hyoung Lee <juhlee@microsoft.com>
> Cc: Kevin Traynor <ktraynor@redhat.com>
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: Pei Zhang <pezhang@redhat.com>
> Cc: yuan.peng@intel.com
> Cc: Raslan Darawsheh <rasland@mellanox.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Cc: benjamin.walker@intel.com
> Cc: qian.q.xu@intel.com
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>


>  At this point the vendors who have commited to test the release should do
> diff --git a/validation-contacts b/validation-contacts
> new file mode 100644
> index 0000000..16af54f
> --- /dev/null
> +++ b/validation-contacts
> @@ -0,0 +1,16 @@
> +Pei Zhang <pezhang@redhat.com>
> +Raslan Darawsheh <rasland@mellanox.com>
> +qian.q.xu@intel.com
> +Ju-Hyoung Lee <juhlee@microsoft.com>
> +Ian Stokes <ian.stokes@intel.com>
> +Ali Alnubani <alialnu@mellanox.com>
> +David Christensen <drc@linux.vnet.ibm.com>
> +benjamin.walker@intel.com
> +Thomas Monjalon <thomas@monjalon.net>
> +John McNamara <john.mcnamara@intel.com>
> +Luca Boccassi <bluca@debian.org>
> +Jerin Jacob Kollanukkaran <jerinj@marvell.com>

I would like to change to:

Jerin Jacob <jerinj@marvell.com>


> +Hemant Agrawal <hemant.agrawal@nxp.com>
> +Akhil Goyal <akhil.goyal@nxp.com>
> +Kevin Traynor <ktraynor@redhat.com>
> +yuan.peng@intel.com
> --
> 2.20.1

Re: [dpdk-stable] [PATCH] validation-contacts: add validation-contacts file

[Kevin Traynor]

On 12/09/2019 17:28, Jerin Jacob Kollanukkaran wrote:
> 
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Thursday, September 12, 2019 9:28 PM
>> To: stable@dpdk.org; bluca@debian.org; thomas@monjalon.net
>> Cc: Kevin Traynor <ktraynor@redhat.com>; Akhil Goyal <akhil.goyal@nxp.com>;
>> Ali Alnubani <alialnu@mellanox.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian
>> Stokes <ian.stokes@intel.com>; Jerin Jacob Kollanukkaran
>> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-
>> Hyoung Lee <juhlee@microsoft.com>; Pei Zhang <pezhang@redhat.com>;
>> yuan.peng@intel.com; Raslan Darawsheh <rasland@mellanox.com>;
>> benjamin.walker@intel.com; qian.q.xu@intel.com
>> Subject: [EXT] [PATCH] validation-contacts: add validation-contacts file
>>
>> Add file with list of people who are involved in validation
>> of LTS/stable releases. This is used by 4-final-review to add
>> these people to the mail announcing new Release Candidates.
>>
>> It can also be used as a list of contacts to highlight any other
>> relevant items, like test reports etc.
>>
>> Cc: Akhil Goyal <akhil.goyal@nxp.com>
>> Cc: Ali Alnubani <alialnu@mellanox.com>
>> Cc: David Christensen <drc@linux.vnet.ibm.com>
>> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Cc: Ian Stokes <ian.stokes@intel.com>
>> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>> Cc: John McNamara <john.mcnamara@intel.com>
>> Cc: Ju-Hyoung Lee <juhlee@microsoft.com>
>> Cc: Kevin Traynor <ktraynor@redhat.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Pei Zhang <pezhang@redhat.com>
>> Cc: yuan.peng@intel.com
>> Cc: Raslan Darawsheh <rasland@mellanox.com>
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> Cc: benjamin.walker@intel.com
>> Cc: qian.q.xu@intel.com
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> 
>>  At this point the vendors who have commited to test the release should do
>> diff --git a/validation-contacts b/validation-contacts
>> new file mode 100644
>> index 0000000..16af54f
>> --- /dev/null
>> +++ b/validation-contacts
>> @@ -0,0 +1,16 @@
>> +Pei Zhang <pezhang@redhat.com>
>> +Raslan Darawsheh <rasland@mellanox.com>
>> +qian.q.xu@intel.com
>> +Ju-Hyoung Lee <juhlee@microsoft.com>
>> +Ian Stokes <ian.stokes@intel.com>
>> +Ali Alnubani <alialnu@mellanox.com>
>> +David Christensen <drc@linux.vnet.ibm.com>
>> +benjamin.walker@intel.com
>> +Thomas Monjalon <thomas@monjalon.net>
>> +John McNamara <john.mcnamara@intel.com>
>> +Luca Boccassi <bluca@debian.org>
>> +Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> 
> I would like to change to:
> 
> Jerin Jacob <jerinj@marvell.com>
> 

Sure, thanks Jerin. Will give others some time to reply and then send a v2.

> 
>> +Hemant Agrawal <hemant.agrawal@nxp.com>
>> +Akhil Goyal <akhil.goyal@nxp.com>
>> +Kevin Traynor <ktraynor@redhat.com>
>> +yuan.peng@intel.com
>> --
>> 2.20.1
> 

Re: [dpdk-stable] [PATCH] validation-contacts: add validation-contacts file

[Luca Boccassi]

On Thu, 2019-09-12 at 16:57 +0100, Kevin Traynor wrote:
> Add file with list of people who are involved in validation
> of LTS/stable releases. This is used by 4-final-review to add
> these people to the mail announcing new Release Candidates.
> 
> It can also be used as a list of contacts to highlight any other
> relevant items, like test reports etc.
> 
> Cc: Akhil Goyal <
> akhil.goyal@nxp.com
> >
> Cc: Ali Alnubani <
> alialnu@mellanox.com
> >
> Cc: David Christensen <
> drc@linux.vnet.ibm.com
> >
> Cc: Hemant Agrawal <
> hemant.agrawal@nxp.com
> >
> Cc: Ian Stokes <
> ian.stokes@intel.com
> >
> Cc: Jerin Jacob Kollanukkaran <
> jerinj@marvell.com
> >
> Cc: John McNamara <
> john.mcnamara@intel.com
> >
> Cc: Ju-Hyoung Lee <
> juhlee@microsoft.com
> >
> Cc: Kevin Traynor <
> ktraynor@redhat.com
> >
> Cc: Luca Boccassi <
> bluca@debian.org
> >
> Cc: Pei Zhang <
> pezhang@redhat.com
> >
> Cc: 
> yuan.peng@intel.com
> 
> Cc: Raslan Darawsheh <
> rasland@mellanox.com
> >
> Cc: Thomas Monjalon <
> thomas@monjalon.net
> >
> Cc: 
> benjamin.walker@intel.com
> 
> Cc: 
> qian.q.xu@intel.com
> 
> Signed-off-by: Kevin Traynor <
> ktraynor@redhat.com
> >
> 
> ---
> 
> Please note, I compiled this list from correspondances during stable
> releases and discussions at the DPDK Release meeting. It is expected
> to
> be very low traffic. If anyone wants to be removed/added please
> reply.

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

[dpdk-stable] [PATCH] validation-contacts: add validation-contacts file

[Kevin Traynor]

Add file with list of people who are involved in validation
of LTS/stable releases. This is used by 4-final-review to add
these people to the mail announcing new Release Candidates.

It can also be used as a list of contacts to highlight any other
relevant items, like test reports etc.

Cc: Akhil Goyal <akhil.goyal@nxp.com>
Cc: Ali Alnubani <alialnu@mellanox.com>
Cc: David Christensen <drc@linux.vnet.ibm.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Ian Stokes <ian.stokes@intel.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: John McNamara <john.mcnamara@intel.com>
Cc: Ju-Hyoung Lee <juhlee@microsoft.com>
Cc: Kevin Traynor <ktraynor@redhat.com>
Cc: Luca Boccassi <bluca@debian.org>
Cc: Pei Zhang <pezhang@redhat.com>
Cc: yuan.peng@intel.com
Cc: Raslan Darawsheh <rasland@mellanox.com>
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: benjamin.walker@intel.com
Cc: qian.q.xu@intel.com
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

---

Please note, I compiled this list from correspondances during stable
releases and discussions at the DPDK Release meeting. It is expected to
be very low traffic. If anyone wants to be removed/added please reply.
---
 4-final-review      | 17 ++++++++++++++---
 README              |  4 +++-
 validation-contacts | 16 ++++++++++++++++
 3 files changed, 33 insertions(+), 4 deletions(-)
 create mode 100644 validation-contacts

diff --git a/4-final-review b/4-final-review
index 387bce9..5041564 100755
--- a/4-final-review
+++ b/4-final-review
@@ -49,10 +49,21 @@ get_shortlog()
 }
 
+get_cc_val_list()
+{
+	cc_val_list="./validation-contacts"
+	while read line; do
+		echo "Cc: $line"
+	done <<< "$(cat $cc_val_list | sort | uniq)"
+
+}
+
 compose_final_review_note()
 {
+echo "Subject: $(describe_release) patches review and test"
+echo "To: stable@dpdk.org"
+echo "Cc: dev@dpdk.org"
+get_cc_val_list
+
 	cat << EOF
-Subject: $(describe_release) patches review and test
-To: dpdk stable <stable@dpdk.org>
-Cc: dev@dpdk.org
 
 Hi all,
diff --git a/README b/README
index 5eaefd2..4252285 100644
--- a/README
+++ b/README
@@ -122,5 +122,7 @@ but also have links to the tarballs.
 The usage is simple, just time the command, it then will generate an
 email with the notification content. What you need to so it to edit it
-when necessary (say, leaving more time for review) and send it out.
+when necessary (say, leaving more time for review) and send it out. The
+Cc list will be populated with people who are involved in stable release
+validation and listed in the validation-contacts file.
 
 At this point the vendors who have commited to test the release should do
diff --git a/validation-contacts b/validation-contacts
new file mode 100644
index 0000000..16af54f
--- /dev/null
+++ b/validation-contacts
@@ -0,0 +1,16 @@
+Pei Zhang <pezhang@redhat.com>
+Raslan Darawsheh <rasland@mellanox.com>
+qian.q.xu@intel.com
+Ju-Hyoung Lee <juhlee@microsoft.com>
+Ian Stokes <ian.stokes@intel.com>
+Ali Alnubani <alialnu@mellanox.com>
+David Christensen <drc@linux.vnet.ibm.com>
+benjamin.walker@intel.com
+Thomas Monjalon <thomas@monjalon.net>
+John McNamara <john.mcnamara@intel.com>
+Luca Boccassi <bluca@debian.org>
+Jerin Jacob Kollanukkaran <jerinj@marvell.com>
+Hemant Agrawal <hemant.agrawal@nxp.com>
+Akhil Goyal <akhil.goyal@nxp.com>
+Kevin Traynor <ktraynor@redhat.com>
+yuan.peng@intel.com
-- 
2.20.1