From: Shahed Shaikh <shshaikh@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Rasesh Mody <rmody@marvell.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode
Date: Wed, 4 Sep 2019 17:52:11 +0000 [thread overview]
Message-ID: <BYAPR18MB26969055B1BBB85376BA6715D3B80@BYAPR18MB2696.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BYAPR18MB242498321D1A2CD70DBD219FC8B80@BYAPR18MB2424.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Sent: Wednesday, September 4, 2019 7:01 PM
> To: Shahed Shaikh <shshaikh@marvell.com>; dev@dpdk.org
> Cc: Rasesh Mody <rmody@marvell.com>; ferruh.yigit@intel.com; GR-Everest-
> DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using
> odd number of queues on 100Gb mode
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Shahed Shaikh
> > Sent: Wednesday, September 4, 2019 5:01 PM
> > To: dev@dpdk.org
> > Cc: Rasesh Mody <rmody@marvell.com>; ferruh.yigit@intel.com; GR-
> > Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when
> > using odd number of queues on 100Gb mode
> >
> > As per HW design of 100Gb mode, device internally uses 2 engines
> > (eng0 and eng1), and both engines need to be configured symmetrically.
> > Based on this requirement, driver design chose an approach to allow
> > user to allocate only even number of queues and split those queues on
> > both engines equally.
> >
> > This approach puts a limitation on number of queues to be allocated - i.e.
> > user can't configure odd number of queues on 100Gb mode.
> > OVS configures DPDK port with 1 rxq and 1 txq, which causes
> > initialization of qede port to fail.
> >
> > This patch changes the implementation of queue allocation method for
> > 100Gb devices by removing above mentioned limitation and allowing user
> > to configure odd number of queues.
> >
> > Key changes in this patch -
> > - Allocate requested queue count on both engines, so that
> > actual hardware queue count will be double of what user requested.
> > - Create a pair of queues from both engines and provide it to
> > rte_ethdev queue structure. So ethdev will see only one queue for
> > underlying queue pair created for hw engine pair.
> > - Rx and Tx methods from ethdev will provide that queue pair
> > object and PMD will internally split Rx and Tx packet processing across
> > both engines in separately installed Rx and Tx handlers.
> > - Consolidate statistics of both HW queues while reporting to application.
> > - Report engine wise queue statistics in xstats flow.
> > e.g. - rx_q<hw_eng_id>.<qid>_xxxxxxx
>
>
> Multiple logical changes in one patch. Please split the patch to more logical ones
> for easy review.
Hi Jerin,
Sure, let me split this patch into logical patches.
>
>
> >
> > Fixes: 2af14ca79c0a ("net/qede: support 100G")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
prev parent reply other threads:[~2019-09-04 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 11:30 [dpdk-stable] " Shahed Shaikh
2019-09-04 13:30 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-09-04 17:52 ` Shahed Shaikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB26969055B1BBB85376BA6715D3B80@BYAPR18MB2696.namprd18.prod.outlook.com \
--to=shshaikh@marvell.com \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).