From: Shahed Shaikh <shshaikh@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
Rasesh Mody <rmody@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler
Date: Mon, 1 Jul 2019 09:15:08 +0000 [thread overview]
Message-ID: <BYAPR18MB2696D4E846B9CA3F966150ABD3F90@BYAPR18MB2696.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xkN0+P1RKKZwuCukymQVdYw6RGxUMkppc2_OT+Qk+EZQ@mail.gmail.com>
>From: David Marchand <david.marchand@redhat.com>
>Sent: Wednesday, June 26, 2019 1:07 PM
>To: Rasesh Mody <rmody@marvell.com>
>Cc: dev@dpdk.org; stable@dpdk.org; Shahed Shaikh <shshaikh@marvell.com>
>Subject: Re: [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler
>On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody <mailto:rmody@marvell.com> wrote:
>>From: David Marchand <mailto:david.marchand@redhat.com>
>>Sent: Tuesday, June 25, 2019 6:39 AM
>>
>>----------------------------------------------------------------------
>>rte_intr_enable/rte_intr_disable configure the interrupt context on the
>>kernel side (either uio or vfio).
>>In VFIO case, calling it from the interrupt handlers triggers an unneeded
>>interrupt handlers reconfiguration.
>>During this reconfiguration window, the device can trigger interrupts which
>>are left unserviced.
>>
>>Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824
>>Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode")
>>Fixes: 2ea6f76aff40 ("qede: add core driver")
>>Cc: mailto:stable@dpdk.org
>>
>>Signed-off-by: David Marchand <mailto:david.marchand@redhat.com>
>>---
>Change looks good, thanks.
>Acked-by: Rasesh Mody <mailto:rmody@marvell.com>
>Something still bothers me about the meaning of rte_intr_enable()...
>Let me write a mail to a little more people :-)
>For now, let's put this patch on hold.
Another question I have is, is it required to re-enable interrupt by PMD at the end of interrupt handling by calling rte_intr_enable()?
Does DPDK core / vfio/uio module take care of re-enabling the interrupt after the interrupt is handled?
Thanks,
Shahed
next prev parent reply other threads:[~2019-07-01 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:38 [dpdk-stable] " David Marchand
2019-06-25 22:50 ` [dpdk-stable] [EXT] " Rasesh Mody
2019-06-26 7:37 ` David Marchand
2019-07-01 9:15 ` Shahed Shaikh [this message]
2019-07-01 9:24 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2696D4E846B9CA3F966150ABD3F90@BYAPR18MB2696.namprd18.prod.outlook.com \
--to=shshaikh@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).