* [dpdk-stable] [PATCH] net/mlx5: fix flow priority on queue action
@ 2018-01-31 16:13 Nelio Laranjeiro
2018-02-01 1:41 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2018-01-31 16:13 UTC (permalink / raw)
To: dev; +Cc: Adrien Mazarguil, Shahaf Shuler, Yongseok Koh, stable
A single queue should have the same verbs priority as an RSS one.
Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_flow.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 2360b0ee5..1ca2037ad 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -871,7 +871,7 @@ priv_flow_convert_items_validate(struct priv *priv,
}
parser->inner = IBV_FLOW_SPEC_INNER;
}
- if (parser->drop || parser->queues_n == 1) {
+ if (parser->drop) {
parser->queue[HASH_RXQ_ETH].offset += cur_item->dst_sz;
} else {
for (n = 0; n != hash_rxq_init_n; ++n)
@@ -1107,7 +1107,7 @@ priv_flow_convert(struct priv *priv,
* Second step.
* Allocate the memory space to store verbs specifications.
*/
- if (parser->drop || parser->queues_n == 1) {
+ if (parser->drop) {
unsigned int priority =
attr->priority +
hash_rxq_init[HASH_RXQ_ETH].flow_priority;
@@ -1172,14 +1172,9 @@ priv_flow_convert(struct priv *priv,
* Last step. Complete missing specification to reach the RSS
* configuration.
*/
- if (parser->queues_n > 1) {
+ if (!parser->drop) {
priv_flow_convert_finalise(priv, parser);
} else {
- /*
- * Action queue have their priority overridden with
- * Ethernet priority, this priority needs to be adjusted to
- * their most specific layer priority.
- */
parser->queue[HASH_RXQ_ETH].ibv_attr->priority =
attr->priority +
hash_rxq_init[parser->layer].flow_priority;
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix flow priority on queue action
2018-01-31 16:13 [dpdk-stable] [PATCH] net/mlx5: fix flow priority on queue action Nelio Laranjeiro
@ 2018-02-01 1:41 ` Yongseok Koh
2018-02-01 12:52 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-02-01 1:41 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, Shahaf Shuler, stable
> On Jan 31, 2018, at 8:13 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> A single queue should have the same verbs priority as an RSS one.
>
> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix flow priority on queue action
2018-02-01 1:41 ` Yongseok Koh
@ 2018-02-01 12:52 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-02-01 12:52 UTC (permalink / raw)
To: Yongseok Koh, Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil, stable
Thursday, February 1, 2018 3:42 AM, Yongseok Koh:
> > On Jan 31, 2018, at 8:13 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> wrote:
> >
> > A single queue should have the same verbs priority as an RSS one.
> >
> > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx. Thanks.
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-01 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 16:13 [dpdk-stable] [PATCH] net/mlx5: fix flow priority on queue action Nelio Laranjeiro
2018-02-01 1:41 ` Yongseok Koh
2018-02-01 12:52 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).