From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40055.outbound.protection.outlook.com [40.107.4.55]) by dpdk.org (Postfix) with ESMTP id 9584B2082; Tue, 6 Nov 2018 22:30:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oR00vejSvRT4l+PrvcVJEnj6h3uy8pi1Z/OlWOW6py0=; b=EBveHGkVSUzndDV/db0CAGNU+12uktFSIOXWfslpy7J+Q+kV/wnrVGe+70LqdYFL3zsEutZKNyVuySMIdIc4ug0plwAMn2BNEGHxVpK4H5ILxuxsxLncPfFnIOUGmbfEdxxZsvy1AjCnd3tIR3hxLYHeDOzAe1ag4zhMgGyDBQg= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Tue, 6 Nov 2018 21:30:13 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::58e7:97d8:f9c1:4323]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::58e7:97d8:f9c1:4323%3]) with mapi id 15.20.1294.032; Tue, 6 Nov 2018 21:30:13 +0000 From: Yongseok Koh To: "Wiles, Keith" CC: Thomas Monjalon , "Richardson, Bruce" , "Yigit, Ferruh" , "dev@dpdk.org" , Shahaf Shuler , "Ananyev, Konstantin" , "Burakov, Anatoly" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] build: disable compiler AVX512F support Thread-Index: AQHUcu+WK09O3nLQfUKZoE958YxG+aVBO6uAgAIOQgA= Date: Tue, 6 Nov 2018 21:30:13 +0000 Message-ID: References: <20181023212318.43082-1-yskoh@mellanox.com> <20181102210348.28148-1-yskoh@mellanox.com> <7879265D-9280-47ED-8987-A332C0A3DBF9@intel.com> In-Reply-To: <7879265D-9280-47ED-8987-A332C0A3DBF9@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3995; 6:Q/JYftYJyDMxqb/rfgVm9Wt/rJRXGwNXQe0CG2kGT2nGz0blSosVqv7haoqfU7SSJUOuMwB74D+YVhEW2qKVohfFbZv7Q5G+XJn6rE9rt58OflnjQkwjAGxacjBtKSFLtiZ/81iZC8kLqCkF81oANN/KkSPkgvPJmWnJYUbm76raHdb2tG6orm1dJvK9FVJPEB1cL9YB6gcltugIE9l0jr16fPQYPaiu46uhhvQsz2TOLLydFPG7nUWZEg8rEsK7D639DP7+N2RCpkH+jNITdOKEUZbDlJ2yipqBZEhkSmMH2WGsRN6HWbklbWqK+XUksvluADyQyOKKKVfDigQ6ebVB4qcwMc3RVGxu6sXKhE0bXFppgwrwQkWkbTHJ5V6SeY0xdw61E8pbmWJvDOo9QUr7NRrct6SXnDobywcD9GKpui5kP3g6iC7cXZ3SK2VcNKde7xaxxPxhkvSEa0/vdA==; 5:SGpyWwJ4IpCwvCekKqKP3GuWLnJCDjy9J8RywsAX/oK1m8dcouX1P6eiowcoTCWo5GLSibvbVZs6VppnxNVDQzABSaj8odiInpPm8rhtwFVYVTRWDohYFF+aY/9FU51LJaP7nhTY7fKJBl2rhxYcKCqoWjoxSUKqHXj6S9YuRsk=; 7:iCVf68b/NtHFgd/4oF89UpVY+RbvLgXhhCjG2HnHIpLVnVbgGGBaAz1ZXtVXt41qjmtN8G1xb+kg7wtpFmAzzJMyardEvzbGcncTVZNGc29Ntn+wD4b/aE9QYocOedxusbaqE9a9pMPchZFKNt+qhw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: a25b7878-0e99-4142-7fa5-08d6442f0962 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB3995; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3995; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(376002)(136003)(366004)(199004)(189003)(8676002)(83716004)(71200400001)(71190400001)(81156014)(6512007)(5660300001)(6246003)(575784001)(6486002)(86362001)(68736007)(6436002)(54906003)(256004)(229853002)(478600001)(14444005)(11346002)(446003)(36756003)(82746002)(316002)(3846002)(6116002)(7736002)(106356001)(476003)(305945005)(2616005)(97736004)(186003)(25786009)(53936002)(76176011)(14454004)(105586002)(6506007)(102836004)(486006)(33656002)(53546011)(8936002)(6916009)(2900100001)(81166006)(4326008)(66066001)(2906002)(26005)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fw0qzR3VwyO372u9PDYsWDtw046yEBohyonmYbqk3iGkPM6209dfCT/WraamZtB+TF578ELLPGz6xakLM2Cvjgz5XaDXryngKloUNBLkBRIgIK0wDoKfJiiCyvCKKO1xTnuNDkhl66P1ahyvzXCNGCQhdH+9QA8+kFwq3NgkPg2iAUtiE2fg1eWtil9ZA12K4737S7i47nDfT2s9Jtu1q2Idubm0OE0lSUpO4IeU2LE4D6q8GDkEf7TyzGVFkn4ITvYoEwORPIykUUk1/96eDC7PH1EdaZPV2uHxMGEwVJAH0fcvV42rVhF3ahIhei1d5bH2K2ojOo+QQaCZYiBJKQ0eT/igei9NjMyrydjwGSY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a25b7878-0e99-4142-7fa5-08d6442f0962 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2018 21:30:13.0011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] build: disable compiler AVX512F support X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 21:30:15 -0000 > On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote: >=20 >=20 >=20 >> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote: >>=20 >> This is a workaround to prevent a crash, which might be caused by >> optimization of newer gcc (7.3.0) on Intel Skylake. >=20 > Should the code below not also test for the gcc version and the Sky Lake = processor, maybe I am wrong but it seems it is turning AVX512 for all GCC b= uilds I didn't want to check gcc version as 7.3.0 is very new. Only gcc 8 is newl= y up since then (gcc 8.2). Also, I wasn't able to test every gcc versions and I wanted to be a bit con= servative for this crash. Performance drop (if any) by disabling a new (experimental) feature would b= e less risky than unaccountable crash. And, it does disable the feature only if CONFIG_RTE_ENABLE_AVX512=3Dn. Plea= se refer to v3. >=20 > Also bug 97 seems a bit obscure reference, maybe you know the bug report,= but more details would be good? I sent out the report to dev list two month ago. And I created the Bug 97 i= n order to reference it in the commit message. I didn't want to repeat same message here and there, but it would've been b= etter to have some sort of summary of the Bug, although v3 has a few more w= ords. However, v3 has been merged. Thanks, Yongseok >>=20 >> Bugzilla ID: 97 >>=20 >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Yongseok Koh >> --- >>=20 >> v2: >> * disable the flag only in case of gcc >>=20 >> config/x86/meson.build | 5 +++++ >> mk/rte.cpuflags.mk | 7 +++++++ >> 2 files changed, 12 insertions(+) >>=20 >> diff --git a/config/x86/meson.build b/config/x86/meson.build >> index 33efb5e547..8ddca0ea9f 100644 >> --- a/config/x86/meson.build >> +++ b/config/x86/meson.build >> @@ -47,6 +47,11 @@ endif >> if cc.get_define('__AVX512F__', args: march_opt) !=3D '' >> dpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX512F', 1) >> compile_time_cpuflags +=3D ['RTE_CPUFLAG_AVX512F'] >> +else >> +# disable AVX512F support of gcc as a workaround for Bug 97 >> + if cc.get_id() =3D=3D 'gcc' and cc.has_argument('-mavx512f') >> + machine_args +=3D '-mno-avx512f' >> + endif >> endif >>=20 >> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) >> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk >> index 43ed84155b..a8c26fb011 100644 >> --- a/mk/rte.cpuflags.mk >> +++ b/mk/rte.cpuflags.mk >> @@ -68,6 +68,13 @@ endif >> ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) >> ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) >> CPUFLAGS +=3D AVX512F >> +else >> +# disable AVX512F support of gcc as a workaround for Bug 97 >> +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) >> + ifeq ($(shell $(CC) --target-help | grep -q mavx512f && echo 1), 1) >> + MACHINE_CFLAGS +=3D -mno-avx512f >> + endif >> +endif >> endif >> endif >>=20 >> --=20 >> 2.11.0 >>=20 >=20 > Regards, > Keith