From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50073.outbound.protection.outlook.com [40.107.5.73]) by dpdk.org (Postfix) with ESMTP id DE63156A3 for ; Fri, 27 Jul 2018 19:32:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XLedfBLoN2afH3BgrRAwFXx/GMRHi14ebWMyvPR3Tcc=; b=yjtCH7UHJMUyF29ZCKyLXFYEDRXbd9dvN9ZnY5WGZlHQGyYr8KjS6nGOnzUKt7a+iDjxyP3ofDXFNOL89PIAGPNRkzrmL3mxkyJVrs7C1ELlykjELsmgPzDO54GzmngOBcvbieSm9nQXH37Szefvs5XuM5Pzm/6iESbeo1YUDBc= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2781.eurprd05.prod.outlook.com (10.172.11.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Fri, 27 Jul 2018 17:32:24 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175%2]) with mapi id 15.20.0995.019; Fri, 27 Jul 2018 17:32:24 +0000 From: Yongseok Koh To: Kevin Traynor , Ilya Maximets CC: dpdk stable , Luca Boccassi , Maxime Coquelin , Peng He , Tiwei Bie Thread-Topic: [dpdk-stable] please help backporting some patches to LTS release 17.11.4 Thread-Index: AQHUJVM2wcE8iTIRXE+5C/NvLLSNWKSisCyAgACSLoCAAAXbAIAACl6AgAACUwA= Date: Fri, 27 Jul 2018 17:32:24 +0000 Message-ID: References: <20180727024008.39497-1-yskoh@mellanox.com> <20180727074215eucas1p19e45258ec15a10881b3006b70723c3f2~FKeqOKwSp3270732707eucas1p1b@eucas1p1.samsung.com> <80ad5117-ceb1-7d59-0e12-96f4ab4ed90d@redhat.com> <20180727164624eucas1p1d04b8c165d9690781a1d99623cc28510~FR5wyolb60227802278eucas1p1K@eucas1p1.samsung.com> <2cd45823-15fc-2a9a-860f-7b50db0ab241@redhat.com> In-Reply-To: <2cd45823-15fc-2a9a-860f-7b50db0ab241@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2781; 6:qImAJdOVst9lGOuWkrfqOTbJ/FJ3nxlzMfJZ6//+/qEZTkmVCaI88nBKygsh55fYK1BTv/bOATnL2aL2TRCUgsSz5O5brCTTyd+Y3mDR06qAXG1vAXgLN1il028kXIKkh2o5r1OVz4eACB7BpRaNmwbCoTNrb/FpSHN9nWMx/SKqW33Y7kAqexlVs3v592mc8jKj3fFDYAacgPCEvCKfn2jOaJqUaEzXRiw2EnFaE/KBPphZhR764KbEZBEJ3isez7a1gsGvRjGgdaANsK5K0nG989c9Rmr7ZKGrzaqnX32BCIgdZz41EWVRxsp7DREOOdGyFdM/1n41T5I3h3rs71dt7O1oSCXIqpXY1MYtHxuEBX9905pTDtJFtKDnNjaQPA0gV8/4qu7drnkZ4zS1hHpGqXwHCvZvbn5edcmqRqtU5zhvG9E9Q4X/FSh/UlzFe/7WGnpyB0u8A6lyavix/A==; 5:tiLBp4jI4yUG0Lgbw4hEl8iSnRHplS5YhB0xhSzyW8daesidImngW6mLWWIOfpAOQr9iVQWnwgYdZ/HK+Jqmdm30a5w1lPNUJuzxdisDUF/KwlMhkIrc5WMIijM+IOSx9QB8iw+iA5j4RfSg62P1/1b9BSlnozRLnHUog+JVG/c=; 7:dn6HSbo77eE6cq8B1JhJu7SMlQzfkBLgllGglB6TyQVJcvi6cAX4FenrsNsMZcUzL+U0552vLckUHl74uW5FZtc5JpOAUJyIG6T39mXjhlzKWGYOsxEvMVjZsE2C9QCko+9maj+nqH3S3861GbZ1xq9T0OdqkaF1DhjGldgHhKPfL9hlYltR3QzJiT3Qnrqh3BxpHLwNPP9vs3ZCXjl5LpCMP1aCWPVlh7ixyzUyIoA6ShOWHaQXN+CiKHVRtk8C x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6e096fb0-1fbc-4366-b055-08d5f3e6ea57 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2781; x-ms-traffictypediagnostic: VI1PR0501MB2781: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2781; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2781; x-forefront-prvs: 07467C4D33 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(136003)(39860400002)(199004)(189003)(28163001)(69234005)(66066001)(256004)(966005)(316002)(2906002)(6306002)(6512007)(83716003)(5250100002)(7736002)(81166006)(229853002)(68736007)(81156014)(8676002)(11346002)(8936002)(305945005)(6436002)(105586002)(93886005)(446003)(5024004)(14444005)(2616005)(33656002)(478600001)(6486002)(45080400002)(82746002)(53936002)(6116002)(3846002)(6246003)(36756003)(106356001)(26005)(102836004)(99286004)(25786009)(575784001)(86362001)(2900100001)(39060400002)(54906003)(110136005)(486006)(186003)(97736004)(6506007)(53546011)(4326008)(476003)(14454004)(5660300001)(76176011)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2781; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: TxQ0Sy/e3md3XbOT7uZ9RIQSdpdrelzLJ2d+8SizY249v9AMGO860Zf+3x5rNW82FWs30fJfdtvfzKy3XpEgq4h3zll6HEKmB7N5OZfuPxM2WIebwjuZopNpAlmhFYJMKzqS3sbo9993UsUuaQVhIfI0+UGfTn7yshElyj8QU1ZV02n5cTCdzMfsIxkSRkJy54NXWelNEUza6bfWINJEPhpUncsWVUgWe+8jtj/LVusSm/u3937P5zNikLM0bflvKiluVc3r6T1Atbk1yEHZX8T4tmKOGQdBDkqCHDBKa8hgVVeSfMp2hG9VzdwEqxjlm0wYBksSv/AIHybiKlMZdHOtl9g1BBTCcB6YrlVgdjE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <402C8B011725304FB7AB959559F74D41@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e096fb0-1fbc-4366-b055-08d5f3e6ea57 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2018 17:32:24.1045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2781 Subject: Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 17:32:26 -0000 > On Jul 27, 2018, at 10:24 AM, Kevin Traynor wrote: >=20 > On 07/27/2018 05:46 PM, Ilya Maximets wrote: >>=20 >>=20 >> On 27.07.2018 19:25, Kevin Traynor wrote: >>> On 07/27/2018 08:42 AM, Ilya Maximets wrote: >>>> [keeping in CC only e11411b52 related persons] >>>> [CC: Luca Boccassi] >>>>=20 >>>> Hi. >>>> I beleive that I was added to this thread as a reviewer of >>>> "e11411b52 Maxime Coquelin vhost: fix missing increment of log cache= count". >>>>=20 >>>> Looking at the current dpdk-stable/17.11 I see that the patch could no= t be >>>> applied because it fixes issue introduced by another patch >>>> c16915b87109 ("vhost: improve dirty pages logging performance") that d= oesn't >>>> exist in this branch. OTOH, this patch exists in stable 16.11. >>>> So, I have a question: Is there any reason why c16915b87109 was backpo= rted >>>> to 16.11 but not to 17.11 ? >>>>=20 >>>=20 >>> Hi Ilya, Guessing it was because it was an optimization as opposed to a >>> functional fix. See below commit wrt clarifying this - ref last para. >>=20 >> Sure, I understand that. But this doesn't clarify why we have this patch= in >> 16.11 and not in 17.11. From the user point of view this means that upgr= ade >> from 16.11 LTS to 17.11 LTS will significantly slow down live-migration. >> Later upgrade to master/future-LTS will speed up it back. >>=20 >=20 > It's never too late :-) I just checked on 17.11 stable branch, > c16915b87109 applies and e11411b52 applies subsequently. Looks fine, > compile tested only. >=20 > Yongseok, do you think you could queue these for the 17.11.4 branch? Thanks, guys. The two patches have been queued for 17.11.4 successfully. To Ilya's question. I picked up candidates for 17.11.4 between v18.05 and v18.08-rc2 because 17= .11.3 should have covered up to 18.05. But c16915b87109 had been merged late in v18.05-rc6, that might be the reason it's missing in the last minute. You k= now 18.05 was a huge release :-) I'll scan v18.05-rcX..v18.05 to see if there's any more missing patches. Thanks, Yongseok >>>=20 >>> Kevin. >>>=20 >>> commit 56c7ddc1381a56612018b75a848169b917bc33fb >>> Author: Kevin Traynor >>> Date: Sat Jun 30 00:10:43 2018 +0100 >>>=20 >>> doc: add default that all fixes should be backported >>>=20 >>> Set the starting point that all commits on master branch >>> with Fixes tag should be backported to relevant stable/LTS >>> branches, and explain that the submitter may indicate it is >>> not suitable for backport. >>>=20 >>> Of course there will be exceptions that will crop up from time >>> to time that need discussion, so also add a sentence for that. >>>=20 >>> This is to ensure that there is consistency between what is >>> backported to stable/LTS branches, remove some subjectivity >>> as to what constitutes "a fix" and avoid possible conflicts >>> for future backports. >>>=20 >>> Signed-off-by: Kevin Traynor >>> Acked-by: Luca Boccassi >>> Acked-by: Aaron Conole >>> Acked-by: Thomas Monjalon >>>=20 >>>> P.S. I don't feel that I should backport e11411b52 myself, but I can d= o that >>>> if author/maintainers are too busy. Please, let me know in that ca= se. >>>> Regarding 16.11, to backport e11411b52 you only need to change the >>>> destination file,because related code placed in >>>> lib/librte_vhost/virtio_net.c instead of lib/librte_vhost/vhost.h. >>>>=20 >>>> Best regards, Ilya Maximets. >>>>=20 >>>> On 27.07.2018 05:40, Yongseok Koh wrote: >>>>> Hi commit authors (and maintainers), >>>>>=20 >>>>> I didn't manage to apply following commits from upstream to stable br= anch >>>>> 17.11: conflict happens. I'm wondering can the authors check the foll= owing >>>>> list and backport those patches belong to you? >>>>>=20 >>>>> FYI, branch 17.11 is located at tree: >>>>> git://dpdk.org/dpdk-stable >>>>>=20 >>>>> It'd be great if you could do that in one or two weeks. Also, please = add a >>>>> heading line like below before the commit log body: >>>>> [ backported from upstream commit xxx ] >>>>>=20 >>>>> Example: https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%= 3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Fcommit%2F%3Fh%3D16.07%26id%3Dc483= 1394c7d1944d8ec27d52c22997f20d19718e&data=3D02%7C01%7Cyskoh%40mellanox.= com%7C523e7982d36c4aa66f5d08d5f3e5c2fc%7Ca652971c7d2e4d9ba6a4d149256f461b%7= C0%7C0%7C636683090507046633&sdata=3DgpjXg6vj8IqDsxj9cMC01OauJpLEP114Xtb= OSGuFaic%3D&reserved=3D0 >>>>>=20 >>>>> Also please mention the target LTS in the subject line, as we have mo= re than one >>>>> at the same time, for example: >>>>>=20 >>>>> [PATCH 17.11] foo/bar: fix baz >>>>>=20 >>>>> With git send-email, this can be achieved by appending the parameter: >>>>>=20 >>>>> --subject-prefix=3D'17.11' >>>>>=20 >>>>> Please let me know if you have any comments, say, need more time, or = it's >>>>> worthless to packport it. And please send it to "stable@dpdk.org", bu= t not >>>>> "dev@dpdk.org". >>>>>=20 >>>>> Thanks. >>>>>=20 >>>>> Yongseok >>>>>=20 >>>>> --- >>>>> 422515b9a Adrien Mazarguil app/testpmd: fix crash when attaching a d= evice >>>>> 66f2ac0f8 Adrien Mazarguil net/mlx4: fix minor resource leak during = init >>>>> 0cc1fcdeb Ajit Khaparde net/bnxt: check filter type before cleari= ng it >>>>> 6a9360963 Ajit Khaparde net/bnxt: fix clear port stats >>>>> 3c2e87c10 Ajit Khaparde net/bnxt: fix close operation >>>>> 90362583e Ajit Khaparde net/bnxt: fix incorrect IO address handli= ng in Tx >>>>> 812bb2087 Andrew Rybchenko net/sfc: handle unknown L3 packet class i= n EF10 event parser >>>>> 2a4ed7233 Damjan Marion net/i40e: do not reset device info data >>>>> 64cb90f88 Fiona Trahe crypto/qat: fix checks for 3GPP algo bit = params >>>>> 2a7e3d546 Hyong Youb Kim net/enic: do not overwrite admin Tx queue= limit >>>>> e11411b52 Maxime Coquelin vhost: fix missing increment of log cache= count >>>>> 79d098921 Moti Haimovsky net/mlx5: fix build with old kernels >>>>> c44fbc7cc Nelio Laranjeiro net/mlx5: clean-up developer logs >>>>> 179c7e893 Pavan Nikhilesh mempool/octeontx: fix pool to aura mappin= g >>>>> 196e9a486 Qi Zhang eal: fix hotplug add and remove >>>>> 9f32c7e7e Rafal Kozik net/ena: change memory type >>>>> 46916aa17 Rafal Kozik net/ena: check pointer before memset >>>>> 41e59028d Rafal Kozik net/ena: set link speed as none >>>>> 3abe17195 Rahul Lakkireddy net/cxgbe: fix Rx channel map and queue t= ype >>>>> 1fc3afdf7 Rasesh Mody doc: update qede management firmware guid= e >>>>> c6dd1eb8a Rasesh Mody net/qede: fix default extended VLAN offlo= ad config >>>>> a16aef523 Rasesh Mody net/qede: fix for devargs >>>>> e46821e9f Shahaf Shuler net/mlx5: separate generic tunnel TSO fro= m the standard one >>>>> 496f15c2c Shahed Shaikh net/qede: fix incorrect link status updat= e >>>>> c7641841a Shahed Shaikh net/qede: fix unicast MAC address handlin= g in VF >>>>> 82dbef2c8 Somnath Kotur net/bnxt: revert reset of L2 filter id >>>>> 0989161b2 Tiwei Bie vhost: release locks on RARP packet failu= re >>>>> b2a4a69f7 Xiaoxin Peng net/bnxt: fix Tx with multiple mbuf