From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D531F46ECE for ; Thu, 11 Sep 2025 21:00:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA1A740655; Thu, 11 Sep 2025 21:00:59 +0200 (CEST) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by mails.dpdk.org (Postfix) with ESMTP id E7D39402C4 for ; Thu, 11 Sep 2025 21:00:57 +0200 (CEST) Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-723c971b63bso8248626d6.1 for ; Thu, 11 Sep 2025 12:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1757617257; x=1758222057; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dF8yUUbFqHyTvsTI1dJZjz/DoSUSW+YBn1T/C+ev4Zs=; b=eoixfWIHBbsYsTB52W3Z+CrZYlnuJ2UtAgTOHOOM8jlyvkxIGQa1MGAtyQQwbDCxhU IASywFn3xfFwo3BZ06tMX89qTh6P0qRvAx89s2iBAqNa6euedMIWNEG6Zuh46A+QNY1g Tby895NJ4qluiHFlOTYPJU6NK7ipFU+x/H5YMNh4OJY2InagaoK7HlZKJNQKVR/w27MS PBCyzAfxDyqCqAwRpmrFOBD9RXHHgCN95SI3Eg7EYWynZXmAOt7Qu2x2N0TBRQcDZEUx 6fQFcjJSf3ykz1zfFw1b9o0dDeh+hYUnd98aH8SzpwiX4KZmkTlrP9hiA/FPa4PDFOsi 07EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757617257; x=1758222057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dF8yUUbFqHyTvsTI1dJZjz/DoSUSW+YBn1T/C+ev4Zs=; b=Sw/rowdoteLuUx/KzxBb7LUuXsKeBHJt6GlItR0UgXYM6UEy3FmY6cTqDPtmePjiUH Tg7Xx/tIzQwN9ErrJyiYJti5U5AukWXoFjbgzGAOtm1vUlfC71Y907SbEtqzE01SsCUB KKybX3/piSV9L0Rtew16GIUETVSdN6gJyGWbr/c7g8aYdwqM6O+BpfCJmrMXxfXK9Aw6 zAJTJ1l/hagxB39vvITe1lNk3UDDjqxsDYevcf15nW8zK7Gfsb/ryI2hJLsKtrwX6VaL 0zSKiUmKu3yUVUcI9dT77SKJniEyRK+JALn1AoQ76NEpe7o8SJ8xqBL2zV2X5bD6IzD5 kZ/w== X-Forwarded-Encrypted: i=1; AJvYcCWmUViWEwWzQ1jp0yDokUbypGfqv1EFUIxu2q0BqCmo2T9A1DNkEQYMFkSldFQbtQJOUiY7fo0=@dpdk.org X-Gm-Message-State: AOJu0YxionmfWNbjpkfNdGnMC0sxQg6HJ2bRhA1EHFiNzbjVM4d/sZ9x vJhugzludSLp4ZToFdcblLzS5AfahdsSarYIsFexmW8pE9WUhrCjkmFcNlaXSTa0smNFtoqHl9O R2G2aE6bnQlZ3VA61QtPstO8P7tLN2y5C9VwZCnmwH79b94dSt/1FCf87pg== X-Gm-Gg: ASbGnctp3LZzilXi/hFUomMXHSmydyoeNIWR29SxGqkQeg2H/qDCOSiBCW1OLAZ455T HLwgO02SvcKqnZ0Qa6AEIunAG28Gyxr40vA/AwZIRAfMqcTo8DQDpoZrhmAzdM4sTL4tw+ZL1tm 4LxAUUq5uUtHwZ5gJ4v69xZ6nw8eqzx8aMoNxYJdS7rojzWAcXI+k9XV1jbScEuBef9h8OJf7v5 dEQy2MsxQXnuob75y0ggCz3mwj23Kq+e26sWEOfBjuqq2vP4Qc/t8Q9KLyFrESzBsWTEsPNvjg/ Y2A3k0w0MiIBUnJPj3HpbzsjJOJSN/s6gx/RnouQjFB9b1Sp0W2NYeropIjYQRSMoJs= X-Google-Smtp-Source: AGHT+IFK3fIkKJ/dxKD4b0ShVfBmBZZ+75njwHzW++yIl3+LYKu3h6TNathVrOtBMd4s5bumBIKJpESXN1JcDlaCkVk= X-Received: by 2002:a05:6214:b69:b0:725:29f0:c7c8 with SMTP id 6a1803df08f44-767c339a299mr6118306d6.47.1757617256762; Thu, 11 Sep 2025 12:00:56 -0700 (PDT) MIME-Version: 1.0 References: <20250910110237.460825-1-14pwcse1224@uetpeshawar.edu.pk> <20250911102501.473167-1-14pwcse1224@uetpeshawar.edu.pk> <20250911105305.5eb9c67a@hermes.local> In-Reply-To: <20250911105305.5eb9c67a@hermes.local> From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Date: Fri, 12 Sep 2025 00:00:44 +0500 X-Gm-Features: AS18NWBnPosrL0A9TdsbMpSfIJ_bjxjOXkJs338sHmQ9RGiWR2KtxjknpJ5w3KA Message-ID: Subject: Re: [PATCH v2] app/testpmd: stop secondary process fwd_lcores during primary teardown To: Stephen Hemminger Cc: Aman Singh , Anatoly Burakov , Ajit Khaparde , Lijun Ou , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, dpdk stable Content-Type: multipart/alternative; boundary="0000000000003da4f7063e8b28fa" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --0000000000003da4f7063e8b28fa Content-Type: text/plain; charset="UTF-8" Hi, On Thu, Sep 11, 2025, 22:53 Stephen Hemminger wrote: > On Thu, 11 Sep 2025 03:25:01 -0700 > Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote: > > > When the secondary process testpmd application running any fwd_engine > > and after that primary has exited will cause a crash. > > > > This patch forces secondary process forwarding lcores > > in fwd_engine to stop before the primary process exits. > > > > Fixes: a550baf24af90f ("app/testpmd: support multi-process") > > Cc: stable@dpdk.org > > > > Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> > > NAK > As you said, you did not test it on Windows, yet you added #ifdef > for Windows support. Since Windows doesn't support secondary > processes (yet) how could you. > > Adding Windows here has to wait until it can be tested. > Can you please double check the code? I have used the following macro everywhere which means the code is only targeted to Linux. #ifndef RTE_EXEC_ENV_WINDOWS I will add a newer version to if you agree to add additional comments to further clarify that the solution is only targeted for Linux. Best regards, Khadem > --0000000000003da4f7063e8b28fa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,


On Thu, Sep 11, 20= 25, 22:53 Stephen Hemminger <stephen@networkplumber.org> wrote:
On Thu, 11 Sep 2025 03:25:01 -0700
Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote= :

> When the secondary process testpmd application running any fwd_engine<= br> > and after that primary has exited will cause a crash.
>
> This patch forces secondary process forwarding lcores
> in fwd_engine to stop before the primary process exits.
>
> Fixes: a550baf24af90f ("app/testpmd: support multi-process")=
> Cc: stable@dpdk.org
>
> Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.ed= u.pk>

NAK
As you said, you did not test it on Windows, yet you added #ifdef
for Windows support. Since Windows doesn't support secondary
processes (yet) how could you.

Adding Windows here has to wait until it can be tested.
Can you please double check the code?=C2=A0
I have used the following macro everywhere which means t= he code is only targeted to Linux.=C2=A0
#ifndef RTE= _EXEC_ENV_WINDOWS

I will= add a newer version to if you agree to add additional comments to further = clarify that the solution is only targeted for Linux.=C2=A0

Best regards,=C2=A0
Khadem=C2=A0
--0000000000003da4f7063e8b28fa--