Re: [PATCH v2] app/testpmd: stop secondary process fwd_lcores during primary teardown

[Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

Hi Stephen,

On Fri, Sep 12, 2025, 04:51 Stephen Hemminger <stephen@networkplumber.org>
wrote:

>
> Ok, the Windows #ifdef was confusing me then looked more closely.
> This patch is adding a set of rings so that primary and secondary
> can communicate, the adding one command.
>
> The idea is good, but there is a better way to handle this.
> There already exists a way for primary and secondary to communicate
> through the mp service. This is used for hotplug and pdump and probably
> other things as well.
>
Yeah, agree. Testpmd have also hutplug callbacks, I have tried that too,
but it is in lower layer to call any stopping fwd_engines.

>
> The communication can be either way, for example I proposed patches
> to pdump so that primary can tell secondary to participate.
>
>
> https://patchwork.dpdk.org/project/dpdk/patch/20250814165307.12786-7-stephen@networkplumber.org/
>
> This of testpmd can be done in similar way.
> The handler in secondary should be able to act same as
> when SIGINT is received. Set the flag f_exit which will cause the main
> loop to exit.
>
> This can then happen immediately, and the proc monitor alarm function
> is only then needed to handle when primary process crashes.
>
Yeah, we can try that, my only concern is that if it can handle and stop
any numbers of secondary processes fwd_engines as the current solution can
stop.

Best regards,
Khadem

>
>
>

[-- Attachment #2: Type: text/html, Size: 2414 bytes --]