From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 282C146ECE for ; Thu, 11 Sep 2025 21:23:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0714640285; Thu, 11 Sep 2025 21:23:32 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id EEB5E402C4 for ; Thu, 11 Sep 2025 21:23:30 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8173e8effa1so72018285a.0 for ; Thu, 11 Sep 2025 12:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1757618610; x=1758223410; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HGAcZlhx9htcu80hqpKyRInabfNWddwbv5uh5jSFzck=; b=JIsVPmUqQLmXceXgoJH3tPQVeQLgir9IJxGWapKjuwNRRQ/98wmxF2mJv2UkNQgxzd TmdesLiQaE/3/ZwGY5oEcIhRMosE4dXzoYJlNly10tgFJRWdrpbeKpqPtEnS1OAxKLRX Z/oDlTpH7mTo1pcvsg3cLq0SgD/cBdXDN3UwA1Yg083MuX9UtsS6uqA7FIasumJeP8Db 9LPiHacdy/RdKG/U3soGyANnZRiy13mUCV6yl+9QaO7bhiHSn7XxnKXY8GqwDujzKdaq 8pw8v0oPbM2WiyiEMeNUcRX0kkhRjn0gvva1Ox095ZBLO4KFSSXD01EqmZ61ebNt+yoS bhTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757618610; x=1758223410; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HGAcZlhx9htcu80hqpKyRInabfNWddwbv5uh5jSFzck=; b=MVm+gVOMYVLhK3UDBOCEjOQOzfIO/+y40OvgWSe4mDubWCbvzDaKNE2ouFeEKkGYxC 9M6af77PXotc1zm4/IgYYodbNzZYeZW/S0nJNT4X4aSAyzVCdjXHoRHLL8YboOvpKOJu zolcKAFC//tcp5vd8KRqs6vnibWhlXfiUs484uszEQT4WctQkkFc/RKODAQIRmw0iIGJ f2qO0T1fbd6oiuoZ5TLYR1sCfmM7AzeekcaSTRc19UCEaioXtnU4GcyGxvmlBHMBntiF fZ2orClH/CkIdvLH/f79VsEMrx+y0BHC4BRiA4RyNz/0EobvEzAI4FvcwjA1KIHW85bF UDCQ== X-Forwarded-Encrypted: i=1; AJvYcCVw2q4sBUfswEg4dgz2YLkB+2JsYDHK9aJXW35796n9z2EJKG7XslU3sLbA6qNx4albw9vzjes=@dpdk.org X-Gm-Message-State: AOJu0YyNhlgRek6ilq1acIGenE8q+uh62yJhgazS+IgaSBP4NbD+XM5s 7eJj+j+3HbD1atkJA3++bIWDFOpc5H8+0l0L5HHnAi/7SVgIUXZHyhUOa9FpNAgOU5whO/k5jmA F3CGNTDPrUug0SQqnrXv8O74oBlceHXIMS+rsrI5BkQ== X-Gm-Gg: ASbGncsZcWjYiGbdIL3rww9+dNcmWRaxZ6dCJHlNDbJZh1R1hIK6o1qRW0iA4jvSapY b0GK8027M1zNBJg8siQKxf3nIkUMp4606s0FiuQsGPkAdwcYC+rSAhMaTt+PHalVOT7JSvdWCLa C+kHnleaIQayAHM8l+4jwObPLsja9ywxEp6r0jOeDTW54GHi6jVNBqiQTZZW1CmxKT+ZUU3jcM6 EULgYBzNOXBfu0DrKJUdIvDzRDgp9ozyRxCf4xAX2w7E4EVX0LHeQcX8kG9QXHjHiDLX9R3qIUp v59jmkk8sWF5YIEaXQONebsf2BuOLKffO1fTRzic0ts8Dw== X-Google-Smtp-Source: AGHT+IE5QyqW5iVo3Hm7k8uGzxDD88Vp7oov+6hLi3Z1oaorXjyxGqxIasGMh7e6yUyOMDqUGPIzkXEOFoTVFVx4ujE= X-Received: by 2002:a05:620a:4587:b0:803:7023:36b0 with SMTP id af79cd13be357-82402350914mr49486785a.74.1757618610034; Thu, 11 Sep 2025 12:23:30 -0700 (PDT) MIME-Version: 1.0 References: <20250910110237.460825-1-14pwcse1224@uetpeshawar.edu.pk> <20250911102501.473167-1-14pwcse1224@uetpeshawar.edu.pk> <20250911105305.5eb9c67a@hermes.local> In-Reply-To: <20250911105305.5eb9c67a@hermes.local> From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Date: Fri, 12 Sep 2025 00:23:17 +0500 X-Gm-Features: AS18NWB0iYfRO9nN4nKvL3540LmA7cTbL_71w3FSbOYx1uIrjZKiH5xqknSDCTw Message-ID: Subject: Re: [PATCH v2] app/testpmd: stop secondary process fwd_lcores during primary teardown To: Stephen Hemminger Cc: Aman Singh , Anatoly Burakov , Ajit Khaparde , Lijun Ou , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, dpdk stable , Thomas Monjalon , Bruce Richardson Content-Type: multipart/alternative; boundary="000000000000e6ea87063e8b784b" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --000000000000e6ea87063e8b784b Content-Type: text/plain; charset="UTF-8" Hi Thomas, On Thu, Sep 11, 2025, 22:53 Stephen Hemminger wrote: > On Thu, 11 Sep 2025 03:25:01 -0700 > Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote: > > > When the secondary process testpmd application running any fwd_engine > > and after that primary has exited will cause a crash. > > > > This patch forces secondary process forwarding lcores > > in fwd_engine to stop before the primary process exits. > > > > Fixes: a550baf24af90f ("app/testpmd: support multi-process") > > Cc: stable@dpdk.org > > > > Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> > > NAK > As you said, you did not test it on Windows, yet you added #ifdef > for Windows support. Since Windows doesn't support secondary > processes (yet) how could you. > > Adding Windows here has to wait until it can be tested. > Can you please check if my understanding is correct that #ifndef RTE_EXEC_ENV_WINDOWS means only Linux based systems ? I have added all the codes under this macro :) Best regards, Khadem > --000000000000e6ea87063e8b784b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Thomas,=C2=A0

On Thu, Sep 11, = 2025, 22:53 Stephen Hemminger <stephen@networkplumber.org> wrote:
On Thu, 11 Sep 2025 03:25:01 -0700
Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote= :

> When the secondary process testpmd application running any fwd_engine<= br> > and after that primary has exited will cause a crash.
>
> This patch forces secondary process forwarding lcores
> in fwd_engine to stop before the primary process exits.
>
> Fixes: a550baf24af90f ("app/testpmd: support multi-process")=
> Cc: stable@dpdk.org
>
> Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.ed= u.pk>

NAK
As you said, you did not test it on Windows, yet you added #ifdef
for Windows support. Since Windows doesn't support secondary
processes (yet) how could you.

Adding Windows here has to wait until it can be tested.
Can you please check if my understanding is corr= ect that #ifndef RTE_EXEC_ENV_WINDOWS means only Linux based systems ?=C2= =A0
I have added all the codes under this macro :)= =C2=A0


Best regards,
Khadem
--000000000000e6ea87063e8b784b--