From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E722A0093 for ; Thu, 17 Mar 2022 18:02:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60A8F407FF; Thu, 17 Mar 2022 18:02:33 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id E29B3407FF for ; Thu, 17 Mar 2022 18:02:31 +0100 (CET) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 4F95F3F07E for ; Thu, 17 Mar 2022 17:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647536551; bh=S68nCMw42Mgzhc3AZgiPtNFuVy4qJfQBj8rQaPaHpNo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=aZWJY7P3eVioY9xt6BxU69yBj1hSre/JMbI1FJpUN0mqBHLYxhBLxrJnV8GsIePNo IS82yT2nActkk3jTycQXPuzk3cCNClcZMNnLOCzgIOAgKfXkiwD7Yv4nBLCqvL6EfY JUqlWyquBcgFaMMt9+SRZ8P44xUGqMG1vJvB/9MvX49JiIcUH0paDSMTZcD6KjIUjY g7PJChbx5j8CA7UnxYXmjc3+PnaTK2vAqnjDGUWU3Two4JmVQfckX3hWGYNqvAd/A6 8skZLQf+WP61gWxIWa+VGNVWKBV9vbzDIXHHFh26HLG0jK6RXxL9ssvSYHI4Z3eiLs RbNUgGqYLlV1A== Received: by mail-qv1-f69.google.com with SMTP id hu9-20020a056214234900b0042c4017aeb3so4433673qvb.14 for ; Thu, 17 Mar 2022 10:02:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S68nCMw42Mgzhc3AZgiPtNFuVy4qJfQBj8rQaPaHpNo=; b=cuqhQYlkUAIOEmR3MwWc7u8cQ1XYW8ICJdF1Cp49cYPjOmTnxV8eeJ0e172HPTTljv NrQwctX6Yd2TC/tR2II805/sn69tqBOeU4zuhIYoP/batHOJEaVkQyz8eejXG0wJ7fnk bDd3bw16355VSrV/zSTGfKe+3y4Kvtvmc2KdXUG3UUoupMsQcy8CMjmv+o4Sa4YPPTnk NiE6Wtaf1j9QakW3bdHiWXoeuf/dQx/efyW/Ho4qJqDTX/h+VFjSAJ/JMPtbfl9JTvET R1OK1kpep2X274CRIoMVluoXGGGAV16B6ErmgJBVcF9u0ktyCUOWEHbWPfSa5GaTPBP8 Bm5Q== X-Gm-Message-State: AOAM531w1Yy2UqD9XNhoFPTN+zAS2mgm+eKKeyHCLf6B1q1jqjPNq/bJ nsOwewcGc6cWBz6g/NB1P/Xw0/K5ZsWS8svHocala5Br9To/C1Y8W3wE0PYU/0oHL9IdXjbLW2M X2dePbog8sMEsTCO/CPavh2YMQitREqyo2PoeMLuN X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr3578918qkl.86.1647536550271; Thu, 17 Mar 2022 10:02:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrfPeegdvxMbzYxsfmBs0gw2Lj7jVMVn5innVfRdhHlb/kG8ah/9KsTCDlK53lMAQmKy8vjlc2JguqyBaWiAw= X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr3578896qkl.86.1647536549914; Thu, 17 Mar 2022 10:02:29 -0700 (PDT) MIME-Version: 1.0 References: <20220316122318.718039-1-luca.boccassi@gmail.com> <20220317140658.945624-1-luca.boccassi@gmail.com> In-Reply-To: <20220317140658.945624-1-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Thu, 17 Mar 2022 18:02:03 +0100 Message-ID: Subject: Re: [PATCH 20.11 v2] cryptodev: add backward-compatible enum To: luca.boccassi@gmail.com Cc: stable@dpdk.org, david.marchand@redhat.com, Luca Boccassi Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Mar 17, 2022 at 3:07 PM wrote: > > From: Luca Boccassi > > The enum was renamed to fix a typo in main, and backported. > But in the stable release we want to keep backward compatibility > when possible, so also define the old name so that both old and > new code will work. > > Fixes: 7b5609a5a0e7 ("cryptodev: fix RSA key type name") > > Signed-off-by: Luca Boccassi > --- > Fixed order of comments for doxygen > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h > index 9c5bb9233a..d59e05323e 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -150,6 +150,8 @@ enum rte_crypto_rsa_priv_key_type { > /**< RSA private key is in quintuple format > * See rte_crypto_rsa_priv_key_qt > */ > + RTE_RSA_KET_TYPE_QT = RTE_RSA_KEY_TYPE_QT, > + /**< Backward-compatible definition of old name */ I've already applied this merging Lucas first version with David's feedback and tested it on 19.11.12 and it works fine for me. Worked on a cross distro/arch build test as well as in the ABI check (thanks for sharing that BTW). Tested-by: Christian Ehrhardt > }; > > /** > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd