From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32CF9A034F for ; Mon, 22 Feb 2021 17:26:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 260D74003C; Mon, 22 Feb 2021 17:26:56 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id A63614003C for ; Mon, 22 Feb 2021 17:26:54 +0100 (CET) Received: from mail-qt1-f197.google.com ([209.85.160.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lEE2w-0004Og-Bp for stable@dpdk.org; Mon, 22 Feb 2021 16:26:54 +0000 Received: by mail-qt1-f197.google.com with SMTP id i19so8028716qtx.6 for ; Mon, 22 Feb 2021 08:26:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VF9OeJDOcWHhO7pNXfz8MFqB74NFLsDRC79qLkWfn9E=; b=CvYxWJUmDa6vEtRAgF90yV0kYPsZN7L34O7zyd+SQRc3eBb1nFFcJRRvg/oWgxzaMA BUyb9rbExlR+nHNEju/LhT68BGrgzPBvhwt90kcW5ZIsrcwqBn87ksXB4NiNhb0cg51Z ZuZr9WUcBSiXdmEXdLEva9cysNSCIuaFb0VMgY300+5Xg4x8PZWcZLqNlm90HmfHreMI C3nLTsRsq/rl/SsYgBofZKwAiIQr4NiKx8HOBwxZ8xTjExw6lgbjAL16b6IaZ4TPGZjt 33qAhF97ZFnvlbjJDsL3JK7A+WoBKoOLrrLz3J+V2KYCjgmzwfqaTizJoDvhjcon7t5w 1zuA== X-Gm-Message-State: AOAM531vtTRTysCdx7zanXsTlEDggdiBsa4i2aFO6zUPhkq8XPGdg9BS nU0HR2UMdIXyWy/vFRyqA0ojjEN8YudztzFUOoblPm3jkqhyjFx6YN+Vhttgqa2/vS8sPq7Pc7K timsD7fwl/u9PS96BK6/lUARkhKIi7Tx2ulHT7cBW X-Received: by 2002:ac8:d44:: with SMTP id r4mr20287916qti.7.1614011213446; Mon, 22 Feb 2021 08:26:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBhsDeNOC5SMSOLgZaoQSpEeiH/VorwzZJwIRATbAw1R4IR4IeAuSuzm5IbF9lU6g7AzZ338xSCLHwr4pWO/s= X-Received: by 2002:ac8:d44:: with SMTP id r4mr20287887qti.7.1614011213103; Mon, 22 Feb 2021 08:26:53 -0800 (PST) MIME-Version: 1.0 References: <20210211135920.530256-1-luca.boccassi@gmail.com> In-Reply-To: <20210211135920.530256-1-luca.boccassi@gmail.com> From: Christian Ehrhardt Date: Mon, 22 Feb 2021 17:26:27 +0100 Message-ID: To: Luca Boccassi Cc: dpdk stable , Luca Boccassi Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [scripts] 3-backport: use get-maintainer.sh to CC subtree maintainers X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Feb 11, 2021 at 2:59 PM wrote: > > From: Luca Boccassi > > Signed-off-by: Luca Boccassi > --- > 3-request-backport | 8 +++++++- > README | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletion(-) I haven't tested but from review this LGTM and we have together expressed that we'd want this feature. So Ack to it and if it exposes issues we can fix them up later. Acked-by: Christian Ehrhardt > diff --git a/3-request-backport b/3-request-backport > index d123531..a1725e5 100755 > --- a/3-request-backport > +++ b/3-request-backport > @@ -2,6 +2,8 @@ > > source ./lib.sh > > +set -e > + > list="" > if [ $# -lt 1 ] && [ "$GIT_AM_PAUSE_ON_FAIL" = "yes" ] > then > @@ -13,7 +15,7 @@ then > for _file in $list > do > _sub=$(grep Subject $_file | cut -d\ -f3-) > - echo "$_applied" | grep -qF "$_sub" || (head -n1 $_file | awk '{print $2}' >> /tmp/.list-$$) > + echo "$_applied" | grep -qF "$_sub" || (head -n1 $_file | awk -v _file=$_file '{print $2" "_file}' >> /tmp/.list-$$) > done > popd &>/dev/null > else > @@ -33,6 +35,10 @@ get_cc_list() > > > $cc_list > while read commit patch; do > + # Has to be used from git repository directory > + pushd $STABLE_DIR &>/dev/null > + $STABLE_DIR/devtools/get-maintainer.sh $patch >> $cc_list > + popd &>/dev/null > $GIT show $commit | grep -h '^.*: .*<.*@.*\..*>' | > sed 's/[^:]*: //' >> $cc_list > done < $list > diff --git a/README b/README > index 6489379..cc5f6bf 100644 > --- a/README > +++ b/README > @@ -120,6 +120,10 @@ should keep an accumulated list for the stable tree and send out this > request multiple times with the accumulated list of failed patches. This > list will also be used by "6-announce-release". > > +The 'devtools/get-maintainer.sh' tool from the DPDK repository is used to > +compile the list of maintainers to CC for each patch. A configuration file > +needs to be set up first, see the script itself for instructions. > + > 4-final-review > ============== > > -- > 2.29.2 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd