From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5368EA00C5 for ; Wed, 3 Aug 2022 14:16:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A01D40A7E; Wed, 3 Aug 2022 14:16:25 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 62AC640141 for ; Wed, 3 Aug 2022 14:16:24 +0200 (CEST) Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 23CCD3F132 for ; Wed, 3 Aug 2022 12:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1659528984; bh=m1iQL7ODGehI167gYIKoJ3LlpIlluO5GBJZ5o89y3xU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=l1oBYQjQTxeSxzfjuz8lOGjnH1LbwaOS7kUznDjcuovUFE6h1tHwj5tZi5xPBUp3P lAQ3aqoPnpkJRDIsObcvaYBeQO2MSOqPJjdTv4ONCXK+CRFId+ACYuIo7noFMGD2Js 7vKeXOFqFoNweNuFd0ydwP0bUaAtSEDm5fmJRaQQ89mJOCoLugghQDk4LfThK12iSR MK6AH0PwAdWqem2phIjzyfvGK5XYV7fWfws5/mN7blVCtw3Ph9ZRxBZRFemI24FBgW gC2PlSVwfZjl2nRcTtK/dbWnRFyG/dBHEWMgj+TwuK48xjw6Hq3Yh4kZlD2zCVQG3x emD2QbPkDSUGA== Received: by mail-lj1-f200.google.com with SMTP id y11-20020a05651c220b00b0025e4bd7731fso2462700ljq.3 for ; Wed, 03 Aug 2022 05:16:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=m1iQL7ODGehI167gYIKoJ3LlpIlluO5GBJZ5o89y3xU=; b=yYpToqmG4ZuLnT56s/Q8nEkHzicfhBgDQZSf26EIdA8pye125kTeCljHn9Lz0P/27T b0dy+8n+V3jkOwhz81kkMgtiNbF6mhntU1X+ORN2P9V14m6kiGqr9DVUqx6wlqa9+064 yz1N0xsY20IOxJLLiiruXnp009ckbbkJbVPNbBOPaJAjeCsmnKdXUmd7zkK9VSBttB0u aNwG3WehFAjphMUOSn+yL/SL1YSXq4wTv8pmy1nGprsMlaJqx9q7m594l22TXC3Ji0YP EAYGXz5n+zh9olx++xmv/uVGX9TcOz9gBchvEMOfBZOGoMDhVVtEJjjDtbraNuHjmTQ9 BK9Q== X-Gm-Message-State: ACgBeo0GSCu5Vye6acXiwOfy2L+sN+rhLPQQivn1mPXRtjZ4srdvfhx8 ZXZusMjUQzVvLLYpvajEHdmImnFQ8T3nOr5p5AEO0DFG1oVOmDh3edHa/JbXiuaSLkpbs1I+szF gQZZQsP/267LMvU44jS/Flw6hSJo+JNPvtsTnt6cj X-Received: by 2002:a05:6512:2354:b0:48a:e29b:2bb4 with SMTP id p20-20020a056512235400b0048ae29b2bb4mr9194184lfu.435.1659528982622; Wed, 03 Aug 2022 05:16:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR6sTbiIfDylLZVZiqp/ud2E+ePNTAI6F3zjGYyjKZf/jnVKED55h+ixmnV2ybaDQCG2xWciflxaakMyHne6o+g= X-Received: by 2002:a05:6512:2354:b0:48a:e29b:2bb4 with SMTP id p20-20020a056512235400b0048ae29b2bb4mr9194177lfu.435.1659528982387; Wed, 03 Aug 2022 05:16:22 -0700 (PDT) MIME-Version: 1.0 References: <20220720051926.272674-1-ke1x.zhang@intel.com> In-Reply-To: From: Christian Ehrhardt Date: Wed, 3 Aug 2022 14:15:56 +0200 Message-ID: Subject: Re: [PATCH 19.11] net/iavf: fix Rx queue interrupt setting To: Ali Alnubani Cc: Ke Zhang , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Aug 3, 2022 at 1:40 PM Ali Alnubani wrote: > > > -----Original Message----- > > From: Christian Ehrhardt > > Sent: Wednesday, August 3, 2022 12:58 PM > > To: Ke Zhang > > Cc: stable@dpdk.org > > Subject: Re: [PATCH 19.11] net/iavf: fix Rx queue interrupt setting > > > > On Wed, Jul 20, 2022 at 7:28 AM Ke Zhang wrote: > > > > > > [ upstream commit a08f9cb698c3d4687765860e328dca727f7a516b ] > > > > Thank you, > > your patch was too late in regard to my original deadline and I was > > then unavailable for a while. > > In the meantime more patches came in and I do not want to waste any of > > them just because they were late. > > > > Your patch is applied to the WIP branch now, but currently testing of > > -rc1 is going on which I do not want to disrupt. > > > > Hello, > > I believe this is causing the following build failure in 19.11.13-rc2: I agree, I was trusting manual backports too much and releasing while tests were still ongoing in the background. Expect an -rc3 later today (this time with test builds completed before tagging). > """ > In file included from drivers/net/iavf/iavf_ethdev.c:13: > drivers/net/iavf/iavf_ethdev.c: In function 'iavf_dev_rx_queue_intr_disable': > drivers/net/iavf/iavf_ethdev.c:1212:9: error: 'IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK' undeclared (first use in this function); did you mean 'IAVFINT_DYN_CTLN1_WB_ON_ITR_MASK'? > 1212 | IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32' > 74 | #define rte_cpu_to_le_32(x) (x) > | ^ > drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE' > 116 | IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value)) > | ^~~~~~~~~~~~~~~~~~ > drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG' > 1210 | IAVF_WRITE_REG(hw, > | ^~~~~~~~~~~~~~ > drivers/net/iavf/iavf_ethdev.c:1212:9: note: each undeclared identifier is reported only once for each function it appears in > 1212 | IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32' > 74 | #define rte_cpu_to_le_32(x) (x) > | ^ > drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE' > 116 | IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value)) > | ^~~~~~~~~~~~~~~~~~ > drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG' > 1210 | IAVF_WRITE_REG(hw, > | ^~~~~~~~~~~~~~ > """ > > I can reproduce on Ubuntu 20.04 with gcc 9.4.0. > > - Ali -- Christian Ehrhardt Senior Staff Engineer, Ubuntu Server Canonical Ltd