From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8556EA00C2 for ; Wed, 8 Dec 2021 15:20:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7727C406FF; Wed, 8 Dec 2021 15:20:45 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 7D89D406FF for ; Wed, 8 Dec 2021 15:20:43 +0100 (CET) Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4E4E53F1B0 for ; Wed, 8 Dec 2021 14:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638973243; bh=PGyfL7biBfOLWVnTqgf1Tag0KGOtmhjhW516fWFw860=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=vd2d8ATvRtjYDSqftGGN6oqCzkOlqJB2stKFidRxRiGXU6JOP+h8ON4kVD0FH21Sj +vb1yahWvPbbHCoBt+CZS1dUIhJBxsPAaXFkLKuApoqm5/mllqduIEGvqES3046ASK 7Z9TrkTKRzAkm/upS7hKa+eVGWp9WzsiDAWhc9sxWGBNteDxOWZWCKWrtms25pxlYk E+lu/Pn/tVu7H6597RDXJ6gCJukpJ5rV5wI3Eqqf2FSk8s5R0ckN0AM5wWWxICIZ/p 5tjkrUZrISxRu34iAASPajJlpAWBFPB5XdLZvTjivGZMNwQrjRxY/O4xF0Hu/5x/QJ RT5AON65JnDZg== Received: by mail-qk1-f200.google.com with SMTP id u8-20020a05620a454800b00468482aac5dso3175303qkp.18 for ; Wed, 08 Dec 2021 06:20:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PGyfL7biBfOLWVnTqgf1Tag0KGOtmhjhW516fWFw860=; b=vUqtcWQ1vjlgbHUpRmEt9t/rM1dbKNmOtz/PDLZ2Qdkjspebwvo8wRKv5GRKocf/6u Z9O+/Wkg+Lh/bXp+bpgxrV+GLQP84udGoxeN0HcOZ73oG+bYP0RezrS/qEUDJacylJFp 7rbHAOuhCQ+wOX8gyXjKo/EWS6VZiZBPp3FyBqvEKvOOxsX9+1KkTgWhMwTV/U7rj/vS QOqeNIgpFgCvUULktB5/D1GupeUjK6wQ9veWw7/j2wdmCmxSe9nK+1B08Bk9vrnOXFki 6GJRkF+70z+SuxBPy2GbWbV3/97+1dV3dHvJuHRLzKTV3M6FBILR2ZwgoZoVe4ZOFFk5 7ibw== X-Gm-Message-State: AOAM531kGOtnGMDpTCUeAc1guqRlIMxzz4RcQT4DQGFnrdUUkUxdM/Vz naU+ul80sqRUsCJVYR5ey5cFwjugaUDq51Znc8cQDOM9+uqNk3zQ7kuO5wudf6k1qpu0GorNq7b rQ0wY5E36jrJrNvaGsl/hRM32Pp4fSSIeQJ0BIGPA X-Received: by 2002:a05:6214:2608:: with SMTP id gu8mr8001476qvb.18.1638973242462; Wed, 08 Dec 2021 06:20:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnDEGIQWw59RcMqF2GwNW+KMkRQP95HYcrF+8WhiXynQ92odGg2R2hEZqNPvQAOaf4MGxE86lvFK8dJ/beFRU= X-Received: by 2002:a05:6214:2608:: with SMTP id gu8mr8001444qvb.18.1638973242291; Wed, 08 Dec 2021 06:20:42 -0800 (PST) MIME-Version: 1.0 References: <20211208103954.220829-1-jie1x.wang@intel.com> In-Reply-To: <20211208103954.220829-1-jie1x.wang@intel.com> From: Christian Ehrhardt Date: Wed, 8 Dec 2021 15:20:16 +0100 Message-ID: Subject: Re: [PATCH 19.11] app/testpmd: fix DCB in VT configuration To: Jie Wang Cc: stable@dpdk.org, Aman Singh Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 8, 2021 at 3:43 AM Jie Wang wrote: > > [ upstream commit cbe70fded831acac4ccbde8e11ba33ce8c24227c ] Thanks, applied > When set port DCB in VT mode enabled, it should remove RSS HASH > offload before reconfiguring the device and queues. > > Because port multi-queue mode is changed from RSS to DCB in VT. > > Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") > > Signed-off-by: Jie Wang > Acked-by: Aman Singh > --- > app/test-pmd/testpmd.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index dca10e7b66..b0b7472e91 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3484,6 +3484,13 @@ init_port_dcb_config(portid_t pid, > if (retval < 0) > return retval; > port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; > + /* remove RSS HASH offload for DCB in vt mode */ > + if (port_conf.rxmode.mq_mode == ETH_MQ_RX_VMDQ_DCB) { > + port_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_RSS_HASH; > + for (i = 0; i < nb_rxq; i++) > + rte_port->rx_conf[i].offloads &= > + ~DEV_RX_OFFLOAD_RSS_HASH; > + } > > /* re-configure the device . */ > retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf); > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd