From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7A29A0093 for ; Mon, 3 Jan 2022 12:34:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1DED4003C; Mon, 3 Jan 2022 12:34:59 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 898E54003C for ; Mon, 3 Jan 2022 12:34:58 +0100 (CET) Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 43B373F044 for ; Mon, 3 Jan 2022 11:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641209698; bh=keOhbTs1gYWx0LFQwma3a7wmtWp+5onLBAcS8vdJy3s=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BxXHq3vD0zOKK6qeCJJSM1kdk7qtjSAdkxkElz2aRkfsj2kY/qhG8k/CBOjagRbR+ HBX+BxGoFKM/BBcMK9cD4CUJ4eXuDGcGZmhOm2rvtuRoutoKRdavCcZXCLTHkE6++c LHzZgNTFdUbO0LGbH7Km7GpjOMkVh7wEwDRSeCeRk5CloHsEqtvh6fIrn/J96OJLdO QqlOAc0cJ4DNYPDUd+4Rkd40eqjuiSuqu2AJiCe8+CIGaHCNY2h4KlbDai6boUJ0Rk v4jJeFNwwL6oGPV9VJBpMV8SUwAIs4ZX511G9FTAawWXy8le6uqS0tsJmmTidQhd/i jN2we+YbE7Yhw== Received: by mail-qv1-f71.google.com with SMTP id r13-20020a0562140c4d00b004119074a4d9so24190062qvj.12 for ; Mon, 03 Jan 2022 03:34:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=keOhbTs1gYWx0LFQwma3a7wmtWp+5onLBAcS8vdJy3s=; b=zLCi1Zlq+Wvrk2YQis9Vt0/GHeu7Z9sTuYTYvZ3nqPrtpCVL2t1TOKA0jI3n1IImho NOkAElBl+cT1f2Z55sWoYlLwDPxTaU1DnreQbcelb3VbuhKMJm3h3EIQ+voMp/bVJeCj cZzFSUr5L6HqRPa7Nkny/cLgCpc0o9TqsMzrAwoJLqKHHM1nFoWU45EXgu0pIqGVlLRA LzNfjiLxRKgdVRkZjrTY1EcQt3sivtHdWlQJ2iO/26SZoA8ce6GxknH7bWVCkNnI4GsH Or6dH/Pwan0Es3hw2vQMXa/O+WTF6r7Cv2J/74jzxYC79yJJZZfQUuuScEpjj27rRcWq zPlw== X-Gm-Message-State: AOAM533qNss0v6VIIcLKsNgUf821wakUluGSOxtKIgv4R1S4dMTqRkQX QWDX6UGd5gu3VaiMXLZpaMPqyKv6XBy5VqHm1JqEVS4Gz0Ivo2yk4ZrM8flnXfWdxLJWotYantj MUmjFp8LjjklWzxv4lnE3R9gdp1ET8+HtRfrt+p/Y X-Received: by 2002:a05:620a:404b:: with SMTP id i11mr31792464qko.585.1641209697361; Mon, 03 Jan 2022 03:34:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzr64itaCAZYjNjGggzeNdU8wIu2xm0wvhOj542BKGDzAZYnf/ZMgcX2Q6ZQxA+zd3iT3B3sPThKZAItPGMgw= X-Received: by 2002:a05:620a:404b:: with SMTP id i11mr31792450qko.585.1641209697136; Mon, 03 Jan 2022 03:34:57 -0800 (PST) MIME-Version: 1.0 References: <20211220104805.92324-1-haiyue.wang@intel.com> In-Reply-To: <20211220104805.92324-1-haiyue.wang@intel.com> From: Christian Ehrhardt Date: Mon, 3 Jan 2022 12:34:31 +0100 Message-ID: Subject: Re: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 To: Haiyue Wang Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com, alialnu@nvidia.com, Wenzhuo Lu , Konstantin Ananyev Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang wrote: > > Check the clang version before enabling '-Wno-unused-but-set-variable', > otherwise it will have "error: unknown warning option". Thanks, Queued for 19.11.11 as it improves some other recently added compiler fixes and we'd want to avoid those breaking older clang builds. > https://reviews.llvm.org/D100581 > > Bugzilla ID: 913 > > Signed-off-by: Haiyue Wang > --- > drivers/net/ixgbe/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile > index 31a418a2c6..c730bbddb4 100644 > --- a/drivers/net/ixgbe/Makefile > +++ b/drivers/net/ixgbe/Makefile > @@ -29,7 +29,9 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > # > CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value > CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args > +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > +endif > > else > # > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd