* [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13
@ 2021-12-20 10:48 Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
To: stable
Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
Wenzhuo Lu, Konstantin Ananyev
Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".
https://reviews.llvm.org/D100581
Bugzilla ID: 913
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ixgbe/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index 31a418a2c6..c730bbddb4 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -29,7 +29,9 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
else
#
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
@ 2021-12-20 10:48 ` Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
2 siblings, 1 reply; 9+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
To: stable
Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
Beilei Xing
Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".
https://reviews.llvm.org/D100581
Bugzilla ID: 913
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/i40e/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index d6ced28f3d..3f7565fbd6 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
else
CFLAGS_BASE_DRIVER = -Wno-sign-compare
CFLAGS_BASE_DRIVER += -Wno-unused-value
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
@ 2022-01-03 11:34 ` Christian Ehrhardt
0 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
To: Haiyue Wang; +Cc: stable, yux.jiang, qi.z.zhang, alialnu, Beilei Xing
On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".
Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.
> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/i40e/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
> index d6ced28f3d..3f7565fbd6 100644
> --- a/drivers/net/i40e/Makefile
> +++ b/drivers/net/i40e/Makefile
> @@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
> CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
> CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
> else
> CFLAGS_BASE_DRIVER = -Wno-sign-compare
> CFLAGS_BASE_DRIVER += -Wno-unused-value
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
@ 2021-12-20 10:48 ` Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt
2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
2 siblings, 1 reply; 9+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
To: stable
Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
Qiming Yang, Wenzhuo Lu
Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".
https://reviews.llvm.org/D100581
Bugzilla ID: 913
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ice/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
index 370b33af60..9cfd059781 100644
--- a/drivers/net/ice/Makefile
+++ b/drivers/net/ice/Makefile
@@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
CFLAGS_BASE_DRIVER += -Wno-unused-parameter
CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
else
CFLAGS_BASE_DRIVER += -Wno-unused-parameter
CFLAGS_BASE_DRIVER += -Wno-unused-variable
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
@ 2022-01-03 11:34 ` Christian Ehrhardt
0 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
To: Haiyue Wang
Cc: stable, yux.jiang, qi.z.zhang, alialnu, Qiming Yang, Wenzhuo Lu
On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".
Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.
> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ice/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
> index 370b33af60..9cfd059781 100644
> --- a/drivers/net/ice/Makefile
> +++ b/drivers/net/ice/Makefile
> @@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
> else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> CFLAGS_BASE_DRIVER += -Wno-unused-parameter
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
> else
> CFLAGS_BASE_DRIVER += -Wno-unused-parameter
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
@ 2022-01-03 11:34 ` Christian Ehrhardt
2 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
To: Haiyue Wang
Cc: stable, yux.jiang, qi.z.zhang, alialnu, Wenzhuo Lu, Konstantin Ananyev
On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".
Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.
> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ixgbe/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 31a418a2c6..c730bbddb4 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -29,7 +29,9 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> #
> CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>
> else
> #
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
@ 2021-12-14 16:29 Haiyue Wang
2021-12-14 17:23 ` Ali Alnubani
0 siblings, 1 reply; 9+ messages in thread
From: Haiyue Wang @ 2021-12-14 16:29 UTC (permalink / raw)
To: stable
Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, Haiyue Wang,
Wenzhuo Lu, Konstantin Ananyev
Disable the -Wunused-but-set-variable option for clang to avoid
compile warning.
Bugzilla ID: 900
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ixgbe/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index 31523025b3..31a418a2c6 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
#
CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
+CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
else
#
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
2021-12-14 16:29 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13 Haiyue Wang
@ 2021-12-14 17:23 ` Ali Alnubani
2021-12-15 1:05 ` Wang, Haiyue
0 siblings, 1 reply; 9+ messages in thread
From: Ali Alnubani @ 2021-12-14 17:23 UTC (permalink / raw)
To: Haiyue Wang, stable
Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, Wenzhuo Lu,
Konstantin Ananyev
> -----Original Message-----
> From: Haiyue Wang <haiyue.wang@intel.com>
> Sent: Tuesday, December 14, 2021 6:30 PM
> To: stable@dpdk.org
> Cc: christian.ehrhardt@canonical.com; yux.jiang@intel.com;
> qi.z.zhang@intel.com; Haiyue Wang <haiyue.wang@intel.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>
> Subject: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
>
> Disable the -Wunused-but-set-variable option for clang to avoid
> compile warning.
>
> Bugzilla ID: 900
Do you mean "Bugzilla ID: 903"?
https://bugs.dpdk.org/show_bug.cgi?id=900 is a net/nfp build failure.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ixgbe/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 31523025b3..31a418a2c6 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> #
> CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>
> else
> #
> --
> 2.34.1
Thanks Haiyue for looking into this.
I no longer see the build failures in Bugzilla tickets 901/902/903, but I now see similar build errors in net/qede and net/sfc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
2021-12-14 17:23 ` Ali Alnubani
@ 2021-12-15 1:05 ` Wang, Haiyue
0 siblings, 0 replies; 9+ messages in thread
From: Wang, Haiyue @ 2021-12-15 1:05 UTC (permalink / raw)
To: Ali Alnubani, stable
Cc: christian.ehrhardt, Jiang, YuX, Zhang, Qi Z, Lu, Wenzhuo,
Ananyev, Konstantin
> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: Wednesday, December 15, 2021 01:23
> To: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> Cc: christian.ehrhardt@canonical.com; Jiang, YuX <yux.jiang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: RE: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
>
> > -----Original Message-----
> > From: Haiyue Wang <haiyue.wang@intel.com>
> > Sent: Tuesday, December 14, 2021 6:30 PM
> > To: stable@dpdk.org
> > Cc: christian.ehrhardt@canonical.com; yux.jiang@intel.com;
> > qi.z.zhang@intel.com; Haiyue Wang <haiyue.wang@intel.com>; Wenzhuo Lu
> > <wenzhuo.lu@intel.com>; Konstantin Ananyev
> > <konstantin.ananyev@intel.com>
> > Subject: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13
> >
> > Disable the -Wunused-but-set-variable option for clang to avoid
> > compile warning.
> >
> > Bugzilla ID: 900
>
> Do you mean "Bugzilla ID: 903"?
My typo fault, yes, 903. will send v2.
> https://bugs.dpdk.org/show_bug.cgi?id=900 is a net/nfp build failure.
>
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > drivers/net/ixgbe/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> > index 31523025b3..31a418a2c6 100644
> > --- a/drivers/net/ixgbe/Makefile
> > +++ b/drivers/net/ixgbe/Makefile
> > @@ -29,6 +29,7 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> > #
> > CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
> > CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> > +CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> >
> > else
> > #
> > --
> > 2.34.1
>
> Thanks Haiyue for looking into this.
> I no longer see the build failures in Bugzilla tickets 901/902/903, but I now see similar build errors
> in net/qede and net/sfc.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-01-03 11:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt
2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
-- strict thread matches above, loose matches on Subject: below --
2021-12-14 16:29 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13 Haiyue Wang
2021-12-14 17:23 ` Ali Alnubani
2021-12-15 1:05 ` Wang, Haiyue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).