From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC627A0093 for ; Mon, 3 Jan 2022 12:35:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E51014003C; Mon, 3 Jan 2022 12:35:10 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 1468240688 for ; Mon, 3 Jan 2022 12:35:09 +0100 (CET) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D6D373F175 for ; Mon, 3 Jan 2022 11:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641209708; bh=Dl5jSnHcSPRKoGdo2lS4J9yps7whDDeVC2RGo54RHRE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=O8aNY6mwwq8jWmYDAw/WrTwEsUSaYM1b35AlW67xerptwQFSSzSnb/6/qsew3RO/a M+qnRtVPV7p5/w672QdAd3JIQbxKEDHKHjhvR2JszDQw+2DE6RSa4dQUSiIkFgm6q7 4iQrOZHdSnAKXlnTCsb2h1Gar3h071rQrx+El4dhCEM8Xjj2QFxxP72FluEh3V6gDp o1AkAEfdMs2zRUQPGcWHpQKjsTp82+n3b+QG+Ine6AozNVHePDG0qGvE1XQ5KZci2H bkoyGZRRBfGa3CuVmi1fnzcCxPD0l/4ow4mKOP4LwhQOV3YFfZghoRdRjAnpXMyV7/ tbLLPI/i0A8dw== Received: by mail-qv1-f72.google.com with SMTP id i3-20020ad45c63000000b0041143710adbso27010390qvh.18 for ; Mon, 03 Jan 2022 03:35:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dl5jSnHcSPRKoGdo2lS4J9yps7whDDeVC2RGo54RHRE=; b=ekexCKvM0UZsrf2fSkcgdv+wB9wjnX5zLbxfIbVohhXIB8GU3T9lSsDIYTOYJLnBRl bDm7YA2+HoUUHEeurGxKmXAOM6JSc344UDovuSIkIkhKIK41OCB3/DknrvV6Cx+hLG6b gqe3eRms2aR7axyZPcRItjLyDmOFVH2xRWP/7chq+4ZiBJHzsvrooizy4a5HuVp1V5Oa lDUAVVaQ2yP6p0ycgw7pTCxY0rtUmjjaP9d26kW8X3ggQyngMLp0KaLbhETRiIS328su drPumZLx8w5teEWEiXxB2Z/4i4erlvYCQgkg+SOCakGrLRzbjK7TsrhgPVm0yO5e6zEW GAlg== X-Gm-Message-State: AOAM5309bh1beKMEF6P4ph0p6AGTIKNKAPnsBMcr2bBt+ZGJFlSt6SY7 5efjgyOkr66JzT+I+BK6WMezd3967oAa66wGI9RnvHO6TYFMmmYK9pdTwChOMrsA9PD3VShn+zH pBjWqpjpPmJXp+R2msMIjtIgo2mtgMzfo+eIl9rLi X-Received: by 2002:ac8:7caf:: with SMTP id z15mr40346448qtv.20.1641209708021; Mon, 03 Jan 2022 03:35:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuw9SHctO34JnKbWq3iAl36iDhaZVgn8CgG+3ESpNG6+X7bCWDbM5zki4CxSWqzXAwezW6APtvlpgMF/wZfD0= X-Received: by 2002:ac8:7caf:: with SMTP id z15mr40346431qtv.20.1641209707831; Mon, 03 Jan 2022 03:35:07 -0800 (PST) MIME-Version: 1.0 References: <20211220104805.92324-1-haiyue.wang@intel.com> <20211220104805.92324-2-haiyue.wang@intel.com> In-Reply-To: <20211220104805.92324-2-haiyue.wang@intel.com> From: Christian Ehrhardt Date: Mon, 3 Jan 2022 12:34:42 +0100 Message-ID: Subject: Re: [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13 To: Haiyue Wang Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com, alialnu@nvidia.com, Beilei Xing Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang wrote: > > Check the clang version before enabling '-Wno-unused-but-set-variable', > otherwise it will have "error: unknown warning option". Thanks, Queued for 19.11.11 as it improves some other recently added compiler fixes and we'd want to avoid those breaking older clang builds. > https://reviews.llvm.org/D100581 > > Bugzilla ID: 913 > > Signed-off-by: Haiyue Wang > --- > drivers/net/i40e/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile > index d6ced28f3d..3f7565fbd6 100644 > --- a/drivers/net/i40e/Makefile > +++ b/drivers/net/i40e/Makefile > @@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers > CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast > CFLAGS_BASE_DRIVER += -Wno-format-nonliteral > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > +endif > else > CFLAGS_BASE_DRIVER = -Wno-sign-compare > CFLAGS_BASE_DRIVER += -Wno-unused-value > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd