From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 767D1A0524 for ; Tue, 1 Jun 2021 11:06:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 413E540040; Tue, 1 Jun 2021 11:06:08 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 464EC40040 for ; Tue, 1 Jun 2021 11:06:07 +0200 (CEST) Received: from mail-qv1-f72.google.com ([209.85.219.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lo0Lf-0007ds-0S for stable@dpdk.org; Tue, 01 Jun 2021 09:06:07 +0000 Received: by mail-qv1-f72.google.com with SMTP id h11-20020a0ceecb0000b0290211ed54e716so78370qvs.9 for ; Tue, 01 Jun 2021 02:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=COCBLYbq8o31y6HvuLJwXLryVgMV5a3RnZL+ief6cNM=; b=jjphDsJVrBReFHIEhKoEWS8kDRDMoNdev2/dM/3I4YaJd6Qx4pTxwJHvfksogAsH95 FxHkMKym7GAN+ACMbcFAzlon1KKY+ao/nAfgarf9puBdSkvythWGj5Gm/aNZwXsIheFU X7bNEpIMHslzIhUw7CqkJiNcxqPPcF9ei4GOTzbfY8k8Bc4fF+JE/PoDqRhgiqI59Lrh bxzXx84g6jggPzkuR/QfZN7P5k/qjMtZ/2Xuto6K0/wrbeHcc7f/jsDicnp/ur1Y49Sk wzmh8XN1ACU6NuWPlKfjzKGErg01YfVSzvweWAPHhONIRF6YVyFEvDK20diOjpIXv3r6 qORw== X-Gm-Message-State: AOAM532CgYhDA8qiwgFGPdRVFaD2Y1KTC3H86tN9dgdufxQ3fBagjd2Y xgisPBnXc/YeMLZj2V5OfSSGSVZrpxP53hqoRenOO6S/wI1JfVjSkVaDO83p4jlzvERDng26q3l vgW2GlaT9rZg2j1autZp92t8BoiuCtFi8azeXQJF+ X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr20826086qko.462.1622538365936; Tue, 01 Jun 2021 02:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt7haXzgFVOtTA1x9uXmvPaatY61G6VtvwewFbRYWews7ZpK346QHvBbWFNG88A/4GIkF1Zz4EzvY/ND1eZc8= X-Received: by 2002:a05:620a:1667:: with SMTP id d7mr20826072qko.462.1622538365710; Tue, 01 Jun 2021 02:06:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Tue, 1 Jun 2021 11:05:39 +0200 Message-ID: To: Chengwen Feng Cc: dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" FYI this also implies a remove of the depending commit 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6 Author: Chengwen Feng Date: Thu Apr 22 09:55:50 2021 +0800 net/hns3: fix processing link status message on PF On Tue, Jun 1, 2021 at 11:03 AM Christian Ehrhardt wrote: > > Hi, > this mostly is an FYI to document why a change was not applied to the > stable series. This was targeted for stable releases: > > commit dbbbad23e380773b37872df2195c4529fd93ca6f > Author: Chengwen Feng > Date: Tue Apr 13 19:50:02 2021 +0800 > > net/hns3: fix VF handling LSC event in secondary process > > But it triggers > > ../drivers/net/hns3/hns3_mbx.c: In function =E2=80=98hns3_handle_mbx_msg_= out_intr=E2=80=99: > ../drivers/net/hns3/hns3_mbx.c:355:4: warning: implicit declaration of > function =E2=80=98hns3_handle_mbx_response=E2=80=99; did you mean > =E2=80=98hns3_handle_msix_error=E2=80=99? [-Wimplicit-function-declaratio= n] > 355 | hns3_handle_mbx_response(hw, req); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > | hns3_handle_msix_error > > > This is due to missing: > > commit c8dec72de00039f367c1a8cd1f40378d04cf3e8f > Author: Chengwen Feng > Date: Tue Apr 13 19:50:01 2021 +0800 > > net/hns3: fix possible mismatched response of mailbox > > And this one I already called out as a "help for backport" 12 days ago. > > The same is true for: > > ../drivers/net/hns3/hns3_mbx.c:385:10: warning: implicit declaration > of function =E2=80=98rte_thread_is_intr=E2=80=99; did you mean =E2=80=98r= te_thread_setname=E2=80=99? > [-Wimplicit-function-declaration] > 385 | !rte_thread_is_intr()) && hns->is_vf; > | ^~~~~~~~~~~~~~~~~~ > | rte_thread_setname > > Which needs > commit 5c016fc0205a67123481dbe8f9784635beac8a09 > Author: Dmitry Kozlyuk > Date: Sat Sep 26 02:32:42 2020 +0300 > > eal/windows: add interrupt thread skeleton > > FYI for now I'll also drop dbbbad23e380773b37872df2195c4529fd93ca6f from = 19.11.x > > -- > Christian Ehrhardt > Staff Engineer, Ubuntu Server > Canonical Ltd --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd