From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92814A0503 for ; Fri, 1 Apr 2022 09:20:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D5794014F; Fri, 1 Apr 2022 09:20:26 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 3FC8B4014F for ; Fri, 1 Apr 2022 09:20:25 +0200 (CEST) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DB3633F806 for ; Fri, 1 Apr 2022 07:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1648797623; bh=7blcFuubT0/pfrhZ7MnVpTCkdIy9a4BAVGaNmJxRKIk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MNarEEjVxzmzZRNMW9dTXFmqcCNr3Q0RL7/n1o8HjeUwbHcXyiv10D2c+vsPbH62A 87rEdDmHjSI7DmcmQO+ADaKC+jTMwc9KjgZQ0179yoKjVYS4mWX1K87veRgjySp65M rAJozuwze6cgf8w6DzvaK5lz8Mfbb+xAwso/kb4x9STI4NJMnz4DsUIHDRl6ZoK70K Pnh5Qn8ePpiAjF2oDZZbi2MUqNReYieUoRXrPicfBMGBeM/9hQ/UmWtaR88WQYTlkr wEehPTX4ccURNZQokaowdTNl/K8rh2OIUm6gZdaY4AWgXg42AWqlZDOppBQQFNIyKC p2NEVwc/L0MXQ== Received: by mail-qv1-f72.google.com with SMTP id z2-20020a056214060200b00440d1bc7815so1452828qvw.1 for ; Fri, 01 Apr 2022 00:20:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7blcFuubT0/pfrhZ7MnVpTCkdIy9a4BAVGaNmJxRKIk=; b=gNVzABnd1Q1yl+lOJX6QS2uZtsgyhVUPeXcMP6bSNpr/lS6cRn7PDjet88w1lbsccE 9GT+xZSUT9lTgrUc287iAQegHnRiOgF4H7zxWKGzErwI7GEtMD+Y0LmfcwntC/tivxvc n4z639oijXoDvrlfbZe9tWYHA3/MkuLmLUf1lsyDYCTwMbQgXQyRateu3Ura8ZY5sC67 TFLFnkzJTxOlwxWB0IYBgBuXekVME3p5LWOvvKoAY0pQjl7RGpn24I78T68oYub3kcKB eKCrntsa0HUjjz6KYUI4Uh5UBju1EcKICr/GsptZAvy4UD4OrbIhdwgtqm7vP8pz0ahc Y6Vw== X-Gm-Message-State: AOAM531LsesvzMHNdczNtiNUrlL9CpA5d/D2mcX7fEcy443R6DI0EJzs 2G8d3ZGEoi00PDB/1X9kKGiKZIMaXvuf4sSpGvYCv51FQpHB0mcsJnjLixiAfWS674Z5vbCdAUu W3qd1AKrPbglqRlBlowCivktGA9Mpu4leWrdTflLh X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr5886766qkl.86.1648797621630; Fri, 01 Apr 2022 00:20:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxX6tm07eruZsjNCL1c+9VBTMKOEx2k+qzBRMqHjCy5uQd1+GT3LlvCQ9dfowKiRCoaaoAi0iasFAsK2UMcz4g= X-Received: by 2002:a05:620a:f03:b0:67e:1e38:4a0 with SMTP id v3-20020a05620a0f0300b0067e1e3804a0mr5886757qkl.86.1648797621384; Fri, 01 Apr 2022 00:20:21 -0700 (PDT) MIME-Version: 1.0 References: <20220329120953.152396-1-luca.boccassi@gmail.com> <20220329120953.152396-2-luca.boccassi@gmail.com> <2dfafbff07db8c05fd102c76e7da64410135dffe.camel@debian.org> In-Reply-To: From: Christian Ehrhardt Date: Fri, 1 Apr 2022 09:19:55 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1588 To: Vanshika Shukla Cc: Luca Boccassi , dpdk stable , Lingli Chen , Hemant Agrawal , Rajan Gupta , Nipun Gupta Content-Type: multipart/alternative; boundary="000000000000878e0905db929c89" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --000000000000878e0905db929c89 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 1, 2022 at 7:29 AM Vanshika Shukla wrote: > Hi, > I have reviewed the issue. 4690a6114ff6993afc5c005fc340af0b1e4dbe94 commi= t > ( > https://github.com/DPDK/dpdk/commit/4690a6114ff6993afc5c005fc340af0b1e4db= e94) > which is a new feature that is not required to be backported on the stabl= e > branch declares the variable that is causing issue here. I have a patch > ready to fix this issue. Please confirm if I can submit the patch on > stable@dpdk.org mailing list? > Yes you can send it there, here a copy&paste from our call for backports about the preferred style. A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion: [ upstream commit ] For example: https://git.dpdk.org/dpdk-stable/commit/?h=3D18.11&id=3Dd90e6ae6f936ecdc2fd= 3811ff9f26aec7f3c06eb When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example: [PATCH 20.11] foo/bar: fix baz With git format-patch, this can be achieved by appending the parameter: --subject-prefix=3D'PATCH 20.11' Keeping Luca on CC when submitting the patch will also help. Regards, > Vanshika > > -----Original Message----- > From: Luca Boccassi > Sent: Thursday, 31 March 2022 5:56 pm > To: dpdk stable > Cc: Vanshika Shukla ; Lingli Chen < > linglix.chen@intel.com>; Hemant Agrawal > Subject: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with > RTE_LIBRTE_IEEE1588 > > Caution: EXT Email > > On Tue, 29 Mar 2022 at 15:11, Luca Boccassi wrote: > > > > On Tue, 2022-03-29 at 13:09 +0100, luca.boccassi@gmail.com wrote: > > > From: Luca Boccassi > > > > > > ../drivers/net/dpaa2/dpaa2_rxtx.c: In function =E2=80=98dpaa2_dev_rx= =E2=80=99: > > > ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: =E2=80=98priv=E2=80= =99 undeclared > (first use in this function); did you mean =E2=80=98ldiv=E2=80=99? > > > priv->rx_timestamp =3D > > > ^~~~ > > > ldiv > > > > > > Bugzilla ID: 982 > > > > > > Fixes: 1d10966a22ca ("net/dpaa2: fix timestamping for IEEE1588") > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > drivers/net/dpaa2/dpaa2_rxtx.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c > > > b/drivers/net/dpaa2/dpaa2_rxtx.c index ecd004f9fa..23e193f86c 100644 > > > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > > > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > > > @@ -772,6 +772,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > > > const struct qbman_fd *fd; > > > struct qbman_pull_desc pulldesc; > > > struct rte_eth_dev_data *eth_data =3D dpaa2_q->eth_data; > > > +#if defined(RTE_LIBRTE_IEEE1588) > > > + struct dpaa2_dev_priv *priv =3D eth_data->dev_private; #endif > > > > > > > > > if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > > > ret =3D dpaa2_affine_qbman_swp(); > > > > FYI Vanshika, Hemant and Lingli > > Ping - this is a blocker for the 20.11.5 LTS release, would it be possibl= e > to have a quick review from NXP? > > Thanks! > --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd --000000000000878e0905db929c89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Apr 1, 2022 at 7:29 AM Vanshi= ka Shukla <vanshika.shukla@nx= p.com> wrote:
Hi,
I have reviewed the issue. 4690a6114ff6993afc5c005fc340af0b1e4dbe94 commit = (https://github.com/DPDK= /dpdk/commit/4690a6114ff6993afc5c005fc340af0b1e4dbe94) which is a new f= eature that is not required to be backported on the stable branch declares = the variable that is causing issue here. I have a patch ready to fix this i= ssue. Please confirm if I can submit the patch on stable@dpdk.org mailing list?

Yes you can send it there, here a copy&paste fro= m our call for backports about the preferred style.

A backport should contain a reference to the DPDK main branch commit =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
in it's commit message in th= e following fashion: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2= =A0 [ upstream commit <commit's dpdk main branch SHA-1 checksum> = ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
=C2=A0For example: = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0https://git.dpdk.org/dpdk-stable/commit/?h=3D18.11&id=3Dd90e6ae6f9= 36ecdc2fd3811ff9f26aec7f3c06eb
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
=C2=A0When sending the backported = patch, please indicate the target branch in the =C2=A0 =C2=A0 =C2=A0
=C2= =A0subject line, as we have multiple branches, for example: =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
= =C2=A0 =C2=A0 =C2=A0[PATCH 20.11] foo/bar: fix baz =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
=C2=A0= With git format-patch, this can be achieved by appending the parameter: =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0--subject-prefix=3D&= #39;PATCH 20.11'=C2=A0
=C2=A0
Keeping Luca on C= C when submitting the patch will also help.


Regards,
Vanshika

-----Original Message-----
From: Luca Boccassi <bluca@debian.org>
Sent: Thursday, 31 March 2022 5:56 pm
To: dpdk stable <st= able@dpdk.org>
Cc: Vanshika Shukla <vanshika.shukla@nxp.com>; Lingli Chen <linglix.chen@intel.com>= ;; Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1= 588

Caution: EXT Email

On Tue, 29 Mar 2022 at 15:11, Luca Boccassi <bluca@debian.org> wrote:
>
> On Tue, 2022-03-29 at 13:09 +0100, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <bluca@debian.org>
> >
> > ../drivers/net/dpaa2/dpaa2_rxtx.c: In function =E2=80=98dpaa2_dev= _rx=E2=80=99:
> > ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: =E2=80=98priv=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98ldiv= =E2=80=99?
> >=C2=A0 =C2=A0 =C2=A0priv->rx_timestamp =3D
> >=C2=A0 =C2=A0 =C2=A0^~~~
> >=C2=A0 =C2=A0 =C2=A0ldiv
> >
> > Bugzilla ID: 982
> >
> > Fixes: 1d10966a22ca ("net/dpaa2: fix timestamping for IEEE15= 88")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >=C2=A0 drivers/net/dpaa2/dpaa2_rxtx.c | 3 +++
> >=C2=A0 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c
> > b/drivers/net/dpaa2/dpaa2_rxtx.c index ecd004f9fa..23e193f86c 100= 644
> > --- a/drivers/net/dpaa2/dpaa2_rxtx.c
> > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c
> > @@ -772,6 +772,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **b= ufs, uint16_t nb_pkts)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0const struct qbman_fd *fd;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0struct qbman_pull_desc pulldesc;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0struct rte_eth_dev_data *eth_data =3D d= paa2_q->eth_data;
> > +#if defined(RTE_LIBRTE_IEEE1588)
> > +=C2=A0 =C2=A0 =C2=A0struct dpaa2_dev_priv *priv =3D eth_data->= ;dev_private; #endif
> >
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0if (unlikely(!DPAA2_PER_LCORE_DPIO)) {<= br> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D dpa= a2_affine_qbman_swp();
>
> FYI Vanshika, Hemant and Lingli

Ping - this is a blocker for the 20.11.5 LTS release, would it be possible = to have a quick review from NXP?

Thanks!


--
Christian Ehrhardt
Staff Engineer, Ubuntu Ser= ver
Canonical Ltd
--000000000000878e0905db929c89--