From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E013EA0093 for ; Fri, 11 Mar 2022 11:06:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D56CD40042; Fri, 11 Mar 2022 11:06:29 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id BA24B40042 for ; Fri, 11 Mar 2022 11:06:28 +0100 (CET) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 91B553F799 for ; Fri, 11 Mar 2022 10:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646993188; bh=7taYu/ailmasr2kQKvV6G12iv8SeZA+BsQu+1nxmJ6o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ClzQNwtD07fi690P34TYNGkj7MPHq4ddi+aiXGI/oEke9i0KEjCcsbglR+0r9qefQ ulBsyiPANWnF27aU+2igUYvyBzHsP5DY9U0OflB5M5mCjhpE4wMneO6QGbMiHJEg5q Qk5RHQ+nhseFkxaVPAmjFQuLabqMDTjqb+DQtqRyibARWapPwIyjLLynJ044jpM+8a N0YPbI2bSgF07N6ViRKVucTALC+v4ly61Ob1zYAvNdni7GLoEjUNYcMkoEIG7OeIdq ItUHx95ubvNe4wAWrnc0HAWfpn7Xe+S7Gzidh5X/MeAdP9/ehw23VYQ3CIU04fSul4 oLxdFTrSF3X2g== Received: by mail-qt1-f200.google.com with SMTP id r13-20020ac85c8d000000b002e0234f9bb5so6259241qta.0 for ; Fri, 11 Mar 2022 02:06:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7taYu/ailmasr2kQKvV6G12iv8SeZA+BsQu+1nxmJ6o=; b=HNyglk+reR+NII8WIFTjcnVPOaWIJnqc20WIdJ0HUNy6K2DoQHJFBCnCt9XDdAtSl+ 6q/phrJGk/0s929JDSI0I05j/R5YNDKLn6WL24JgHC4/Sq/jXpDXyiYEwl0sWASuf7kF FKY8cGpjnr2ZbF5D9ox0eP8fsXU66UkzneFXU4+TFOpWlz/phZoXEh+LuFANI94yM9iY eT6H9k4A9SKTNKp1VgoBvFyJsiK8xVgA7RsmV8KtxSzCmpuKIFZxfrBL/Xk3g9d2g135 O68wZ/SBVHL80BBpxfo22OICq/AYbcPakYurEJCofwf1APR7kO8RiG1RZzyGImbZXp8B wwkA== X-Gm-Message-State: AOAM531xvhzOPUXquLp8bzhRr7H6A0Si0VbhotDiNCvsaMK2dv7DlJ4L lrUQUkYOW8q4vYXYpcUBrTTKQ4yDZL4AbuXVR+F5yzMbAzxZhFiy6YKAGG/wB5sQIY+6oW8YEw1 U+mszg3WoSBmFxzcx3bxV5gV/G+NAVVNLTVOhb5ln X-Received: by 2002:ac8:57d0:0:b0:2de:3de3:340e with SMTP id w16-20020ac857d0000000b002de3de3340emr7661134qta.621.1646993187439; Fri, 11 Mar 2022 02:06:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvmuN/av80RBz/v5WlhGNw89ze058xcQLmABkfNbqVZKmnnrKqZqfz2BmEYqnHYmK+AJlHm+xlRFXx6Vts6Ig= X-Received: by 2002:ac8:57d0:0:b0:2de:3de3:340e with SMTP id w16-20020ac857d0000000b002de3de3340emr7661119qta.621.1646993187177; Fri, 11 Mar 2022 02:06:27 -0800 (PST) MIME-Version: 1.0 References: <20220311080627.1195847-1-dkozlyuk@nvidia.com> In-Reply-To: <20220311080627.1195847-1-dkozlyuk@nvidia.com> From: Christian Ehrhardt Date: Fri, 11 Mar 2022 11:06:01 +0100 Message-ID: Subject: Re: [PATCH 19.11 0/3] net/mlx5: fix link state detection To: Dmitry Kozlyuk Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Mar 11, 2022 at 9:06 AM Dmitry Kozlyuk wrote: > > [ backport of https://inbox.dpdk.org/dev/20220301121514.41497-1-dkozlyuk@nvidia.com ] > > This patchset fixes two related issues: > * In rare occasions with any HW link state change to UP was missed. > * If a port was DOWN before startup, its netdev would come UP, > but appear DOWN in DPDK (especially probable with ConnectX-4). > > Dmitry Kozlyuk (3): > common/mlx5: add Netlink event helpers > net/mlx5: fix link status change detection > net/mlx5: fix initial link status detection All three applied, thank you > drivers/net/mlx5/mlx5.c | 59 +++++++++++++++--- > drivers/net/mlx5/mlx5.h | 10 ++- > drivers/net/mlx5/mlx5_ethdev.c | 63 +++++++++++++++---- > drivers/net/mlx5/mlx5_nl.c | 107 +++++++++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_trigger.c | 12 +++- > 5 files changed, 224 insertions(+), 27 deletions(-) > > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd