From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEF70A0C4C for ; Wed, 1 Dec 2021 11:31:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AC2F411FE; Wed, 1 Dec 2021 11:31:57 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 9D12340140 for ; Wed, 1 Dec 2021 11:31:56 +0100 (CET) Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6192B3F175 for ; Wed, 1 Dec 2021 10:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638354716; bh=0nOZedTH5tWnmw+ynH+FFmXtiE5o/7o6TYMbn9Ak8YY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qp5Imu61cVcVhxhT6iVPMQKIJ1a5XssGCVCDFxwVF4vhzQpDf78QrYzSIbTy0FQOJ 3DeP7oLJViLaiIEVclyi5/Rmfy1Caw2zZ5AKyHD0TZDNI4mD00eEd+JV1mgJnMrd6s 3vP072t6JmpmOKkl9y4aQ8QwUixSJ2nAUqlB1/zWXzzQWCDD0YzdWNVzI6svSPUyPa Y5Fbtr+cO50Pk1fSNY0Pze956J4CJOa7e5f9bYZZE6sOLkHYjQwa5bWaPx2OZqW3Ty J+dp2mimArsXYUD684jCRnyOPlozII8cDg9HmKLCCkqyHYQAY/k7/G7XikTEGot55v 150DoKXOy8DJA== Received: by mail-qt1-f197.google.com with SMTP id g16-20020ac85810000000b002b212f2662aso30967577qtg.20 for ; Wed, 01 Dec 2021 02:31:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0nOZedTH5tWnmw+ynH+FFmXtiE5o/7o6TYMbn9Ak8YY=; b=m53ER3dyrDHtFV4agtmU2427k4wo8WgAIKcuQhdCwGXSW0LbTAQF4wxZj5JPpCZsnO NH6k7kVeixSTymQz4Osenz2WH06uH30v8M3TIOrg+DJnUYWsSTJAULeapuUfzS39owWu m9REqr+EWGkl5K3CoIjvLjkrJdygnbr01ZbKvPUaFkyrG4D2atNkYuA7Gh0ktDaPKDJ3 K1WpgiSaGvczGFECICnVWvte5UQOdBePgQ+T1kGGan3RdZBRkwDXyuXn/LvKoiY8OBAP WlPS9Jk4B7FwAyhaxKx/H4TYMmJ1s175UmBEHY+VeP3M02KJFgV8nfxeDg35RBjuuRW8 6DZw== X-Gm-Message-State: AOAM532QFiZninU34lhl4XKNWtckN7K1vzzD+hY9/audv5M5vH4cAaWz 2Ld+f/4xco1s5b3gg8ZUB4UR3H25yDURuS67pSrBkheYsnj71OI6HiBMEV1cOz2+loeABl5Ufrq WL8/a8emKdTiy6mvgy13XMcmNybGeYIsaSVnaEChP X-Received: by 2002:ac8:5703:: with SMTP id 3mr5524979qtw.113.1638354715561; Wed, 01 Dec 2021 02:31:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyQwt//W/HCpCGrLdVa35k2pDEVuSWpkqWjBncurSj0B6iMzwef7E1ZxGBzXo83SZk+pUT1JJWzolPXcEzsU8= X-Received: by 2002:ac8:5703:: with SMTP id 3mr5524962qtw.113.1638354715395; Wed, 01 Dec 2021 02:31:55 -0800 (PST) MIME-Version: 1.0 References: <20211201072520.11808-1-elibr@nvidia.com> In-Reply-To: <20211201072520.11808-1-elibr@nvidia.com> From: Christian Ehrhardt Date: Wed, 1 Dec 2021 11:31:29 +0100 Message-ID: Subject: Re: [PATCH 19.11] app/testpmd: fix packet burst spreading stats To: Eli Britstein Cc: stable@dpdk.org, Matan Azrad , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 1, 2021 at 8:26 AM Eli Britstein wrote: > > [ upstream commit 6a8b64fd5e9e8f5572ea4d9de40a1cff23498246 ] > Thanks, applied > RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' > argument, which specifies the maximum number to receive/transmit. > It can be 0..nb_pkts, meaning nb_pkts+1 options. > Testpmd can provide statistics of the burst sizes ('set > record-burst-stats on') by incrementing an array cell of index > . This array is mistakenly [MAX_PKT_BURST] size. Receiving > the maximum burst will cause out of bound write. > Enlarge the spread stats array by one cell to fix it. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Eli Britstein > Reviewed-by: Matan Azrad > Acked-by: Ferruh Yigit > --- > app/test-pmd/testpmd.c | 2 +- > app/test-pmd/testpmd.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index bd15fe9e53..f4a54102ca 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1605,7 +1605,7 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs) > total_burst = 0; > burst_stats[0] = burst_stats[1] = burst_stats[2] = 0; > pktnb_stats[0] = pktnb_stats[1] = pktnb_stats[2] = 0; > - for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST; nb_pkt++) { > + for (nb_pkt = 0; nb_pkt < MAX_PKT_BURST + 1; nb_pkt++) { > nb_burst = pbs->pkt_burst_spread[nb_pkt]; > if (nb_burst == 0) > continue; > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index bbe18a7191..334bcc28e6 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -86,7 +86,7 @@ enum { > * that are recorded for each forwarding stream. > */ > struct pkt_burst_stats { > - unsigned int pkt_burst_spread[MAX_PKT_BURST]; > + unsigned int pkt_burst_spread[MAX_PKT_BURST + 1]; > }; > #endif > > -- > 2.28.0.2311.g225365fb51 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd