From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Lijun Ou <oulijun@huawei.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE not present in 19.11.x series
Date: Tue, 1 Jun 2021 10:25:29 +0200 [thread overview]
Message-ID: <CAATJJ0+hWWTxOta4-1JZUWfsWwxVY9kMi-ri29pM5AtdYOrZoA@mail.gmail.com> (raw)
Hi,
this was targeted at the stable releases:
commit 1bdcca8006e4c690d017531f7fc6c31b19ad8d1d
Author: Chengwen Feng <fengchengwen@huawei.com>
Date: Sat Apr 17 17:54:58 2021 +0800
net/hns3: fix flow director lock
But it introduced
../drivers/net/hns3/hns3_flow.c: In function ‘hns3_flow_init’:
../drivers/net/hns3/hns3_flow.c:1168:27: error:
‘RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE’ undeclared (first use in this
function)
1168 | dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/hns3/hns3_flow.c:1168:27: note: each undeclared
identifier is reported only once for each function it appears in
The reason is that this was introduced in 20.11
commit 80d1a9aff7f6088ea97d78e36de3f9edae018f1c
Author: Suanming Mou <suanmingm@nvidia.com>
Date: Thu Oct 15 09:07:47 2020 +0800
ethdev: make flow API thread safe
I'm unsure about the potential implications to e.g. just strip declaring
RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE from your patch so if you'd want to have
that one applied ti 19.11.x I'd ask you to have a more detailed look
and consider providing a backport or letting me know that this patch isn't
needed for 19.11.x
Thanks in advance,
Christian
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
next reply other threads:[~2021-06-01 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:25 Christian Ehrhardt [this message]
2021-06-01 9:19 ` Min Hu (Connor)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0+hWWTxOta4-1JZUWfsWwxVY9kMi-ri29pM5AtdYOrZoA@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=fengchengwen@huawei.com \
--cc=humin29@huawei.com \
--cc=oulijun@huawei.com \
--cc=stable@dpdk.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).