From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6F61A0524 for ; Fri, 4 Jun 2021 07:01:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A76374003C; Fri, 4 Jun 2021 07:01:55 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 77E3D4003C for ; Fri, 4 Jun 2021 07:01:54 +0200 (CEST) Received: from mail-qk1-f198.google.com ([209.85.222.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lp1xy-000695-53 for stable@dpdk.org; Fri, 04 Jun 2021 05:01:54 +0000 Received: by mail-qk1-f198.google.com with SMTP id b3-20020a05620a0cc3b02902e9d5ca06f2so5799089qkj.19 for ; Thu, 03 Jun 2021 22:01:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0J2qKoIsEN+mhR/c2Fe+JEkJvORcvj4/HC9VC6NYghw=; b=IiXRRpI623KpTqdDG/tqXoWochCCvyorY+Q3zVtE3QyVDAv/W0WFtZPQW88nqQVaIE UpT3isufVmxrQHCLwPQJ/TQT6zT6b8ZSTSuZH2t/N9AuN9x4IdI5i5YCeig3Y7nT62z1 wwzY9W04P507NSa76JanDiohJExZS7Ri9SkITx692aHCn3e5r20OCg6pWOw1EcO0TYhn 8OXt4sJ9ke+htbyNN56WdTHJytzIzSHtKRDnn6x9HDgGjK1ctRGcbIkIC0w7Kg9rsjO8 vgznzxnCWJBHd9xjJxJ99RmtijUcBQ+nR/MWK3I4vjnbtQbg87WpZZcXET1ePH7KgJW6 t7yQ== X-Gm-Message-State: AOAM531+0Ow+4lYRA73GAFGg9nauzZ3M8utUxnnxi1ydzRbrxTNF6p0w 2QiKwsHRxc6dLVLNdPZsjorV1iXC4eNFiAbFimyH/GvGbregO0X7BIaCYdl7n3qZ8SV72eopw2f vLqrTjXY7Jup6zJ7cVmgBDB6MOe0O5k2qUSpiHpBk X-Received: by 2002:a37:418d:: with SMTP id o135mr2643526qka.418.1622782913224; Thu, 03 Jun 2021 22:01:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL5Ni+9jyg28Tm0WpTxTKNKn71qoEynR/KMMbI4WNI0RK+raATImUqCnBfIGaNo1R7qM54I25ByKMzaDd3ynE= X-Received: by 2002:a37:418d:: with SMTP id o135mr2643507qka.418.1622782913013; Thu, 03 Jun 2021 22:01:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Fri, 4 Jun 2021 07:01:27 +0200 Message-ID: To: Huisong Li Cc: dpdk stable , Xiaoyun Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Jun 4, 2021 at 3:52 AM Huisong Li wrote: > > > =E5=9C=A8 2021/6/1 19:24, Christian Ehrhardt =E5=86=99=E9=81=93: > > Hi, > > this commit was targted at the stable series: > > > > commit 43f1f8261136852357057b78aa49d354beaf3931 > > Author: Huisong Li > > Date: Wed Apr 28 14:40:44 2021 +0800 > > > > app/testpmd: verify DCB config during forward config > The above patch does not need to be applied to 19.11.x, it is ok. > > As part of that it removes pt_id as it was the last user. > > But this does not work out without the following also in place. > > > > commit 08dcd187068666c96e8a16604a1c96160ed310e9 > > Author: Huisong Li > > Date: Wed Dec 2 20:48:55 2020 +0800 > > > > app/testpmd: fix queue stats mapping configuration > > > > Since the latter is rather massive I have for now dropped 43f1f8261 > > from the queue for 19.11.9. > > Please consider creating a backport or letting me know that this change > > isn't meant to be applied to 19.11.x > > > BTW, the first patch does not conflict if the second patch is applied to > 19.11.x first. Hi Huisong Li, Yes it would apply, but it would not build. On 19.11 there would still be uses of portid_t pt_id left and since in this patch it was removed from start_packet_forwarding it breaks the build. Just adding back the variable as a backport without further investigation if that really would work out well and some testing seemed too risky. --=20 Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd