From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <christian.ehrhardt@canonical.com>
Received: from mail-yw0-f179.google.com (mail-yw0-f179.google.com
 [209.85.161.179]) by dpdk.org (Postfix) with ESMTP id 287225687
 for <stable@dpdk.org>; Thu, 29 Sep 2016 15:06:13 +0200 (CEST)
Received: by mail-yw0-f179.google.com with SMTP id i129so48196319ywb.0
 for <stable@dpdk.org>; Thu, 29 Sep 2016 06:06:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=canonical-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=mqSMw8bzvFuczn7kg1bnKI4GkqcRg3N0tv7ZL/iDKAo=;
 b=pl551maf3eyQO7wD1mGSh1RCdCp/tJ7qTtIR8WwcfiWLYT2HJNQzYrheuMOW2ojrxk
 tK7WeQC/6izzq6fHthP1PyhxE6pgHSutHLTstVtan8LsI6zlWQFyU7F2ebU/LBBSiteA
 tqktuMzzWv65/Trp45sJ2RongRAEgganXmjGhTHfE6wBdsZCBFDzu67kKr8etKn6AUHg
 oFIhr20NalwxOCQdyK+lWRoR0V2AmxVl7K/5cvV1Vr45Ub5AnluSWaBW/sSS7JS7rxr5
 ua5q6lvQqBYUM/1ZpeNd4FLoJgPNTbCShksnMBZs9wr6hWhoMzOXJXev2swU4+rk85Co
 BABA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=mqSMw8bzvFuczn7kg1bnKI4GkqcRg3N0tv7ZL/iDKAo=;
 b=iemR3T6nRsdaV5jlJ5dXzfFPKXwkBnkrei++BSyLG4oXrFtJ/Yu9m5KlRoUApmFJY+
 aeRTjIZSSeFIMVxTkpc9lIpUShst89eFMznrVcMEXf0HpvAp6yxlAMEeEs0KFSP242fM
 I7233vwo77ZqGVcfpFPFa30VkY1b6606MWr+BLLAS+vGzE94pbUQWitegOWtDgYPf2Sy
 2CjIUErvh9POBzLApMfSAKag+qwVa0egVIKj9/aUrmxSvLDxY54pYWvgBBAvOmeZbwLn
 qGGvQD5XxeAMcJ+frFWbq+u8+O3+Sy+awd/1rQpxngrM/I9FqVA5Mwft4CBjQrm331kx
 BRmA==
X-Gm-Message-State: AA6/9RmIDchwXqf8aCzaljob0GLyl60H00gG4KTm8xUGheDAr6pp+xd6cbuUJW41Fjstws5FEjttMcHB4YBR7L7n
X-Received: by 10.129.152.142 with SMTP id p136mr867195ywg.207.1475154372427; 
 Thu, 29 Sep 2016 06:06:12 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.129.119.196 with HTTP; Thu, 29 Sep 2016 06:05:42 -0700 (PDT)
In-Reply-To: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Date: Thu, 29 Sep 2016 15:05:42 +0200
Message-ID: <CAATJJ0+nzVxgxygDRhvjw=7CX2FCxbadoNO-hw8Yk6XALtL1Eg@mail.gmail.com>
To: stable@dpdk.org
Cc: dev <dev@dpdk.org>, Nikhil Rao <nikhil.rao@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 13:06:13 -0000

The patch misses a fixed: line which it should get I think.

But in general If applied -> stable for this one?


On Thu, Sep 29, 2016 at 11:24 PM, Nikhil Rao <nikhil.rao@intel.com> wrote:

> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx as the lower dword of the source
> to cmpxchg8b instead of the lower dword of function argument "src".
>
> Reported-by: Job Abraham <job.abraham@intel.com>
> Tested-by: Job Abraham <job.abraham@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  lib/librte_eal/common/include/arch/x86/rte_atomic_32.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h
> b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h
> index 2e04c75..fb3abf1 100644
> --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_32.h
> @@ -81,7 +81,7 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t
> exp, uint64_t src)
>                         : "memory" );           /* no-clobber list */
>  #else
>         asm volatile (
> -            "mov %%ebx, %%edi\n"
> +            "xchgl %%ebx, %%edi;\n"
>                         MPLOCKED
>                         "cmpxchg8b (%[dst]);"
>                         "setz %[res];"
> --
> 2.7.4
>
>


-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd