From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DC33A00C2 for ; Wed, 8 Dec 2021 15:20:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52AEB406FF; Wed, 8 Dec 2021 15:20:37 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 17012406FF for ; Wed, 8 Dec 2021 15:20:36 +0100 (CET) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0586B3F19E for ; Wed, 8 Dec 2021 14:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638973235; bh=GyDs88ndkI3CaU+mCfql0CIscvHNCQbTe7/cnsEuaXI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cD3EaRLLz3ddrA0sJSANcOB1qKDhCu9Ubjc+IAlvMShUALsONO4BT/0D7Bj2PdtGv pPbkffmCy92GhRAcIoyW891/PvnNfgvF8rjxAo8/kIDygTkGZRN26ivZHSycYQY0qQ z2V5Jpjb0lns255vAM9fjieYkFE7zJMHP7xZ8ui71Vayb3ar9hqTNPwjaEjKbyaFo+ 17km+WQ8rJd7LpKqLr2+mRrW4LTjc8MeMP0a/tD7VWREhOFmI13VKPS7MMAeNhBTM9 ziFALxpnB69OCHMB4oW8qWt+iDB7Dw9fh0AtjmxjZxEh59PfUzNbJdZgFkTODhn5ic lIBHtVbEgF86Q== Received: by mail-qt1-f200.google.com with SMTP id d18-20020a05622a15d200b002acc9aa3e0cso3693828qty.17 for ; Wed, 08 Dec 2021 06:20:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GyDs88ndkI3CaU+mCfql0CIscvHNCQbTe7/cnsEuaXI=; b=CIG0t6Aq9kAV0Cw3eD3grmyLz66C5WowKkKJciqBoN8LRIzFyKm2BW3HXHxmrwK20t wiZBM2c0AV+jd7ACBp4DxUWjfuLsePtepc8CIm9lO7BLdShTdrlQNtwDw+0rYgfVNKZC mGvcRlpO7Yo4A8NgQPaPOMIyp1trYESmspq/LD4jPid4gnQ6XvIMGuWZszUUA6aZ6/SK RbtHBq7jYBn4oJ+Vk16CrxuYBUu1eL8PM3iLokaF+Xzaoqj2N/vOvtak4cdJQJng1TO6 VidWQMnYsuAtn5ChzPhxN8k0yq0UtsX3L9g9akfcH+UiosfJPvKQd2wfqp6+NRof/bBZ i+eA== X-Gm-Message-State: AOAM533i8gpOi1b72Ni2FGlLlkLchgnrqzq/8v4eWuI4qZiJCT5I/AdK X2xTQXqQVddWwXYBiKrOq5jz9HFXFPx2Hl7G9iLQo0o6ohOkOuWZxBV80feb3WcHQZoa0va641B jZThq+vCB/8LOwZgo/r4kO6MweLBtYAYqxTQiUpFl X-Received: by 2002:a05:6214:62b:: with SMTP id a11mr7746452qvx.26.1638973234072; Wed, 08 Dec 2021 06:20:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyy2OvAHjNrmyWKfwdVEf0QD0J08AkfwfA9cja7/fSZfpnh4sgD7NondjoXdU5LIBdLc3DOEFF3K1IDlCPfKk= X-Received: by 2002:a05:6214:62b:: with SMTP id a11mr7746428qvx.26.1638973233878; Wed, 08 Dec 2021 06:20:33 -0800 (PST) MIME-Version: 1.0 References: <20211208102831.204356-1-jie1x.wang@intel.com> In-Reply-To: <20211208102831.204356-1-jie1x.wang@intel.com> From: Christian Ehrhardt Date: Wed, 8 Dec 2021 15:20:08 +0100 Message-ID: Subject: Re: [PATCH 19.11] net/i40e: fix forward outer IPv6 VXLAN To: Jie Wang Cc: stable@dpdk.org, Beilei Xing Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 8, 2021 at 3:32 AM Jie Wang wrote: > > [ upstream commit 8cc79a1636cda2e9d6ba4cfd1cf16cf2a782ae1b ] Thanks, applied > Testpmd forwards packets in checksum mode that it need to calculate > the checksum of each layer's protocol. Then it will fill flags and > header length into mbuf. > > In process_outer_cksums, HW calculates the outer checksum if > tx_offloads contains outer UDP checksum otherwise SW calculates > the outer checksum. > > When tx_offloads contains outer UDP checksum or outer IPv4 checksum, > mbuf will be filled with correct header length. > > This patch added outer UDP checksum in tx_offload_capa and > I40E_TX_OFFLOAD_MASK, when we set csum hw outer-udp on that the > engine can forward outer IPv6 VXLAN packets. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > > Signed-off-by: Jie Wang > Acked-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > drivers/net/i40e/i40e_rxtx.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 508f90595f..b05cb52b22 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -3714,6 +3714,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > DEV_TX_OFFLOAD_IPIP_TNL_TSO | > DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > DEV_TX_OFFLOAD_MULTI_SEGS | > + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM | > dev_info->tx_queue_offload_capa; > dev_info->dev_capa = > RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP | > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 6cba729639..f6868e2ccf 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -66,6 +66,7 @@ > PKT_TX_QINQ_PKT | \ > PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > + PKT_TX_OUTER_UDP_CKSUM | \ > I40E_TX_IEEE1588_TMST) > > #define I40E_TX_OFFLOAD_NOTSUP_MASK \ > -- > 2.25.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd