From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com,
alialnu@nvidia.com, Qiming Yang <qiming.yang@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: Re: [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13
Date: Mon, 3 Jan 2022 12:34:52 +0100 [thread overview]
Message-ID: <CAATJJ0+ytkyE=fEjpVfLw1V1-+Xp+fKnBRu6JB23exxY_nWPvQ@mail.gmail.com> (raw)
In-Reply-To: <20211220104805.92324-3-haiyue.wang@intel.com>
On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".
Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.
> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ice/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
> index 370b33af60..9cfd059781 100644
> --- a/drivers/net/ice/Makefile
> +++ b/drivers/net/ice/Makefile
> @@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
> else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
> CFLAGS_BASE_DRIVER += -Wno-unused-parameter
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
> else
> CFLAGS_BASE_DRIVER += -Wno-unused-parameter
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> --
> 2.34.1
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2022-01-03 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: " Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
2022-01-03 11:34 ` Christian Ehrhardt [this message]
2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
-- strict thread matches above, loose matches on Subject: below --
2021-12-14 16:29 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13 Haiyue Wang
2021-12-14 16:29 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0+ytkyE=fEjpVfLw1V1-+Xp+fKnBRu6JB23exxY_nWPvQ@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=alialnu@nvidia.com \
--cc=haiyue.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).