patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13
@ 2021-12-20 10:48 Haiyue Wang
  2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
  To: stable
  Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
	Wenzhuo Lu, Konstantin Ananyev

Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".

https://reviews.llvm.org/D100581

Bugzilla ID: 913

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ixgbe/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
index 31a418a2c6..c730bbddb4 100644
--- a/drivers/net/ixgbe/Makefile
+++ b/drivers/net/ixgbe/Makefile
@@ -29,7 +29,9 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 #
 CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
 CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
 
 else
 #
-- 
2.34.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13
  2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
@ 2021-12-20 10:48 ` Haiyue Wang
  2022-01-03 11:34   ` Christian Ehrhardt
  2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
  2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
  2 siblings, 1 reply; 7+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
  To: stable
  Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
	Beilei Xing

Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".

https://reviews.llvm.org/D100581

Bugzilla ID: 913

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/i40e/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
index d6ced28f3d..3f7565fbd6 100644
--- a/drivers/net/i40e/Makefile
+++ b/drivers/net/i40e/Makefile
@@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
 CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
 CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
 else
 CFLAGS_BASE_DRIVER  = -Wno-sign-compare
 CFLAGS_BASE_DRIVER += -Wno-unused-value
-- 
2.34.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13
  2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
  2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
@ 2021-12-20 10:48 ` Haiyue Wang
  2022-01-03 11:34   ` Christian Ehrhardt
  2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
  2 siblings, 1 reply; 7+ messages in thread
From: Haiyue Wang @ 2021-12-20 10:48 UTC (permalink / raw)
  To: stable
  Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, alialnu, Haiyue Wang,
	Qiming Yang, Wenzhuo Lu

Check the clang version before enabling '-Wno-unused-but-set-variable',
otherwise it will have "error: unknown warning option".

https://reviews.llvm.org/D100581

Bugzilla ID: 913

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
index 370b33af60..9cfd059781 100644
--- a/drivers/net/ice/Makefile
+++ b/drivers/net/ice/Makefile
@@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
 CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
+endif
 else
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
-- 
2.34.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13
  2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
  2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
  2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
@ 2022-01-03 11:34 ` Christian Ehrhardt
  2 siblings, 0 replies; 7+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
  To: Haiyue Wang
  Cc: stable, yux.jiang, qi.z.zhang, alialnu, Wenzhuo Lu, Konstantin Ananyev

On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".

Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.

> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ixgbe/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 31a418a2c6..c730bbddb4 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -29,7 +29,9 @@ else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
>  #
>  CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
>  CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>
>  else
>  #
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13
  2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
@ 2022-01-03 11:34   ` Christian Ehrhardt
  0 siblings, 0 replies; 7+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
  To: Haiyue Wang; +Cc: stable, yux.jiang, qi.z.zhang, alialnu, Beilei Xing

On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".

Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.

> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/i40e/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
> index d6ced28f3d..3f7565fbd6 100644
> --- a/drivers/net/i40e/Makefile
> +++ b/drivers/net/i40e/Makefile
> @@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
>  CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
>  CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  else
>  CFLAGS_BASE_DRIVER  = -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13
  2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
@ 2022-01-03 11:34   ` Christian Ehrhardt
  0 siblings, 0 replies; 7+ messages in thread
From: Christian Ehrhardt @ 2022-01-03 11:34 UTC (permalink / raw)
  To: Haiyue Wang
  Cc: stable, yux.jiang, qi.z.zhang, alialnu, Qiming Yang, Wenzhuo Lu

On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".

Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.

> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ice/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
> index 370b33af60..9cfd059781 100644
> --- a/drivers/net/ice/Makefile
> +++ b/drivers/net/ice/Makefile
> @@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER +=
>  else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
>  CFLAGS_BASE_DRIVER += -Wno-unused-parameter
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  else
>  CFLAGS_BASE_DRIVER += -Wno-unused-parameter
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang 13
  2021-12-14 16:29 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13 Haiyue Wang
@ 2021-12-14 16:29 ` Haiyue Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Haiyue Wang @ 2021-12-14 16:29 UTC (permalink / raw)
  To: stable
  Cc: christian.ehrhardt, yux.jiang, qi.z.zhang, Haiyue Wang,
	Qiming Yang, Wenzhuo Lu

Disable the -Wunused-but-set-variable option for clang to avoid
compile warning.

Bugzilla ID: 902

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile
index 6c4d155268..370b33af60 100644
--- a/drivers/net/ice/Makefile
+++ b/drivers/net/ice/Makefile
@@ -26,6 +26,7 @@ CFLAGS_BASE_DRIVER +=
 else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y)
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
+CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
 else
 CFLAGS_BASE_DRIVER += -Wno-unused-parameter
 CFLAGS_BASE_DRIVER += -Wno-unused-variable
-- 
2.34.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-01-03 11:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 10:48 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang < 13 Haiyue Wang
2021-12-20 10:48 ` [PATCH 19.11 v1 2/3] net/i40e: " Haiyue Wang
2022-01-03 11:34   ` Christian Ehrhardt
2021-12-20 10:48 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang
2022-01-03 11:34   ` Christian Ehrhardt
2022-01-03 11:34 ` [PATCH 19.11 v1 1/3] net/ixgbe: " Christian Ehrhardt
  -- strict thread matches above, loose matches on Subject: below --
2021-12-14 16:29 [PATCH 19.11 v1 1/3] net/ixgbe: build failure with make and clang 13 Haiyue Wang
2021-12-14 16:29 ` [PATCH 19.11 v1 3/3] net/ice: " Haiyue Wang

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git