From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AEB1A0093 for ; Mon, 3 Jan 2022 12:35:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 139524003C; Mon, 3 Jan 2022 12:35:21 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id D01514003C for ; Mon, 3 Jan 2022 12:35:19 +0100 (CET) Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A78163F1A2 for ; Mon, 3 Jan 2022 11:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641209719; bh=tA81yIGcS0UoVbmNeogykL/kC0ngXURL3YG26hFRRws=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tbS2CG6apoP36XSYwMPb6YQJtpmfb5G4EKKkmYaaBBgdEkhaMc2/DZbkLe4aRFWr+ nGo95FWpnGM7y3VU3xtqRuwuZSoTPRV9CjodfyaY+UHdltd+yOv07aX99O+KylMMRz 6uA9Gjmzh3Hy/vBa2EHhX9EllCvedWlNnSk8ite4FodpjSZp6fTuf3mYrw1ThGe5RW 3m3lrThUL0CMCiX77NgQbxUfKX8TXIbwu8vcB92KvpQmoYHKeyv9rZriICk3Z4ZUeB 0S5TpwV/FE7yG94oh9zasiPK2hoS7yJgF+1Hdm1F+hgdgzPIHGM8R63S1KTmluoviW 8RThBkNGGlGVQ== Received: by mail-qt1-f198.google.com with SMTP id g16-20020ac85810000000b002b212f2662aso25405358qtg.20 for ; Mon, 03 Jan 2022 03:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tA81yIGcS0UoVbmNeogykL/kC0ngXURL3YG26hFRRws=; b=YTP4TmHpTdVyd0NVmKRaXKtmxyDyW3+w6SPElZwrOMgf/3aFN9uz2ruOA9rcvlMser Ck0Bwo9/PCmEkg4yUd53VDguE9uONZzUOWgahh6SwdjmkkUg8rPVONSC/ooVqqp2kU/k SjEUzMc/zhK2ZkPYfM6sBpQJmomRADgC3cS+48ggT6TG2gGbTydKbTWL8bZhw/JR8a1O T0a8QB14IZTCpLYiZS4zeBNyxY5TKvp1VUFNrg9ZGgNmYUwjkOJDCJf+udlk/6p3hA1r v5zKHyCjYu3yOswH+FAOc3L1TC+9lunu3AVIviH5Lk9jaV1fcQ9ZVMdDxL32/E096Nwi IsQQ== X-Gm-Message-State: AOAM532TpQAc4+ZM6g/Ll0ti2gSty8kygTDQ/5fiCLQ1JZn83+X0VhzF 51HUAM87PHq+wgfW1rL8WXgc/pO0KAwE9OMAQ9OBZR3xy3uwfGpt/0XJCI6poRH/wnbQbeDwxjO 7lvW7GWr+tQED7k92L09FJrv/M4YC+948/2+2TVxV X-Received: by 2002:a05:620a:2407:: with SMTP id d7mr32327217qkn.114.1641209718782; Mon, 03 Jan 2022 03:35:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJypp/tiWJRMpNcOctjkmNbIOvm2XFsOpQKKoIlX2l1HFIzyAEeda9Hxt03QTtdpPh5sdRiWJ4NtTehB4VE/Fiw= X-Received: by 2002:a05:620a:2407:: with SMTP id d7mr32327210qkn.114.1641209718584; Mon, 03 Jan 2022 03:35:18 -0800 (PST) MIME-Version: 1.0 References: <20211220104805.92324-1-haiyue.wang@intel.com> <20211220104805.92324-3-haiyue.wang@intel.com> In-Reply-To: <20211220104805.92324-3-haiyue.wang@intel.com> From: Christian Ehrhardt Date: Mon, 3 Jan 2022 12:34:52 +0100 Message-ID: Subject: Re: [PATCH 19.11 v1 3/3] net/ice: build failure with make and clang < 13 To: Haiyue Wang Cc: stable@dpdk.org, yux.jiang@intel.com, qi.z.zhang@intel.com, alialnu@nvidia.com, Qiming Yang , Wenzhuo Lu Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang wrote: > > Check the clang version before enabling '-Wno-unused-but-set-variable', > otherwise it will have "error: unknown warning option". Thanks, Queued for 19.11.11 as it improves some other recently added compiler fixes and we'd want to avoid those breaking older clang builds. > https://reviews.llvm.org/D100581 > > Bugzilla ID: 913 > > Signed-off-by: Haiyue Wang > --- > drivers/net/ice/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile > index 370b33af60..9cfd059781 100644 > --- a/drivers/net/ice/Makefile > +++ b/drivers/net/ice/Makefile > @@ -26,7 +26,9 @@ CFLAGS_BASE_DRIVER += > else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) > CFLAGS_BASE_DRIVER += -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable > +endif > else > CFLAGS_BASE_DRIVER += -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > -- > 2.34.1 > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd