From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 19.11] config: fix C++ cross compiler for ARM
Date: Fri, 8 Jul 2022 10:07:56 +0200 [thread overview]
Message-ID: <CAATJJ0J-0jOuvQ1OLGugwNhxYZviDrnmFN6MRba2d895Jwzh2Q@mail.gmail.com> (raw)
In-Reply-To: <20220707094756.20142-1-kda@semihalf.com>
On Thu, Jul 7, 2022 at 11:48 AM Stanislaw Kardach <kda@semihalf.com> wrote:
>
> [ upstream commit f75dd6d3b1215c2e7cdbdc290b5789517c8cfe10 ]
Thank you, applied to the WIP branch for 19.11.13
> Through some mixup all cross-files for ARM platform were using C
> Preprocessor (cpp) instead of GCC (g++).
> This caused meson to fail detecting the C++ compiler presence and
> therefore disabling some targets (i.e. C++ include file checks).
>
> Fixes: e53a5299d219 ("build: support vendor specific ARM cross builds")
>
> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/arm/arm64_armada_linux_gcc | 2 +-
> config/arm/arm64_armv8_linux_gcc | 2 +-
> config/arm/arm64_bluefield_linux_gcc | 2 +-
> config/arm/arm64_dpaa_linux_gcc | 2 +-
> config/arm/arm64_emag_linux_gcc | 2 +-
> config/arm/arm64_n1sdp_linux_gcc | 2 +-
> config/arm/arm64_octeontx2_linux_gcc | 2 +-
> config/arm/arm64_thunderx2_linux_gcc | 2 +-
> config/arm/arm64_thunderx_linux_gcc | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc
> index fa40c0398f..d78c99e8e8 100644
> --- a/config/arm/arm64_armada_linux_gcc
> +++ b/config/arm/arm64_armada_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-ar'
> as = 'aarch64-linux-gnu-as'
> strip = 'aarch64-linux-gnu-strip'
> diff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc
> index 88f0ff9dae..057d70bbdd 100644
> --- a/config/arm/arm64_armv8_linux_gcc
> +++ b/config/arm/arm64_armv8_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc
> index 86797d23cd..616e633495 100644
> --- a/config/arm/arm64_bluefield_linux_gcc
> +++ b/config/arm/arm64_bluefield_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc
> index 1a46821543..0108bb952a 100644
> --- a/config/arm/arm64_dpaa_linux_gcc
> +++ b/config/arm/arm64_dpaa_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-ar'
> as = 'aarch64-linux-gnu-as'
> strip = 'aarch64-linux-gnu-strip'
> diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc
> index 8edcd3e976..3bb5134224 100644
> --- a/config/arm/arm64_emag_linux_gcc
> +++ b/config/arm/arm64_emag_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc
> index 022e063039..421d06c77f 100644
> --- a/config/arm/arm64_n1sdp_linux_gcc
> +++ b/config/arm/arm64_n1sdp_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc
> index 365bd7cbdd..0d7a66c97e 100644
> --- a/config/arm/arm64_octeontx2_linux_gcc
> +++ b/config/arm/arm64_octeontx2_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc
> index 2b41acc615..24346ffe71 100644
> --- a/config/arm/arm64_thunderx2_linux_gcc
> +++ b/config/arm/arm64_thunderx2_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> diff --git a/config/arm/arm64_thunderx_linux_gcc b/config/arm/arm64_thunderx_linux_gcc
> index 6572ab615d..cbf60bac73 100644
> --- a/config/arm/arm64_thunderx_linux_gcc
> +++ b/config/arm/arm64_thunderx_linux_gcc
> @@ -1,6 +1,6 @@
> [binaries]
> c = 'aarch64-linux-gnu-gcc'
> -cpp = 'aarch64-linux-gnu-cpp'
> +cpp = 'aarch64-linux-gnu-g++'
> ar = 'aarch64-linux-gnu-gcc-ar'
> strip = 'aarch64-linux-gnu-strip'
> pkgconfig = 'aarch64-linux-gnu-pkg-config'
> --
> 2.34.1
>
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2022-07-08 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 9:47 Stanislaw Kardach
2022-07-08 8:07 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0J-0jOuvQ1OLGugwNhxYZviDrnmFN6MRba2d895Jwzh2Q@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=bruce.richardson@intel.com \
--cc=kda@semihalf.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).